From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 82E3B1B425 for ; Mon, 5 Feb 2018 19:42:05 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2018 10:42:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,465,1511856000"; d="scan'208";a="25008077" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by FMSMGA003.fm.intel.com with ESMTP; 05 Feb 2018 10:42:02 -0800 To: Pascal Mazon , dev@dpdk.org, vipin.varghese@intel.com Cc: deepak.k.jain@intel.com References: <1517422961-21284-1-git-send-email-vipin.varghese@intel.com> From: Ferruh Yigit Message-ID: <827430d4-4bc4-edab-0915-98c47a508392@intel.com> Date: Mon, 5 Feb 2018 18:42:01 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/tap: allow user MAC to be passed as args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 18:42:05 -0000 On 2/5/2018 3:54 PM, Pascal Mazon wrote: > From: Vipin Varghese > > Allow TAP PMD to pass user desired MAC address as argument. > The argument value is processed as string, where each 2 bytes > are converted to HEX MAC address after validation. > > Signed-off-by: Vipin Varghese > Signed-off-by: Pascal Mazon <...> @@ -278,15 +282,8 @@ tap_rx_offload_get_queue_capa(void) > static bool > tap_rxq_are_offloads_valid(struct rte_eth_dev *dev, uint64_t offloads) > { > - uint64_t port_offloads = dev->data->dev_conf.rxmode.offloads; > - uint64_t queue_supp_offloads = tap_rx_offload_get_queue_capa(); > - uint64_t port_supp_offloads = tap_rx_offload_get_port_capa(); > - > - if ((offloads & (queue_supp_offloads | port_supp_offloads)) != > - offloads) > - return false; > - if ((port_offloads ^ offloads) & port_supp_offloads) > - return false; > + (void)dev; > + (void)offloads; This part seems unrelated with the patch?