From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFCC542916; Tue, 11 Apr 2023 05:21:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67B0340DFD; Tue, 11 Apr 2023 05:21:21 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2084.outbound.protection.outlook.com [40.107.20.84]) by mails.dpdk.org (Postfix) with ESMTP id B2F3240A8B for ; Tue, 11 Apr 2023 05:21:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cW/xHDUjVWtTam0s8NcMBG6za+Lbxb9IOE9Rma0budrMNMkT39MUEEIwrM0lproCDV4QcNtRgLUeKN0mgOSzzDAjumkgA0Ae0QMamMW2n4KKRL69/ptbzHdqEmz/mtKDfMEoN6wQ9wlLfoItR1HvJcLlUmXI7RCtPeMF4B1ih9tO2oVaZiCWRydjqeKJLtXDiudP/nExOMNxDXaGbVTgqmhlA/VLHM6ZkOpY2EFo4T7+Fg/siyx2V3I5Fu4qoR+LbWaRLAwctzjFliEOT0LzMjopVEaYHVnUg+9Idp6wXpaxTVKnR9aY0sPmPpks7JL/UHGwBaCfOEvR69DtFHK2jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qpq6q/4FZhcjvCbeWAdUsf4eqQ30th67TGZdZW4NavA=; b=O2buURzZb+57uoj9M+JRGDzG9gZstShT/tkXgagXzl88b9XvwnQUcKr9il08ckE8peqUrWTKWaXAYMVRo2GJRciA8zBmfWZ3sMY81QKndZYEGu6jegzHoD9Z2We9g/VLP9T7TIEVzARrPKeNDCHiNCDriMHqcMu/gOTpJhhbRos/PIY/8vqGA2xC4y2bRwChv0Q9ZdcjqqFIkd58+0+AsvaojFMvndQhS3QalW/REVikIeNxSjr9wqCPxwB0wkDfibINgW2i9TMAfdmFlyWPsRzZtdVKOufq/4wQgl7vgfCu2yZp3H/xqDIyJNAShIkVVl7lj1q1MbTHr2XxVAu4oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qpq6q/4FZhcjvCbeWAdUsf4eqQ30th67TGZdZW4NavA=; b=eFk6AGnUKgRY95YsADzupR2oLDIVL2VxpS/gatJ+j5PGKO3WsGRyNaIPvbdeN2XGBqZUfBpwp+01nxUuqRxc+vlfqoU7zbOgUTI2ke60zDaCanAHq42Ou9UfHVTqv8IOdBx0EDnD5Ghfx9BaWE6eg3goP55TbHH7o99PhSljnNc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AS8PR04MB8562.eurprd04.prod.outlook.com (2603:10a6:20b:421::9) by PAXPR04MB9469.eurprd04.prod.outlook.com (2603:10a6:102:2b4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.34; Tue, 11 Apr 2023 03:21:17 +0000 Received: from AS8PR04MB8562.eurprd04.prod.outlook.com ([fe80::b764:975d:fca9:1c8a]) by AS8PR04MB8562.eurprd04.prod.outlook.com ([fe80::b764:975d:fca9:1c8a%6]) with mapi id 15.20.6277.038; Tue, 11 Apr 2023 03:21:17 +0000 Message-ID: <8275cebd-e489-3d9f-cf95-e23c1532426a@oss.nxp.com> Date: Tue, 11 Apr 2023 08:51:00 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 16/16] enable lock check Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: thomas@monjalon.net, Chenbo Xia , Anatoly Burakov , Hemant Agrawal , Sachin Saxena , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Matan Azrad , Viacheslav Ovsiienko , Pavan Nikhilesh , Shijith Thotton , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , John Daley , Hyong Youb Kim , Gaetan Rivet , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Dongdong Liu , Yisen Zhuang , Ferruh Yigit , Andrew Rybchenko , Konstantin Ananyev , Vladimir Medvedkin , Erik Gabriel Carrillo , Maxime Coquelin References: <20230224081642.2566619-1-david.marchand@redhat.com> <20230404124840.1898-1-david.marchand@redhat.com> <20230404124840.1898-17-david.marchand@redhat.com> From: "Sachin Saxena (OSS)" Organization: NXP In-Reply-To: <20230404124840.1898-17-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SI2PR06CA0016.apcprd06.prod.outlook.com (2603:1096:4:186::22) To AS8PR04MB8562.eurprd04.prod.outlook.com (2603:10a6:20b:421::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8562:EE_|PAXPR04MB9469:EE_ X-MS-Office365-Filtering-Correlation-Id: 4718b241-48d7-48c6-a327-08db3a3bcfec X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eDqp3wNkNMx6vyqRCOv7NUzLn/Vl987JfuikhJ/zpJBk76nIvI/+0UO2+jFBihOt2mKMIrMMRI42wqpJW/NgSQvVMWaR03KAROOXcNP1AJ3OdjXFVHwmW8WVUjN8GGTD0wn9iXoW5kTgiWcO1O3aqJPpL3G6mXVMCkmoahcLo+9KjXx3iaKuN4wOvwK0Kn3VTeHw8+ESgMtPpYBPrquPu/JUfgDssJG0EeP60clCLQMnboyzqWv54RrQULXjg1lE5IEmGZevlef9TUru9zaXmPKyqTzZGGWpVwzA/Z36Wc9gYnbG7HLlHv44RAbwG7dcqwTrIMt4NcgHjiDDJEVrYxmNUzArfEvOlG5l5LfCboMM0H2Jh3SeiThZ27SJJKbVnjD3qZ17512tWiH0hl20CD+FWX5mQT8lEY7b3JAI9L9WZkwtzclnlYLVl8wjWJGtoMFdKJJS112IGI6+vHke3ZQUpEvM0+uWA/ZVyJiij0FDsNOqDA6OYv66Fg+xItvcehdVRg6ELoM1BqYFY1LOxtWGjJsl7Cz9yrlpOBV0jGuzA2dPRQpCPA9V0FnpkWLrHcvHMwGt0S2vO/M12YInIS1otp+RuRuqzLUj+U5Y3tVPjJO0rHmyWdTyRahlFWF4hIt0S2Ebh078JXCBgbrbZg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8562.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(39860400002)(376002)(366004)(396003)(451199021)(54906003)(478600001)(6666004)(36916002)(6486002)(38100700002)(41300700001)(8676002)(8936002)(316002)(4326008)(66946007)(66556008)(66476007)(2616005)(83380400001)(186003)(6506007)(31686004)(53546011)(6512007)(26005)(5660300002)(7416002)(31696002)(7406005)(86362001)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0lTbGRKWkhwWjFXNWtJWmNDZ1VyUnJVODlWRU1ickluZUxGSlc2S1ordjlF?= =?utf-8?B?aFExMCttaEtkbndKaVJIYlFHOG9tbWdWWFlTWk5oSUdVYmYyTGdTNURFY0Ft?= =?utf-8?B?UE43d3krQy9xak03d0JYNEgzOGJ4ZDJoTW9pQ1AydGowRHc4MGxhY1ZOWTRD?= =?utf-8?B?aE5jczlJQi9KcXVnanJEZ3AxMTZ4RVZNQTVYY0lIK2U2cTk2RnBCa3ZoTm5x?= =?utf-8?B?TjhzVjBWcTYyU0tqMlZ4enRTMk5MUUFiSU5aUE1zalRmenZ0ZkthMHk1QWtt?= =?utf-8?B?WUZ0VXZlSjlKQVNnR0poRHJLbTRiZ0JtbEV2KzFOY0hhQVBoTkdqRDc1NHA1?= =?utf-8?B?Q25TSGNxSTZmUkhnYjlwa1E5d0JWVzdCZ3JOVjJURUMxWW9hWDNBVGNpQXVt?= =?utf-8?B?ZWhYcFZZamVYM3F4RlF3eFVQQThDcnNFbm5hc1U2MmV5dVpmOGlTK2V3KzQx?= =?utf-8?B?RHIxVFM5RWFjMFJXTEtEbi9yQVRmeDFJSW1saXU0b3krdXpGZlhUbWs3b284?= =?utf-8?B?U0NySnROT2VYSzIvNUliNmVZNUpkRGt6ckZFZmY1VnBYcHFHUDFqaHE0UFBh?= =?utf-8?B?TUM2amRtZ0JnUHN4SG9BS3ZGSWRzazJ3TEIzQ0RpV2lLd0dUNVJscTl2b2NL?= =?utf-8?B?dEVOV24vczVBZSs0WXZmbERBVWp6SzA0SGJnUVl0b3ArNE9DUkl5UjBNUFRH?= =?utf-8?B?MGJBMkNwNkFWUk5tL1pMNU56N056bjNMY294dzUwWEFvUDRvdFNVZGlTZ2lS?= =?utf-8?B?V3lldmtiSDlWS0d5Z01xU08yalYycVl1cXdib1VmN0ZzRC9wOGFrYTR4OXdi?= =?utf-8?B?OG5pZXd1WnM4Y05oc1ZPMC9OdVBtbmtGSTBqQmtlRi9aY05LSHZTVVE3V2Qz?= =?utf-8?B?WVdZOGIrOVNHWC93cEFuVUovQnJsS29yUnFLQVdjVWFQL1BPRkhkcU9BbGVU?= =?utf-8?B?Y3hvRTIzdWVQM0pXdnkvRC9KRzNYeVBqTHE4NHhpbU8xNitUeCtYeDJIaTB0?= =?utf-8?B?dnFjMm56T05GbC9pbUdiYUJNWldLOXBZai9ZdEJraktGdXR1bStpZGNmUmVM?= =?utf-8?B?MFFYQTUxNkFpMUdnWDBvVlJzZllQT0l1RWZVVHVVRVdiUjltWlNGWmh4RGN0?= =?utf-8?B?elp4QUhlWUp2QWNIcTVpY294QzB4bFpWOHBSbEJGTHVWMHJzYWFhd1A1bDkr?= =?utf-8?B?ZTIxdkFVaEFvSlh5QWY4ZHhWcG9vNnhzdGVtVGV0MFJUVzVLU09kaVlUMkMw?= =?utf-8?B?VGM3YmVtK2RHOUJrY3RFbHA5UU1zeGtmTzNOVHdmRFMwRFZEdGxHUU9BOE83?= =?utf-8?B?YUlwOGVubFJ5bktjc0JQN3lLWExxcUpjekpIUVN4bUNmYXJRNkdoSmF6ZC9D?= =?utf-8?B?YnA4UFFVMnN2eXRFUW5XV1dNMU9ySmRkTUJBMG1JU0Vmdi9VaGNOeElLRXhM?= =?utf-8?B?VmlJUXJIdDl5S0ZYN3kwSVlNdFJwNWNaUGNWd2pVRFNGS3ZwOTJwVlQ4eWpr?= =?utf-8?B?Y2FOeVJtMUJWRk0zMlRqRlJsdzByWDhUZm03STkzSWRVSThrN1ZYZkZTTGRw?= =?utf-8?B?eUNhNVlINURTU1pFd3h6N256QldxejRDRyswUUZ6T3VISUxjS3JjenBRdnQy?= =?utf-8?B?NjJFdjkybHRlanJHMUc1Y3pXTUtiTW53bjVKSE1RYy9Says3SjM1ZlFSUkU4?= =?utf-8?B?T3pyeHVPMzl2SC9DVWk4Z1dRT0FXZUUrWHBNcXBCN2N4MUdPa1YvZFhYbktC?= =?utf-8?B?M0hBbVlwaXhoL1U2TDdoNXZqWXNHcS9KYkd1Qnc0dU44TDBDM1d0QjlpQ3pm?= =?utf-8?B?V0NJWmJYOFZkSGdNc0x2elN1WXNTRXZkTG0wYll1ZEpwczA4SFNNUitHZGtD?= =?utf-8?B?VmRUQXhlbnpMamdWZnhaR3BpRm1lMktrYUNIWnVzRnhGbW9KWVhFTFFRT0ZV?= =?utf-8?B?aGx3QWNRSEhxRjZGRWV5QmkxbEwzbUQwdGtNempRa2F3VkZETWxOenV6NEZI?= =?utf-8?B?ZFdDRzNud1pieTZPcUlyWlNkOGVZYkZXQ242UDMwR2FBWGo0WlZLa2F5bUtD?= =?utf-8?B?K2d2V1dvams2Y2J0WllEM00wS2xpREs1RWhSbFZqNDVCUjg0MHV1TWRWNTFV?= =?utf-8?B?a0NzNVZad0NKOFp6czM5V29WV1pPSnRpUUtZSzBCWjg2T3FHTlJWWnI2cUp0?= =?utf-8?B?M0E9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4718b241-48d7-48c6-a327-08db3a3bcfec X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8562.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2023 03:21:17.3210 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wocnSaECJtTNN154Jo4AjvUMTY9Z9Eox9YHgHIyz0cVDm2W0Gb+g3H8xvN//+phcZuZdhdRg5zM4CQ2SwVodAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9469 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/4/2023 6:18 PM, David Marchand wrote: > Now that a lot of components can be compiled with the lock checks, > invert the logic and opt out for components not ready yet: > - drivers/bus/dpaa, > - drivers/common/cnxk, > - drivers/common/mlx5, > - drivers/event/cnxk, > - drivers/net/bnx2x, > - drivers/net/bnxt, > - drivers/net/cnxk, > - drivers/net/enic, > - drivers/net/hns3, > - drivers/net/mlx5, > - lib/ipsec, > - lib/timer, > > The FreeBSD pthread API has been annotated but Linux glibc does not have > those annotations. Disable lock checks for FreeBSD where pthread_mutex_* > are used: > - drivers/net/failsafe, > - drivers/net/hinic, > - lib/eal, > - lib/ethdev, > > > Signed-off-by: David Marchand > Reviewed-by: Chenbo Xia > --- > Changes since v2: > - disabled checks on FreeBSD when code relies on pthread mutexes, > > --- > doc/guides/prog_guide/env_abstraction_layer.rst | 5 +++-- > drivers/bus/dpaa/meson.build | 1 + > drivers/common/cnxk/meson.build | 1 + > drivers/common/mlx5/meson.build | 1 + > drivers/event/cnxk/meson.build | 1 + > drivers/meson.build | 2 +- > drivers/net/bnx2x/meson.build | 1 + > drivers/net/bnxt/meson.build | 1 + > drivers/net/cnxk/meson.build | 1 + > drivers/net/enic/meson.build | 1 + > drivers/net/failsafe/meson.build | 4 ++++ > drivers/net/hinic/meson.build | 4 ++++ > drivers/net/hns3/meson.build | 1 + > drivers/net/mlx5/meson.build | 1 + > lib/eal/meson.build | 4 ++++ > lib/ethdev/meson.build | 4 ++++ > lib/ipsec/meson.build | 1 + > lib/meson.build | 2 +- > lib/timer/meson.build | 1 + > lib/vhost/meson.build | 1 - > 20 files changed, 33 insertions(+), 5 deletions(-) > > diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst b/doc/guides/prog_guide/env_abstraction_layer.rst > index 3f33621e05..93c8a031be 100644 > --- a/doc/guides/prog_guide/env_abstraction_layer.rst > +++ b/doc/guides/prog_guide/env_abstraction_layer.rst > @@ -550,8 +550,9 @@ Some general comments: > waiving checks with ``__rte_no_thread_safety_analysis`` in your code, please > discuss it on the mailing list, > > -A DPDK library/driver can enable/disable the checks by setting > -``annotate_locks`` accordingly in its ``meson.build`` file. > +The checks are enabled by default for libraries and drivers. > +They can be disabled by setting ``annotate_locks`` to ``false`` in > +the concerned library/driver ``meson.build``. > > IOVA Mode Detection > ~~~~~~~~~~~~~~~~~~~ > diff --git a/drivers/bus/dpaa/meson.build b/drivers/bus/dpaa/meson.build > index 5506f2bffc..183b251459 100644 > --- a/drivers/bus/dpaa/meson.build > +++ b/drivers/bus/dpaa/meson.build > @@ -29,3 +29,4 @@ if cc.has_argument('-Wno-pointer-arith') > endif > > includes += include_directories('include', 'base/qbman') > +annotate_locks = false Acked-by: Sachin Saxena > diff --git a/drivers/common/cnxk/meson.build b/drivers/common/cnxk/meson.build > index 402c3249cd..b32fae9f5a 100644 > --- a/drivers/common/cnxk/meson.build > +++ b/drivers/common/cnxk/meson.build > @@ -89,3 +89,4 @@ sources += files('cnxk_telemetry_bphy.c', > > deps += ['bus_pci', 'net', 'telemetry'] > require_iova_in_mbuf = false > +annotate_locks = false > diff --git a/drivers/common/mlx5/meson.build b/drivers/common/mlx5/meson.build > index 9dc809f192..b5fc4c9346 100644 > --- a/drivers/common/mlx5/meson.build > +++ b/drivers/common/mlx5/meson.build > @@ -45,3 +45,4 @@ endif > mlx5_config = configuration_data() > subdir(exec_env) > configure_file(output: 'mlx5_autoconf.h', configuration: mlx5_config) > +annotate_locks = false > diff --git a/drivers/event/cnxk/meson.build b/drivers/event/cnxk/meson.build > index 3517e79341..89e1aa860f 100644 > --- a/drivers/event/cnxk/meson.build > +++ b/drivers/event/cnxk/meson.build > @@ -480,3 +480,4 @@ endforeach > > deps += ['bus_pci', 'common_cnxk', 'net_cnxk', 'crypto_cnxk'] > require_iova_in_mbuf = false > +annotate_locks = false > diff --git a/drivers/meson.build b/drivers/meson.build > index b85bec235d..74ae8cb96b 100644 > --- a/drivers/meson.build > +++ b/drivers/meson.build > @@ -92,7 +92,7 @@ foreach subpath:subdirs > build = true # set to false to disable, e.g. missing deps > reason = '' # set if build == false to explain > name = drv > - annotate_locks = false > + annotate_locks = true > sources = [] > headers = [] > driver_sdk_headers = [] # public headers included by drivers > diff --git a/drivers/net/bnx2x/meson.build b/drivers/net/bnx2x/meson.build > index 156f97d31f..dbf9c7225d 100644 > --- a/drivers/net/bnx2x/meson.build > +++ b/drivers/net/bnx2x/meson.build > @@ -21,3 +21,4 @@ sources = files( > 'ecore_sp.c', > 'elink.c', > ) > +annotate_locks = false > diff --git a/drivers/net/bnxt/meson.build b/drivers/net/bnxt/meson.build > index 0288ed6262..72d4f82e7c 100644 > --- a/drivers/net/bnxt/meson.build > +++ b/drivers/net/bnxt/meson.build > @@ -72,3 +72,4 @@ if arch_subdir == 'x86' > elif arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64') > sources += files('bnxt_rxtx_vec_neon.c') > endif > +annotate_locks = false > diff --git a/drivers/net/cnxk/meson.build b/drivers/net/cnxk/meson.build > index 8b5773ce65..abece91e40 100644 > --- a/drivers/net/cnxk/meson.build > +++ b/drivers/net/cnxk/meson.build > @@ -197,3 +197,4 @@ endforeach > headers = files('rte_pmd_cnxk.h') > > require_iova_in_mbuf = false > +annotate_locks = false > diff --git a/drivers/net/enic/meson.build b/drivers/net/enic/meson.build > index 0a0992c3cb..bde7428953 100644 > --- a/drivers/net/enic/meson.build > +++ b/drivers/net/enic/meson.build > @@ -43,3 +43,4 @@ elif cc.has_argument('-mavx2') and dpdk_conf.get('RTE_ARCH_64') > c_args: [cflags, '-mavx2']) > objs += enic_avx2_lib.extract_objects('enic_rxtx_vec_avx2.c') > endif > +annotate_locks = false > diff --git a/drivers/net/failsafe/meson.build b/drivers/net/failsafe/meson.build > index 3066d37995..6013e13722 100644 > --- a/drivers/net/failsafe/meson.build > +++ b/drivers/net/failsafe/meson.build > @@ -29,3 +29,7 @@ sources = files( > ) > > require_iova_in_mbuf = false > + > +if is_freebsd > + annotate_locks = false > +endif > diff --git a/drivers/net/hinic/meson.build b/drivers/net/hinic/meson.build > index dbcf177782..8242e0052e 100644 > --- a/drivers/net/hinic/meson.build > +++ b/drivers/net/hinic/meson.build > @@ -18,3 +18,7 @@ sources = files( > ) > > includes += include_directories('base') > + > +if is_freebsd > + annotate_locks = false > +endif > diff --git a/drivers/net/hns3/meson.build b/drivers/net/hns3/meson.build > index 97cb85dcc8..7dcf21f72a 100644 > --- a/drivers/net/hns3/meson.build > +++ b/drivers/net/hns3/meson.build > @@ -32,6 +32,7 @@ sources = files( > 'hns3_common.c', > 'hns3_dump.c', > ) > +annotate_locks = false > > require_iova_in_mbuf = false > > diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build > index dba911693e..3184a41a25 100644 > --- a/drivers/net/mlx5/meson.build > +++ b/drivers/net/mlx5/meson.build > @@ -82,3 +82,4 @@ testpmd_sources += files('mlx5_testpmd.c') > subdir(exec_env) > > subdir('hws') > +annotate_locks = false > diff --git a/lib/eal/meson.build b/lib/eal/meson.build > index 056beb9461..9aa941a5ae 100644 > --- a/lib/eal/meson.build > +++ b/lib/eal/meson.build > @@ -32,3 +32,7 @@ endif > if cc.has_function('getentropy', prefix : '#include ') > cflags += '-DRTE_LIBEAL_USE_GETENTROPY' > endif > + > +if is_freebsd > + annotate_locks = false > +endif > diff --git a/lib/ethdev/meson.build b/lib/ethdev/meson.build > index 9e97f05983..1ba0fac5c0 100644 > --- a/lib/ethdev/meson.build > +++ b/lib/ethdev/meson.build > @@ -44,3 +44,7 @@ driver_sdk_headers += files( > ) > > deps += ['net', 'kvargs', 'meter', 'telemetry'] > + > +if is_freebsd > + annotate_locks = false > +endif > diff --git a/lib/ipsec/meson.build b/lib/ipsec/meson.build > index 0b8b935cd2..ff44d6fbdf 100644 > --- a/lib/ipsec/meson.build > +++ b/lib/ipsec/meson.build > @@ -13,5 +13,6 @@ sources = files('esp_inb.c', 'esp_outb.c', > > headers = files('rte_ipsec.h', 'rte_ipsec_sa.h', 'rte_ipsec_sad.h') > indirect_headers += files('rte_ipsec_group.h') > +annotate_locks = false > > deps += ['mbuf', 'net', 'cryptodev', 'security', 'hash', 'telemetry'] > diff --git a/lib/meson.build b/lib/meson.build > index 0812ce6026..dc8aa4ac84 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -121,7 +121,7 @@ foreach l:libraries > reason = '' # set if build == false to explain why > name = l > use_function_versioning = false > - annotate_locks = false > + annotate_locks = true > sources = [] > headers = [] > indirect_headers = [] # public headers not directly included by apps > diff --git a/lib/timer/meson.build b/lib/timer/meson.build > index 89b17e0397..87bbb10592 100644 > --- a/lib/timer/meson.build > +++ b/lib/timer/meson.build > @@ -3,3 +3,4 @@ > > sources = files('rte_timer.c') > headers = files('rte_timer.h') > +annotate_locks = false > diff --git a/lib/vhost/meson.build b/lib/vhost/meson.build > index 197a51d936..0d1abf6283 100644 > --- a/lib/vhost/meson.build > +++ b/lib/vhost/meson.build > @@ -18,7 +18,6 @@ endif > dpdk_conf.set('RTE_LIBRTE_VHOST_POSTCOPY', cc.has_header('linux/userfaultfd.h')) > cflags += '-fno-strict-aliasing' > > -annotate_locks = true > sources = files( > 'fd_man.c', > 'iotlb.c', -- Thanks, Sachin Saxena (NXP)