From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 42DE72BC3 for ; Fri, 23 Jun 2017 15:02:54 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BEF6820B11; Fri, 23 Jun 2017 09:02:53 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 23 Jun 2017 09:02:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=F6bDBQY1ivcB2NC KyCMhKgG0OqrhXQJhJtk62eR4m4M=; b=Y3KjIV0f1tTjPMWNxB0AgK3u+jRTJfK 3D4T0ZmWpSn8tjgj+0t1+7067kTjl3QR+8Rt8EggmMTCH5KwZHX5JtqalY4j6FAK 1eSi+VJwvrpDO1ZRTyQukECoCo+brdv1lgJOhU/hACvR3pLGX6HLRbTkvA73us0J eW4i2l6P8EtI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=F6bDBQY1ivcB2NCKyCMhKgG0OqrhXQJhJtk62eR4m4M=; b=JyCAH1Pp owtvWYGSrHgRECdBlVC1MA0jvwu7xNRn7fnSt0D6/9iX6TnhPV45WCo+8ilOkyj7 1Z4kd7F6/84d3rBFN63UQSt4Kt+SrMD+pUriXfgUDHIMteJbRi6So6KD0N40UDZP m0GVsWAXjxSo7nOfeIRqcV8W6xWGzKC4jX0AhytYxf7wn1XErHVwg8vEA799N3/+ Etxe8ysdjRud/Vqoll8XAKGCTwMTyYLFd/ZtN/bN2i1IogC46G7UPn06DsZ+5Y6A j18Sph5tanIiNOkXpcYYbVIF60NyllVsXOlvSfKRFoaIkKqV5xQeZ7+Q/4hv7lO7 15Ci72VdkPgCBg== X-ME-Sender: X-Sasl-enc: TR/HEmbAN/00p2Z3pllwWq1wlF4h8BDPlG88mr0ZkIaY 1498222973 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6E1FE243D6; Fri, 23 Jun 2017 09:02:53 -0400 (EDT) From: Thomas Monjalon To: Tonghao Zhang Cc: dev@dpdk.org, Sergio Gonzalez Monroy Date: Fri, 23 Jun 2017 15:02:52 +0200 Message-ID: <8278174.tmcXUfVEQA@xps> In-Reply-To: References: <1494467793-19887-1-git-send-email-nic@opencloud.tech> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] eal: Set numa node value for system which not support it. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jun 2017 13:02:54 -0000 22/06/2017 17:15, Sergio Gonzalez Monroy: > Just fyi, the summary line should be lowercase apart from acronyms (DPDK > guidelines). > > On 11/05/2017 02:56, Tonghao Zhang wrote: > > The NUMA node information for PCI devices provided through > > sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx > > on Red Hat Enterprise Linux 6, and VMs on some hypervisors. > > It is good to see more checking for valid values. > > > > Signed-off-by: Tonghao Zhang > > --- > > IMHO the message could be slightly improved by adding some of the > replies that you made to your v3. > ie. Typical wrong numa node in VMs > > $ cat /sys/devices/pci0000:00/0000:00:18.6/numa_node > -1 [...] > The code changes look fine, so I leave it to Thomas regarding the commit > message :) > > Acked-by: Sergio Gonzalez Monroy Applied, thanks