From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 417F1A0597; Wed, 8 Apr 2020 17:49:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AAD171C0C7; Wed, 8 Apr 2020 17:49:42 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 0CA4D1C0B8 for ; Wed, 8 Apr 2020 17:49:40 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200408154940euoutp01bc95264a9f7e47b0fec474ffe75e1be5~D4ugS3i7L1649016490euoutp01B for ; Wed, 8 Apr 2020 15:49:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200408154940euoutp01bc95264a9f7e47b0fec474ffe75e1be5~D4ugS3i7L1649016490euoutp01B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1586360980; bh=NRt+DoVjG7kzpCqj0Lhp9gYRYDotKD1VNYP3WsETj4U=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=cRYq+uQwoyLI7dsf0l0gmfcX+bQ030OOyL7JWJa/15tFqz0GA6qnJR64svR1hTqgu dd7vTa181ThUh3oNeEl0PInolSIPNRuDublKxMZ41blQ9jQUivYS0vaLWdokC0GwPx j6q3qdObAkfchIPK7wNPvIbWqbune9mkoqBU6X4I= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200408154939eucas1p173250eb40c6f57fe7141bdbdcf5908a2~D4ugFrX9X0842608426eucas1p1I; Wed, 8 Apr 2020 15:49:39 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 3F.92.60679.392FD8E5; Wed, 8 Apr 2020 16:49:39 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200408154939eucas1p1b5f48c933e7e3c712f0cb5efd41ea3bd~D4ufv5GvZ1309313093eucas1p10; Wed, 8 Apr 2020 15:49:39 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200408154939eusmtrp1f0e329e5a8bbe8652efe77c70faa24eb~D4ufvN9T80405604056eusmtrp1X; Wed, 8 Apr 2020 15:49:39 +0000 (GMT) X-AuditID: cbfec7f4-0cbff7000001ed07-42-5e8df29351fb Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 86.63.08375.392FD8E5; Wed, 8 Apr 2020 16:49:39 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200408154935eusmtip2a6153a69f0b4d5276b6db47ac9c0d6e9~D4ublh-4Z3039730397eusmtip2G; Wed, 8 Apr 2020 15:49:34 +0000 (GMT) To: Anoob Joseph , Thomas Monjalon Cc: Akhil Goyal , Declan Doherty , Aviad Yehezkel , Boris Pismenny , Radu Nicolau , Anoob Joseph , "dev@dpdk.org" , "stable@dpdk.org" From: Lukasz Wojciechowski Message-ID: <827f9660-dd8e-8440-c8b0-d34064ffdffe@partner.samsung.com> Date: Wed, 8 Apr 2020 17:49:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA1WSe0hTYRjG+c45286Wk9O6+GZRObpDavdDFysIO2REUEhUZkuPZl7ZUbMI 8p5Upmm3WZnWLBuEFdNMRso25j27SZZSaippm4aX0NTZtjPB/vud53ne7/nej0PisntCdzIs KpZVRiki5EIJUWYae7s2dzDzhPegYRNd0pCP6LrW3zj9WFuK0b9z1Yg2jV4S0eb2ZILuH3yF 0emXKdqaMSGiB9triF0S5nlNloD5W1AkYB7pejEmt/A9zvTcNmCM6cstEfOivxw7KDoq2R7M RoTFs0ovn5OS040dL1DMxHeUUKfpxBPR6wZ0GYlJoDbCgLHPxhJSRhUjyP6jF9gNGTWMoEnF 8MYQgim9UTg9kVSlFfLGEwRtPXec4xYEiUNDjtQcKgBK77c7eC61H2pq8wX2EE5VYfDT3Oww hNQOMKpGHH1SyhdK8n+I7ExQy+BpmcWRmWc76G1nizMzG2pVXYSdxTa9t1jlYJzyh8r8TxjP bvC16wFmLwPKIoKkG5MEf+890JM64OQ50FetFfG8COpzrxL8QBmC5vExxH9UIvicWexMbQOD ddz5ArvhZU6dTSdt7Aotltl8syvklN3GeVkKGekyPu0J3VdvoumuiWddzjsw0JAyQGQjj7wZ u+XN2Cdvxj48L4GU0rt4nq0Bp1ZDSYUXL5+BJHObgOdVkHbvvuj/OH9M5ad0J3vAjSsdzsxK qNOp8QI0S4Pc2DguMpTl1kexZz05RSQXFxXqGRQd+RLZ/tl6a/VwOaqYOKVHFInkLtIqXeYJ mUARz52L1CMgcflcqV+yTZIGK86dZ5XRgcq4CJbTo4UkIXeTbnjYGyCjQhWxbDjLxrDKaRcj xe6JyLuiFa0w+hfoQlw+hjcaLGrV1N6sA8t+HQ/wIy9UnBofSkTxx+58ONzWXeit2TK6VJzU 9yZEvwBLfbfcY5e56NDWlR8mb1154+dlXRwQrlUHZpm0Ch+fnrB9Bldfd9/OIwcunglJN/c1 Xdt5zNq0+Wksd331uvnfQtISCgqDRjTJa+UEd1qxbg2u5BT/AISp0I+vAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDIsWRmVeSWpSXmKPExsVy+t/xe7qTP/XGGTxYIWex/sw8RotTtz8w WyzbspXJ4sPkJYwWx360s1u8edDEYvHu03Ymi7YuAYt/HX/YLT49OMHiwOWx4UQ/q8evBUtZ PRbvecnkMXnhRWaPZ9MPM3kcuzmN3WPjux1MAexRejZF+aUlqQoZ+cUltkrRhhZGeoaWFnpG JpZ6hsbmsVZGpkr6djYpqTmZZalF+nYJehkzt5kUfPWpmLq4hbmBcadtFyMnh4SAiUTjgS1s XYxcHEICSxklfjT/B3I4gBIyEh8uCUDUCEv8udYFVfOaUWLa5r2sIAlhgViJL8vnMYLYIgI+ EidOzmMFKWIWOMQkMePpMTaQhJDALyaJf+uLQGw2AVuJIzO/gjXzCrhJrJ/3mB3EZhFQkVi5 7S1YvSjQ0P7m3YwQNYISJ2c+YQGxOYHiL1fMBLOZBcIknjyazgphi0vcejKfaQKj4CwkLbOQ lM1CUgZhm0nM2/yQGcKWl2jeOhvI5gCy1SSWtSohCy9gZF/FKJJaWpybnltsqFecmFtcmpeu l5yfu4kRGNPbjv3cvIPx0sbgQ4wCHIxKPLwH9vTGCbEmlhVX5h5ilOBgVhLh9W4CCvGmJFZW pRblxxeV5qQWH2I0Bfp5IrOUaHI+MN3klcQbmhqaW1gamhubG5tZKInzdggcjBESSE8sSc1O TS1ILYLpY+LglGpgZGKapHFUmm1ylb+3Z20da+8eU+e3/V+1I5yU0m5Lzj0y3fPrxNXzOO5q r57vIau+//ycqyxaVdmn057vbpt2hGXXt4Z1TksZEk5VT76d0esWseLLPqZnq/MKbBg/NcoW dW24Hsdod36CWPqmXaXlled9ndmnHpTTOqjtKGxRHhfspH/rLW+CEktxRqKhFnNRcSIARNYn u/8CAAA= X-CMS-MailID: 20200408154939eucas1p1b5f48c933e7e3c712f0cb5efd41ea3bd X-Msg-Generator: CA X-RootMTR: 20200408144420eucas1p108841e4e800819ae28159b694659f491 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200408144420eucas1p108841e4e800819ae28159b694659f491 References: <20200312151654.7218-1-l.wojciechow@partner.samsung.com> <1875710.PYKUYFuaPT@thomas> <8635541.CDJkKcVGEf@thomas> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 01/13] security: fix verification of parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi guys, I don't know what is the current status of "legacy" build using gnumakes, so I added the new DEBUG flag to config just as it was done in other libs like eventdev. Many guides still point config files as the one that should be changed in order to enable some features, so I thought I should add it there. If I understand well the official build system now is the one based on using meson and ninja, however it hasn't got anything similar to the gnamakefiles system, e.g. in the meson.build file for libraries all the libraries have build variable set to true and there are few ifs that check it, but as it's set to true all libraries build always. And each library considered there defines RTE_LIBRTE_[LIBRARY_NAME]. It's kind of weird. foreach l:libraries *    build = true** *    reason = '' # set if build == false to explain why     ... *    if not build*         dpdk_libs_disabled += name         set_variable(name.underscorify() + '_disable_reason', reason)     else         enabled_libs += name *dpdk_conf.set('RTE_LIBRTE_' + name.to_upper(), 1)*     ... Have you think about reusing config files in meson configuration and have a single point of configuration? Of course all meson flags can overwrite the default config. Best regards Lukasz BTW I got still some warnings from linters when processing Fixes flags. I used the fixline alias recommended on dpdk build manual, but the automated linter does not find the commits I mention there. What have I done wrong? W dniu 08.04.2020 o 16:44, Anoob Joseph pisze: > Hi Thomas, > >> ---------------------------------------------------------------------- >> 08/04/2020 15:02, Anoob Joseph: >>> Hi Thomas, >>> >>>> 08/04/2020 05:13, Lukasz Wojciechowski: >>>>> This patch adds verification of the parameters to the ret_security >>>>> API functions. All required parameters are checked if they are not NULL. >>>> [...] >>>>> --- a/config/common_base >>>>> +++ b/config/common_base >>>>> CONFIG_RTE_LIBRTE_SECURITY=y >>>>> +CONFIG_RTE_LIBRTE_SECURITY_DEBUG=n >>>> Is it a leftover? >>>> >>> [Anoob] It is similar to 'RTE_LIBRTE_ETHDEV_DEBUG' for usage in >>> datapath. Like in, >>> https://protect2.fireeye.com/url?k=ebdcc0dd-b6100959-ebdd4b92-0cc47aa8f5ba-33f3beec7b92faf2&q=1&u=https%3A%2F%2Furldefense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttp-3A__code.dpdk.org_dpdk >>> _latest_source_lib_librte-5Fethdev_rte-5Fethdev.h-23L4378&d=DwICAg&c=n >>> KjWec2b6R0mOyPaz7xtfQ&r=jPfB8rwwviRSxyLWs2n6B- >> WYLn1v9SyTMrT5EQqh2TU&m= >> STCBgRhcnCb9M6MWQL9CUszLwy2r0NJ_3m93_D5UX3g&s=HVsD0LKZ2Q6UCW >> BSRvbw9beD >>> 7OtuQyWPrRrx9eofnz8&e= >> 1/ I don't see it used in this patch > [Anoob] Following snippet uses. > > +#ifdef RTE_LIBRTE_SECURITY_DEBUG > + RTE_PTR_CHAIN3_OR_ERR_RET(instance, ops, set_pkt_metadata, -EINVAL, > + -ENOTSUP); > + RTE_PTR_OR_ERR_RET(sess, -EINVAL); > +#endif > >> 2/ Adding makefile-only option is weird >> 3/ Adding new compile-time options is discouraged > [Anoob] This is only introduced for data path APIs. And the same approach is followed in eth dev as well. > > Thanks, > Anoob > -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com