From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86087A2F67 for <public@inbox.dpdk.org>; Fri, 4 Oct 2019 19:17:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CC8891C242; Fri, 4 Oct 2019 19:16:59 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8E4921C241 for <dev@dpdk.org>; Fri, 4 Oct 2019 19:16:58 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BE64318C4265; Fri, 4 Oct 2019 17:16:57 +0000 (UTC) Received: from [10.36.118.72] (unknown [10.36.118.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id B0EB560852; Fri, 4 Oct 2019 17:16:56 +0000 (UTC) To: Marcin Baran <marcinx.baran@intel.com>, dev@dpdk.org, bruce.richardson@intel.com References: <20190920073714.1314-1-marcinx.baran@intel.com> <20190930075034.2000-1-marcinx.baran@intel.com> From: Kevin Traynor <ktraynor@redhat.com> Message-ID: <82804089-268a-9a2c-85cb-0dfaaab1963d@redhat.com> Date: Fri, 4 Oct 2019 18:16:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20190930075034.2000-1-marcinx.baran@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Fri, 04 Oct 2019 17:16:57 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v6 0/6] examples/ioat: sample app on ioat driver usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 30/09/2019 08:50, Marcin Baran wrote: > A new sample app demonstrating use of driver for CBDMA. > The app receives packets, performs software or hardware > copy, changes packets' MAC addresses (if enabled) and > forwards them. The patch includes sample application as > well as it's guide. > > v6: > - rearrange 'ioat_tx_port()' to remove unnecessary code > - improve documentation > - format patches for better readability > > v5: > - change dependency name from 'pmd_ioat' to 'rawdev_ioat' > fixing build errors (branch diverged from master) > > v4: > - fix meson build support check > > v3: > - add check for meson build whether IOAT is supported > > v2: > - change printing total stats to be deltas > - update documentation > - fix 1 thread/sw copy/multiple Rx queues packet dropping > - divide patch into several presenting functional change > > > Marcin Baran (4): > examples/ioat: add software copy support > examples/ioat: add rawdev copy mode support > examples/ioat: add stats printing for each port > doc/guides/: provide IOAT sample app guide > > Pawel Modrak (2): > examples/ioat: create sample app on ioat driver usage > examples/ioat: add two threads configuration > > doc/guides/sample_app_ug/index.rst | 1 + > doc/guides/sample_app_ug/intro.rst | 4 + > doc/guides/sample_app_ug/ioat.rst | 581 ++++++++++++++++ > examples/Makefile | 3 + > examples/ioat/Makefile | 54 ++ > examples/ioat/ioatfwd.c | 1003 ++++++++++++++++++++++++++++ > examples/ioat/meson.build | 15 + > examples/meson.build | 1 + > 8 files changed, 1662 insertions(+) > create mode 100644 doc/guides/sample_app_ug/ioat.rst > create mode 100644 examples/ioat/Makefile > create mode 100644 examples/ioat/ioatfwd.c > create mode 100644 examples/ioat/meson.build > Just a nit, but I think you need to add something to the MAINTAINERS file for this example app, maybe it can be a follow up patch if it's the only rework