DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: remove limitation for crypto sessions
Date: Thu, 16 Apr 2020 10:26:03 +0000	[thread overview]
Message-ID: <8280a09d825046249d2cfb4df683ff4a@intel.com> (raw)
In-Reply-To: <VI1PR04MB3168CA8DCA2030ACE1AE4454E6DB0@VI1PR04MB3168.eurprd04.prod.outlook.com>

Hi Akhil,

-----Original Message-----
From: Akhil Goyal <akhil.goyal@nxp.com> 
Sent: Wednesday, April 15, 2020 8:20 PM
To: Medvedkin, Vladimir <vladimir.medvedkin@intel.com>; dev@dpdk.org
Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>
Subject: RE: [PATCH v2] examples/ipsec-secgw: remove limitation for crypto sessions

Hi Vladimir,
> 
> Get rid of hardcoded limit of cryptodev sessions.
> 
> Fixes: e1143d7dbbf4 ("examples/ipsec-secgw: get rid of maximum SA 
> limitation")
> Cc: vladimir.medvedkin@intel.com
> 
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> ---
This will create an issue in case of rte_security sessions.

Rte_security session create APIs were not updated when the provision for having Separate mempools for session and session private data was introduced.
As a result the number of entries in session_priv_pool should be double the number of Supported sessions - one for session and one for session priv data.

This should be fixed in rte_security API but this would mean an API breakage which cannot Be done before 20.11. So this patch need to be deferred till it is not fixed in rte_security.
Or we can have double the number of required entries in mempool.

I will double the number entries in mempool. Thanks!

Regards,
Akhil


  reply	other threads:[~2020-04-16 10:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-10 19:30 [dpdk-dev] [PATCH] " Vladimir Medvedkin
2020-04-14 14:17 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin
2020-04-15 19:19   ` Akhil Goyal
2020-04-16 10:26     ` Medvedkin, Vladimir [this message]
2020-04-20 19:16   ` [dpdk-dev] [PATCH v3] " Vladimir Medvedkin
2020-04-23  0:12     ` Ananyev, Konstantin
2020-05-11 11:06       ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8280a09d825046249d2cfb4df683ff4a@intel.com \
    --to=vladimir.medvedkin@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).