From: fengchengwen <fengchengwen@huawei.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: <ferruh.yigit@intel.com>, <mb@smartsharesystems.com>,
<skori@marvell.com>, <jerinj@marvell.com>, <dev@dpdk.org>,
<linuxarm@openeuler.org>
Subject: Re: [dpdk-dev] [PATCH v3] eal: fix use wrong time API
Date: Tue, 11 May 2021 18:49:43 +0800 [thread overview]
Message-ID: <8284bc61-6bac-0d3d-f676-2a9ea274165d@huawei.com> (raw)
In-Reply-To: <11662132.FWA8Suj1gP@thomas>
On 2021/5/11 15:36, Thomas Monjalon wrote:
> 05/05/2021 05:43, Chengwen Feng:
>> Currently, the mp uses gettimeofday() API to get the time, and used as
>> timeout parameter.
>>
>> But the time which gets from gettimeofday() API isn't monotonically
>> increasing. The process may fail if the system time is changed.
>>
>> This fixes it by using clock_gettime() API with monotonic attribution.
>>
>> Fixes: 783b6e54971d ("eal: add synchronous multi-process communication")
>> Fixes: f05e26051c15 ("eal: add IPC asynchronous request")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> Acked-by: Morten Brørup <mb@smartsharesystems.com>
>> ---
>> v3:
>> * add acked-by.
>> * change patch's author.
>
> I did some comments on v2 about potential errors to catch,
> but you sent this v3 without participating in v2 discussion.
>
>
Fixed in v4, thanks
>
> .
>
next prev parent reply other threads:[~2021-05-11 10:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 8:12 [dpdk-dev] [PATCH] " Min Hu (Connor)
2021-04-28 9:24 ` Morten Brørup
2021-04-28 10:36 ` fengchengwen
2021-04-28 10:59 ` Morten Brørup
2021-04-29 2:12 ` Min Hu (Connor)
2021-04-29 2:10 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-04-29 7:12 ` Morten Brørup
2021-05-04 16:49 ` Thomas Monjalon
2021-05-04 19:12 ` Morten Brørup
2021-05-05 6:14 ` Thomas Monjalon
2021-05-05 6:26 ` Morten Brørup
2021-05-05 6:51 ` Thomas Monjalon
2021-05-05 7:08 ` Morten Brørup
2021-05-05 3:43 ` [dpdk-dev] [PATCH v3] " Chengwen Feng
2021-05-11 7:36 ` Thomas Monjalon
2021-05-11 10:49 ` fengchengwen [this message]
2021-05-11 10:41 ` [dpdk-dev] [PATCH v4] " Chengwen Feng
2021-05-12 14:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8284bc61-6bac-0d3d-f676-2a9ea274165d@huawei.com \
--to=fengchengwen@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=linuxarm@openeuler.org \
--cc=mb@smartsharesystems.com \
--cc=skori@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).