From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7192A053A; Wed, 5 Aug 2020 22:18:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0AF6F37B4; Wed, 5 Aug 2020 22:18:33 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 356962BB5; Wed, 5 Aug 2020 22:18:31 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id C4782714; Wed, 5 Aug 2020 16:18:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 05 Aug 2020 16:18:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= XzBiX58Bav7YMT+CHFK4LCWNNrK/gjLj8dK1pUOwZ+Y=; b=okICvgn9s1hp/znj TB4F/Uc9smlY7BAv/SXfiET81VTInPz4ILUXIApknnjnusrlQSgmZz8sqZtjaiuW ptJEB6sioC9yA4OH4L2r1G7Lr4fBn8Vj/PnGj0WudYcxNei858PJs0+HCIJqvcMP XqG36NwUrqxh3job6u33C+JuC//1K/fbIgHyJTZ5rA5zPP+KplPsWGnd5gSLLcfm lWBwwveYOu6mYQ2UMKa4t5nKZhxJkEn2JIhIc2JPvKbKVju1fuLdU3li1JGXzmoC AV877f+QxyrXzKFI/G0adiBSXzbpGnYMn30Kj56sZNg5WvurTGtVyBQbwquIf6j2 17hjWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=XzBiX58Bav7YMT+CHFK4LCWNNrK/gjLj8dK1pUOwZ +Y=; b=qJN6xf8cIDLKz6JL3/4VRAQO1C4wG9f9P9FspJrhRFkUaKZjRm+swkNr3 yVfkKnfdFhH1OZpO1LBhZjmk75A9Xj+yJ8XLAXY0WtvZfyk015xKFIKVRZsbgEwF xuri503Caa65AKhKiVemuw7w2O6a+GXZXgmSh+UF9iquML3bmkkR4z+2+q19orVs CDUrn6lpTfuWhog4c0SMlFaYmoslvAAYneS5KvTjHlt/xBbxTwze43svFfTwziyJ BMK26HKb5/MleMpXBo8FRHDUqxFWF3xmeSkR3yp+FiB6ZJjpmGZ+xuZPnsLPNzep 4tigNVq1mf3eoTinv2ZkvZRe+ooJQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeekgdduheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A6E5A30600A9; Wed, 5 Aug 2020 16:18:27 -0400 (EDT) From: Thomas Monjalon To: Chenbo Xia , Yinan Wang Cc: dev@dpdk.org, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, kishore.padmanabha@broadcom.com, venkatkumar.duvvuru@broadcom.com, stable@dpdk.org Date: Wed, 05 Aug 2020 22:18:26 +0200 Message-ID: <8291662.ihcAm4ep8e@thomas> In-Reply-To: <20200804174147.64473-1-chenbo.xia@intel.com> References: <20200804174147.64473-1-chenbo.xia@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix variable size of port id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/08/2020 19:41, Chenbo Xia: > Currenly the variable size of ethdev port id is 8 bits. This > patch standarizes it to 16 bits. > > Fixes: 769de16872ab ("net/bnxt: fix port default rule create/destroy") > Cc: stable@dpdk.org > > Reported-by: Yinan Wang > Signed-off-by: Chenbo Xia > --- > drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c > index 9fb1a028f..ff5aed3d7 100644 > --- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c > +++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c > @@ -397,7 +397,7 @@ void > bnxt_ulp_destroy_df_rules(struct bnxt *bp, bool global) > { > struct bnxt_ulp_df_rule_info *info; > - uint8_t port_id; > + uint16_t port_id; There are more occurences in bnxt, introduced by the same patch. In general, in other drivers, it would be good to make this clean-up. git grep 'uint8_t port' | wc -l 297