Re: [dpdk-dev] [PATCH v6 0/5] drivers/net: add NXP ENETFEC driver

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 10/21/2021 5:46 AM, Apeksha Gupta wrote:
> This patch series introduce the enetfec driver, ENETFEC
> (Fast Ethernet Controller) is a network poll mode driver for
> the inbuilt NIC found in the NXP i.MX 8M Mini SoC.
> 
> An overview of the enetfec driver with probe and remove are in patch 1.
> Patch 2 design UIO interface so that user space directly communicate with
> a UIO based hardware device. UIO interface mmap the Control and Status
> Registers (CSR) & BD memory in DPDK which is allocated in kernel and this
> gives access to non-cacheble memory for BD.
> 
> Patch 3 adds the RX/TX queue configuration setup operations.
> Patch 4 adds enqueue and dequeue support. Also adds some basic features
> like promiscuous enable, basic stats.
> Patch 5 adds checksum and VLAN features.
> 
> Apeksha Gupta (5):
>    net/enetfec: introduce NXP ENETFEC driver
>    net/enetfec: add UIO support
>    net/enetfec: support queue configuration
>    net/enetfec: add enqueue and dequeue support
>    net/enetfec: add features
> 

Hi Apeksha,

I have requested for techboard approval on uio part, comparing
having a new bus implementation.

Meanwhile I put some comments on the driver, but initially
it doesn't compile with latest DPDK.

Can you please send a new version that fixes the build error first,
so more checks can be done, later you can continue with other
comments in another version.


Thanks,
ferruh