From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A0CCA0C47; Wed, 27 Oct 2021 16:15:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44F8240E0F; Wed, 27 Oct 2021 16:15:56 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id A2DB740DDA for ; Wed, 27 Oct 2021 16:15:54 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10150"; a="210251301" X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="210251301" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2021 07:15:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="579673228" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga002.fm.intel.com with ESMTP; 27 Oct 2021 07:15:37 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 27 Oct 2021 07:15:37 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 27 Oct 2021 07:15:37 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 27 Oct 2021 07:15:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jWp4j6HVFSswJtpAum8vySH0XJ69izb57oM+WloTFTbYLdU0jeuEottoDb40tBDTdynyZgoIkAqU1V2xkquetTTepPzsVVxCkqm4cFFSyS6mY93OD7WUM8bHdSMYcu+Zz5MPTyl6cN75UrbJXHCP3ai5xBA46ARMai/ghSowULm/ZcTA5h+gG9K1l9I7BkNBiEhj41xz48N7Hrgi7PsbW50/dOnWLN8/lvDQAk/l92PjdufhIpwG40h8uzySyL/moRjz4UEzr73gj5/V4Dg011f6tqhE9Q143p7M7smDfyijfzzU6kL6F09hWATOu/q3TMf2EzMQqU7h4DOFW/IA6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uSvGxLZbebqSMm69jxqq6WhKwrbJv5YMxipsZ1KvgUs=; b=UAqXZaQWjl2yGnGv3j0BjrrzYD5jarXasUKUuOKUHdn6OVrPzEd+JRmZr4Sujm2h6DwefR1LwbYGwdBJbGXqOBa3hOnbG2rDRJ9L3mUzNZq6a0iXnx01AU+fS2X+lX4sdqgz8uUjpFWFlOjSoBtziUxtqe6BIFfG8SbN8u/JjkNiY448BjBok5Y6ufmeuHBLroPkIsa1UnqHDItlgWfOpZ8MNirlAtU03iQZBbXma1kw0HulkaB95qIehbMB1Y21yHPPIDOcqGHWGGtKvZ7YrGqcPmFlVYxb2/GK7nDQGJHC8fmAdXWiJn+rD/wU50AMqDDuridJ2tKE4GvtuyNiag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uSvGxLZbebqSMm69jxqq6WhKwrbJv5YMxipsZ1KvgUs=; b=CdQnxK8FVyMEEh+00w/MgjZxNJn+AdzruGMNWMdvpB/dt83IbNQJLUpUFeKQPs1p27svQndSRQHqVsFY7S3B9g94+bZm2kRqXnXe5YbEYaHSZlEpMkdARYXfHhUVNKzVr/j8BwA1J/1D4JmAdArE9uXEMdCKtY3N8Z5x/Oum+9o= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4998.namprd11.prod.outlook.com (2603:10b6:510:32::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Wed, 27 Oct 2021 14:15:36 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.020; Wed, 27 Oct 2021 14:15:36 +0000 Message-ID: <829304ca-b262-17da-a84d-b093b5a7073e@intel.com> Date: Wed, 27 Oct 2021 15:15:30 +0100 Content-Language: en-US To: Apeksha Gupta , , CC: , , References: <20211019184003.23128-2-apeksha.gupta@nxp.com> <20211021044700.12370-1-apeksha.gupta@nxp.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211021044700.12370-1-apeksha.gupta@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR07CA0067.eurprd07.prod.outlook.com (2603:10a6:6:2a::29) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR07CA0067.eurprd07.prod.outlook.com (2603:10a6:6:2a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.8 via Frontend Transport; Wed, 27 Oct 2021 14:15:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 34a5db2e-03db-44d4-b83e-08d999543ed3 X-MS-TrafficTypeDiagnostic: PH0PR11MB4998: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x5zF/uHtS8qGUJPdbbca1D3+w6YL+XLRBFJ3dRHKRaeV/NIfLM1SFet10iGHDnjMBhimAscz6Hx4Rb8Q290bwM39WejelDg08uaDH613DCAuKpfeX7nVQK8U91Gi8kLAq/u9gkb61wn8u3h5QcFpnvCJT1athoaFEcb5PBo/AgSLYQYnPNNa7Vxjg1ywBxYH4cEwZDmLtduFCgs1EZyPcrX9m7vXcEE+geHHCjFDhb8HfCqemnSDpqQRa0RegJ+RcEyJxSb70+kFIYo+NSmhS0LKrVXyuRm5UNYQ6lv3AFoOqqgg+qUZCVukj9oNFtssdU4q5/x4wEDMNXh5F4LHkiK0RNTdmfEUN0VPLmR9uQ/JigUMJKXhMKkpaKobiv+HJNMFFkonmvxUzDn+4azLe9UP+Kl14fSc/JQ0blVnr9ZaYIKT6YDT8MM+mqQZE+dHEBdvQd0GHSnUE15NcIaWuAa9Nn5KWXXo2sKSGx++iXabyvxlS8r3xV0YdeVAbgyeRKOp3dlfWhEcCkMGdcgOmJeU107kRF2KP+G2HM5RF7KGOn0k3QSeZ75WUtmS1K/Dc3N3GiH7ekw9hgEDA/+0zvpGDk8DgnUwluiDjcolrQQ0fljKw7Zv4XmFSIl67LAL2NheSLXNKO3DE4wqVrO13yO9uLULDHbKVFn8O5z/tZrNP/n4V1vgdCa+kdwt7pgNZ63u7SL1hXw38Gv95H9Y0A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8936002)(66476007)(16576012)(66556008)(2906002)(44832011)(186003)(2616005)(316002)(508600001)(36756003)(38100700002)(8676002)(53546011)(83380400001)(6486002)(31686004)(4326008)(26005)(6666004)(31696002)(82960400001)(956004)(66946007)(86362001)(5660300002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ejFmK0Z6OEcwSElONmhtQVdMWWhReUNZNk9icWpicTJaWGZ5RnJ0Wm9GbWtM?= =?utf-8?B?ZHYzRGZ4UUI2T2xXVC9JT2JObjRyUFZUTzFhWkRBV0xxcmYyRGgzbXpaZEpS?= =?utf-8?B?bGlKcXpvRUphT2RYU1hBbkU4bVN6aFU0bng4a2lyNEVhbEJSTGRNaFd5RVRk?= =?utf-8?B?S0VMa2JSOTRKdFRJTUtLd2tpRE5LVU5qWitnSVdtMjZ2RWZINjRKVzNJeWkv?= =?utf-8?B?SzFrU0RkNEYvaFp6RjZMMno4aW9RUTNZaXNnZGg2Szg2bDJ5T2FRMHFzN21K?= =?utf-8?B?c05NNlk3aVpNUW9XVlcxTEZDVW92UkdWK1M1U0s2a01tMWtZMDdub3BJa0JS?= =?utf-8?B?eWZoUFZPY2p1WllweWVhK3NQbklZTTZRc01rTEJYVHNITW9yK21nSVhlNDFk?= =?utf-8?B?TEVQY2M1Y01CZDZmeTdiblJaZ2pHU2FBK0R3ZGhMMnJwQTFVQzF4N1FuUGQ3?= =?utf-8?B?VGt5aFFKbmRrbTQ2T1BkcGxiR2FpSnpadGlYVUMxYnBGU0VxaGlLNzFkNUp2?= =?utf-8?B?d0dXRWpEUEdzaW55ZG5vckQ2Nm1kYUMzNEh0K3Jiek5jRHN4akIvQU9aQTFy?= =?utf-8?B?SGR6Ulc1WFZKeHJXUU1NTllvdTVLVzZOQkk1TndITjVzKzdVZmVsSkQydjV1?= =?utf-8?B?QXhxc2ptUzlRRm5Qazllc1BuOTFUZEF0YjNjbEp1cFFaeVY4bFh1V3VGa1lS?= =?utf-8?B?djIrQmJla1hCcStSeXZaKytCRTlReGxFRkJ3UEJ6VGVwVnJUL1V6dTFYM25E?= =?utf-8?B?ZzBaVmxDZXVyYVBBMzMwOE50Y1NXc0tPZzMrd2VFQ2JDZkd2NjFpZ2RCYnh5?= =?utf-8?B?TnlTUlVNVEJlYlJNSkQ3T1hYdGhWZFE2OHFsRW9HSGtadjJEUlFqdisyVHl4?= =?utf-8?B?RG90aU93TEpoaDU1QjJKUEtxWjloOUFPNlBMSm9DczhFcnRicFFoT0ZVZFYv?= =?utf-8?B?WHRodFVhbU9BSXpkYStJVUdoZ0dEbkZDWU84emFEemRFVkc0M0phOHBtSE9G?= =?utf-8?B?YWNMV1JBS1BpdGUzQWd2bnE1dVk1VjZPeGl5bGxHVUhjNWM5YjVDaFFmTkRW?= =?utf-8?B?ME1DYTNXcU5IZkNxNGo2MkdSMUo2UU0xZ3FJeVdQMTFEcnAyYWJyMGxuVVVN?= =?utf-8?B?bHNKd3ZJTkVsUVkydFZyT0JVZHpxSnAwRm1ZNjBqcFRXa0pmdEIzOVhwdHVK?= =?utf-8?B?KzlHRWZNMkxxbmUzS0I3YXFWZXg3K0UrM0EzSFBBWG9lMkJUQnlHaUJqUkpa?= =?utf-8?B?cXlkSGNkTFNJcXpuVG1pU01UTWpjMmVhSXhHaFJBaDF1YUxTUkNMRDVIQWhV?= =?utf-8?B?bWsvV0kzUE84R05NdVlQVW0wUTQ0d2xDd1I3Qk5FV1RiQW42OHNuaGtIL3Fl?= =?utf-8?B?cWVUTmg1T1dFVWtIaTZiR3l1ZlAzMHR1Y2RleGo0bWpndThEN0pONVNNTFF0?= =?utf-8?B?dkZKQUNNMTI0U0VLZmNLTUdzSGVLK1YxcGw3UXRaZkdIb0hVRG1rWHFiWFNZ?= =?utf-8?B?R1VpS2ZxYTlUcndXWE9KUmdDcXJzYkNGYWtldGdsWFcrYytFTm9UYzVkMU02?= =?utf-8?B?ajltUDN3S05nYmM2eHBsVjFycHFIMXB4WEZueUdzWEpXaWNNSjdlMlVWOCs2?= =?utf-8?B?LzgwdUZjNWhpYkVPL2ptNVpRQ1d6OVgyOFFFdUxCS3VTcUh4Wnpjdkp6WXZi?= =?utf-8?B?RkJydzhMZmdLSDViTm84bzl3VTd2TTIwUkQ2enJxcVFmQlUzY3ZJRGpCQnRZ?= =?utf-8?B?MC9GMDN1Vk05eEIvclhXK2RHd1hoQ0JNeklvWUtYTkJSL09uQzMrN2J2M3lu?= =?utf-8?B?ZnkzSllOd0hrSTNRY0RrazNlUkRmVnBLbG5pVXMxWmNldFZuaXdyeUZtZDdN?= =?utf-8?B?bFpzbCsyMXc5SDl3QzN5N013NmhyTW5oeDZLU24yZU1jcjlvS1NackJrNk5W?= =?utf-8?B?dWJKNDhRaS9iczBjVitKZmJlT1c1cXc4VG1ROTdwMTlpU2htZ3c3b1Zza2lY?= =?utf-8?B?SUhxVUExVWVmZ2doeVVySG9wMHJmZHRIblJUbWJWTGJoQW5UbFlGUjM2aitQ?= =?utf-8?B?S2FlM0xmWEVVNjErYTZaZ2VWWWFaZkU2eklqcWpIQk5UYWhFL2kwemlHY25N?= =?utf-8?B?QXlNU2h0aDN2YmZWQW9MaTNCYzI4T3FHWk1ORVUzK3B3YzhRRHFmY045dTlT?= =?utf-8?Q?dzZMoyqIM+OWB8nLl6F3Oac=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 34a5db2e-03db-44d4-b83e-08d999543ed3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 14:15:36.2420 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YUaxMPQ1liQdsv/1bfFz/eaN6RabpWGakFevCGw5FL7DvM9qrycl90ovaCwweyeBdqhxDL7X8COuMgD+dZk/wA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4998 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v6 0/5] drivers/net: add NXP ENETFEC driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/21/2021 5:46 AM, Apeksha Gupta wrote: > This patch series introduce the enetfec driver, ENETFEC > (Fast Ethernet Controller) is a network poll mode driver for > the inbuilt NIC found in the NXP i.MX 8M Mini SoC. > > An overview of the enetfec driver with probe and remove are in patch 1. > Patch 2 design UIO interface so that user space directly communicate with > a UIO based hardware device. UIO interface mmap the Control and Status > Registers (CSR) & BD memory in DPDK which is allocated in kernel and this > gives access to non-cacheble memory for BD. > > Patch 3 adds the RX/TX queue configuration setup operations. > Patch 4 adds enqueue and dequeue support. Also adds some basic features > like promiscuous enable, basic stats. > Patch 5 adds checksum and VLAN features. > > Apeksha Gupta (5): > net/enetfec: introduce NXP ENETFEC driver > net/enetfec: add UIO support > net/enetfec: support queue configuration > net/enetfec: add enqueue and dequeue support > net/enetfec: add features > Hi Apeksha, I have requested for techboard approval on uio part, comparing having a new bus implementation. Meanwhile I put some comments on the driver, but initially it doesn't compile with latest DPDK. Can you please send a new version that fixes the build error first, so more checks can be done, later you can continue with other comments in another version. Thanks, ferruh