From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 82A165A58 for ; Fri, 17 Jul 2015 11:24:54 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 17 Jul 2015 02:24:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,495,1432623600"; d="scan'208";a="764414770" Received: from kmsmsx154.gar.corp.intel.com ([172.21.73.14]) by fmsmga002.fm.intel.com with ESMTP; 17 Jul 2015 02:24:52 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.110.15) by KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 17 Jul 2015 17:24:00 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.165]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.129]) with mapi id 14.03.0224.002; Fri, 17 Jul 2015 17:23:53 +0800 From: "Xu, Qian Q" To: "Iremonger, Bernard" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v6 6/6] test-pmd: remove call to rte_eth_promiscuous_disable() from detach_port() Thread-Index: AQHQvwWDYf/HkMsWE0mOqG4qpuKr053fZkUA Date: Fri, 17 Jul 2015 09:23:52 +0000 Message-ID: <82F45D86ADE5454A95A89742C8D1410E01D7D473@shsmsx102.ccr.corp.intel.com> References: <1436968265-14362-1-git-send-email-bernard.iremonger@intel.com> <1436968265-14362-7-git-send-email-bernard.iremonger@intel.com> In-Reply-To: <1436968265-14362-7-git-send-email-bernard.iremonger@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 6/6] test-pmd: remove call to rte_eth_promiscuous_disable() from detach_port() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2015 09:24:55 -0000 Bernard Apply the patchset and run vhost-sample, both vhost-user and vhost-cuse, no= impact. Thx.=20 Thanks Qian -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger Sent: Wednesday, July 15, 2015 9:51 PM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH v6 6/6] test-pmd: remove call to rte_eth_promisc= uous_disable() from detach_port() At this point the stop() and close() functions have already been called. The rte_eth_promiscuous_disable() function does not return on the VM. Signed-off-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 82b465d.= .4769533 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1,7 +1,7 @@ /*- * BSD LICENSE * - * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. + * Copyright(c) 2010-2015 Intel Corporation. All rights reserved. * All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -1542,8 +1542,6 @@ detach_port(uint8_t port_id) return; } =20 - rte_eth_promiscuous_disable(port_id); - if (rte_eth_dev_detach(port_id, name)) return; =20 -- 1.9.1