From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 00E345A6B for ; Tue, 3 Nov 2015 04:45:07 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 02 Nov 2015 19:45:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,237,1444719600"; d="scan'208";a="841674432" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 02 Nov 2015 19:45:06 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 2 Nov 2015 19:45:05 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.199]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.160]) with mapi id 14.03.0248.002; Tue, 3 Nov 2015 11:45:04 +0800 From: "Xu, Qian Q" To: Thomas Monjalon , Marcel Apfelbaum Thread-Topic: [dpdk-dev] [PATCH] vhost-user: enable virtio 1.0 Thread-Index: AQHRBzocfFAQqhpgRkKTx0itcPOzEZ5sA4mAgBzfbYCAAOJXYA== Date: Tue, 3 Nov 2015 03:45:04 +0000 Message-ID: <82F45D86ADE5454A95A89742C8D1410E0317151D@shsmsx102.ccr.corp.intel.com> References: <1444907319-26348-1-git-send-email-marcel@redhat.com> <20151015161150-mutt-send-email-mst@redhat.com> <2518261.T4ICXTenZs@xps13> In-Reply-To: <2518261.T4ICXTenZs@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH] vhost-user: enable virtio 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2015 03:45:08 -0000 DPDK GCC 64bit build on kernel 3.18 will be failed, could you help check? =3D=3D Build lib/librte_pipeline /home/qxu10/virtio-opt-test/dpdk/lib/librte_vhost/virtio-net.c:81:106: erro= r: 'VIRTIO_F_VERSION_1' undeclared here (not in a function) static uint64_t VHOST_FEATURES =3D VHOST_SUPPORTED_FEATURES; = ^ /home/qxu10/virtio-opt-test/dpdk/mk/internal/rte.compile-pre.mk:126: recipe= for target 'virtio-net.o' failed make[5]: *** [virtio-net.o] Error 1 /home/qxu10/virtio-opt-test/dpdk/mk/rte.subdir.mk:61: recipe for target 'li= brte_vhost' failed make[4]: *** [librte_vhost] Error 2 make[4]: *** Waiting for unfinished jobs.... SYMLINK-FILE include/rte_pipeline.h CC rte_pipeline.o AR librte_pipeline.a INSTALL-LIB librte_pipeline.a /home/qxu10/virtio-opt-test/dpdk/mk/rte.sdkbuild.mk:93: recipe for target '= lib' failed make[3]: *** [lib] Error 2 /home/qxu10/virtio-opt-test/dpdk/mk/rte.sdkroot.mk:124: recipe for target '= all' failed make[2]: *** [all] Error 2 /home/qxu10/virtio-opt-test/dpdk/mk/rte.sdkinstall.mk:58: recipe for target= 'x86_64-native-linuxapp-gcc_install' failed make[1]: *** [x86_64-native-linuxapp-gcc_install] Error 2 /home/qxu10/virtio-opt-test/dpdk/mk/rte.sdkroot.mk:102: recipe for target '= install' failed make: *** [install] Error 2 Thanks Qian -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon Sent: Tuesday, November 03, 2015 6:14 AM To: Marcel Apfelbaum Cc: dev@dpdk.org; Michael S. Tsirkin Subject: Re: [dpdk-dev] [PATCH] vhost-user: enable virtio 1.0 > > Make vhost-user virtio 1.0 compatible by adding it to the supported=20 > > features and keeping the header length the same as for mergeable RX=20 > > buffers. > >=20 > > Signed-off-by: Marcel Apfelbaum >=20 > Looks good to me >=20 > Acked-by: Michael S. Tsirkin Applied, thanks