From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4479042CA8; Tue, 13 Jun 2023 12:59:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D92540A8A; Tue, 13 Jun 2023 12:59:55 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 8121240698 for ; Tue, 13 Jun 2023 12:59:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686653993; x=1718189993; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=0fkL6D20unbmiszllEiBMTWQGFvf0DbbkPeZHzLv8N4=; b=HHTkHXiPGj37/XFSiSdYHuT6BaBwy36SUh3Dhap5AQhyNb8eot+/sBFZ mKOLrN0XzbEBI9ZB/pR2OpTPv+fqDCzVLrvm7tA0HCtZG6FPwUtDuFjHy +Uy4oPN9AqvYLsTMoVvDoYX6jyYraGgJUS1HJw/dlph5sgmot21q1zBzZ 3O1t6l/+N+AgbejP+RzaiYFYjZitJpuq1Zk6QEBgRMXEw9B9hkg9nxyhV cXRsuOVY/kkpkfk+dNI93AI1o6Z1jc5Zyi+F0SonhAv7rT5fY2nMUW13y JAg6L1OIgJLOX6a9BZ0sjzTUg/PgYDdj+2cjBC4/wypjU3BQD4DQipxvX Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="358297041" X-IronPort-AV: E=Sophos;i="6.00,239,1681196400"; d="scan'208";a="358297041" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2023 03:59:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="711596600" X-IronPort-AV: E=Sophos;i="6.00,239,1681196400"; d="scan'208";a="711596600" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 13 Jun 2023 03:59:36 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 13 Jun 2023 03:59:36 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 13 Jun 2023 03:59:36 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 13 Jun 2023 03:59:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ms5zKUko/4Ih/HbomzHQ17AO7YX+jDlr4atkkL8L1v2Q1Ahny0uJFIXEz8fmWI2HOxIiPfq8Y4EvojRlM/0OrBdMmRQyB4/8A0xmfTM4DsOYPzKJEd60Gt6NJjOhvTA4J6B4kqBUsxMpUJ/q8Lmf7yMOxJ3UpOaI1r08Fgd1ahlZ21AOJdZFQsqrsvFh83t1ZfGxnZUvk4UsP46h0FdOPg2LKw1yskG6jzKLEs0C4KIzHfmDDK/JDKtrQDI8ESKMTLO19im503fepmY69EqO/0hkNUF6dZ+m+ZEs1v6nKrAqt3xoCTqug79RfccRlzHVx7b4N4VPwR3+xYDI7PN1Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WIc5wJhNgAq5jLkmfvWSQqlIrLWBN5cNvh9TKVXh2AQ=; b=mJLXpenaoUvBGvvnzzMdGwYxKntbbi8jlYej8j2p7v6dXQ/F+M3H36BEmysSnfJq6GWgQxhKE/uK81u927+asNhxREvRE9ahdgpltGdtXLrP1f5ubef/TrBpGHEkEs32vCT/qkNqRArv1QwS2RyimeM4uZFkPPBC1LrGdUYdusq32HbqAu7QgIRI5t9boKrR/ZCGQBWbv3WdKo7MTlTu317j9KAG3e8z4Gnt+d1aG42/F1mKMs76mjTCwy2r/sKqV/dS9Lw+gdZ0M3Ugjxg9hjihz6xds4yQF+rLwf8JCzNzvUDvt3yUOrAjR+xZu4qpVd5QnM1He7OiiAyTxYhZLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by CYYPR11MB8386.namprd11.prod.outlook.com (2603:10b6:930:bf::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Tue, 13 Jun 2023 10:59:34 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718%7]) with mapi id 15.20.6455.030; Tue, 13 Jun 2023 10:59:34 +0000 Message-ID: <82acab7a-c649-0ff4-3389-7f10f2863713@intel.com> Date: Tue, 13 Jun 2023 11:59:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.11.1 Subject: Re: [PATCH] eal: fix prompt info when remap_segment failed Content-Language: en-US To: Fengnan Chang , References: <20230529112155.11247-1-changfengnan@bytedance.com> From: "Burakov, Anatoly" In-Reply-To: <20230529112155.11247-1-changfengnan@bytedance.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DUZPR01CA0263.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b9::11) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|CYYPR11MB8386:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d89a98b-052c-4b0e-86b2-08db6bfd45ab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VWBJNeIF0FeyDeUbskyDujU8J/p9HgIxgVAiF22mLoi2JujgJYgnOMUZ9Ia04l8a1nLhZ744lS5JrgFSiPgchIRN95WKA5oWY+f3mnexPYVm101V2R8f9Rreh09m6Ftwta1Uca+63czsWtuYBUjr18zBzNSsDRGz3ydpTNezhXEEjcxUxST3Q3aKXWw3W2Hqgw69plrtWQjaje1mNPpd9eqItsNWFZQtC29VwFZN86cUCknQ7OFV9JUVUTaYCHp+2ztD3gA4LaBGgaXUQA1VxCxVOnhLLptzXixw882NvQypvxkILD6NFF0143N+KOZfLMv23gEVGqRrwWCl5L1oIssfH/tc2cg9PgU00V89Vmn4gOYqLTyQaLVUDD+MB238VehKQ2VAoH+vBnYJSG1Yah6a1mNiNeT9MX1bdnoYv5m82uAOR9JvC7ys1Zkjb7/nvsxxCD/EAqxhgsAiVpPlMH5cR1KXxdaSOALkJ8MQOq01swXpeDVTdis0yy+mQpqaqBkwXEYIK89TStgXILsDz5K6PY9W3GpcFajQT/VkPHHQAPx568gpRq9tCZmMRSQzS5aB4ynw9MFyKMs2hf7MBIgblXhpV/RwtONGXUe3RlaeUDyVh0e2wth/NCPcYATsptqvsuTYoYVMtWtTkPin2A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(136003)(346002)(366004)(376002)(396003)(451199021)(66556008)(66476007)(66946007)(8936002)(8676002)(36756003)(5660300002)(478600001)(31686004)(6666004)(41300700001)(6486002)(316002)(38100700002)(82960400001)(186003)(53546011)(6506007)(83380400001)(26005)(6512007)(2616005)(2906002)(86362001)(31696002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUF5alc5SnhTbE5xU2ozaUJmUXBONjZEY29GUklKOTR1S081RXVFbElzZlJi?= =?utf-8?B?OXZJZExCS2pWSUF4R3hsS0lkYjc1S0VQQVRpSFNCc3VNR1ZOSzRIb25BYi9t?= =?utf-8?B?NWtZRm5VRGR2Z0txWDM0cXpkOHgwWkRDTWZUa2ZBU3lmWFlTYnkzNnpOejc5?= =?utf-8?B?ZWZZNU9xZmVLaVdwOGJ1bUhUSlo0aWw0OWJ2NDRQL09UTkY5Zm9aWUhKWmQ1?= =?utf-8?B?UmJiUytHdW5ad2YxQnRkNHJEQmJvRS94MGRTTy9TaDZiYVcwSUF2Sk5XWjRP?= =?utf-8?B?OTRTREk4aG0vNHVhUkZmME9WS0J1RkV5MzYxM1lxRVh2Vm1lbjJtb2RPV3gv?= =?utf-8?B?RC9qaVhjbFFsbXZPYm9KSzh3MjNJa3EzUjVZQ3JFUUx4OGM4bStWcHR5QmY2?= =?utf-8?B?T05LaDYwQjc3dkN0N1B6N3c2cWROS3Bpc0JqTHQ1Q1BRWWlDR0ZHSFhtMkRj?= =?utf-8?B?SHBHbFlFRU9ZL1l1ZkhMbnpHQnRod3pCNHIrSkxQUHBhaWNtTTQ1OC9xRzJL?= =?utf-8?B?YmpBMHAydDZyMWwvNkpJN0hXeW1WOXhUaEtGSk9FdmlMQlBHeS9SdGpkcXNJ?= =?utf-8?B?TUdGM2p1Y2tKM2pRNUVJamVreHJiOHdmYmhZRHFzWTdsemZWQitvSHozbWQw?= =?utf-8?B?Zm1PYlpPTEhZbVZuZHlWeGtnb21ndUl3akszOE5CeVJDL2VCMytRdVdFZWRx?= =?utf-8?B?U1pEZFNVdWY2YmxlakdNQnF6ODN2THRzbFhvQXRuRVZueHRabmc0dE5wNFAv?= =?utf-8?B?Y1JKQUhJZDROTXdBQm90M1FLcXlpZjlMWm1KNmUxNFlBR28raTg2TmxvODhR?= =?utf-8?B?c051dlVhYUlmY1E1SlZwOWVWWjM3Z1pSdVRYNFdXaklpbFdNYU10UkpiTTBW?= =?utf-8?B?d0FlaHdPSDcvTjU3WlRjendIaHQ1TVRJclh3VkxsUDNIcTd0dWNGbExKUitU?= =?utf-8?B?TXhLMDhndXRwN0NYNEdTVkFIdTFiRW1VaFNCNDN4ZUlQVFV3U2lmRnM2MUI1?= =?utf-8?B?N3ZlL1JINURmaWRrKzVJZkttanQyYzF5SVZWaTBkYmEzRitIUjI2VVdHWXZM?= =?utf-8?B?WlhYd3cxRnFCYklrWkROTWFadEdFRU4ySldyUXhHcVorelR0L3BLUy9QOS83?= =?utf-8?B?bkVtNEYrNXZjQUhNRW4xOXhjOEZyRllOQkpOaU5FQ2NGUit3bmY4VWFhYnA2?= =?utf-8?B?VU9LR1ExMzc2Vi9GK3FUWHdDYnhZYVNaTUlheUhuVVdUYWs4QUY2SmRSVFpN?= =?utf-8?B?SWxacGNyMUVvZG0wb1g1Unc1OVBtNFplU0VCZERFZjRENW11cXFpeUtmdENT?= =?utf-8?B?SWJUeUdVcGlndjJwU3RaVHc1UTZPcGxQMnRhdUFBSE10WWk5a3ZlREVEa2Nu?= =?utf-8?B?NkdSNmJwa2Z0bmZaLzlrcWZnY2plVEZDNTdXTGY4SHhpNS9zTDJ1dXdwRnZC?= =?utf-8?B?N0R2NkR6dzRRakVwTk1idzhFdk9MR29WNGk0NDVuQkdsTkZoT0MzdGY3eWZy?= =?utf-8?B?dHBJTm9kSUdDYTZzN1M5b25EM1lQN0xZY1ZxNWJ5RjJaVjArR0FaaUxXMURi?= =?utf-8?B?ZXhoamtTUDNBVEFLZTRxbWR5NE9wcldockZBbDYwaVQ0KzZmZWl5bnFjYkRv?= =?utf-8?B?bTBZRm9RWGRLYm14c2Vuc0pmaENGZHZnR29tQWgvYzZVcUpsTFE2bFF6aHNP?= =?utf-8?B?SXorUFJlc01taXBuV1R3ZHI2bkRIc2l0QmRzR2JZd1JoL1Z1ZGUwT1R6c3NN?= =?utf-8?B?SGVLNnlWZTIyTWRNdSs4WlduQ2NZQ0RsZkJlcHorbXpHcVhoODM2NHJ4Um9a?= =?utf-8?B?ZmtmOVV6MDMxb00zNGlVQUx3VWZTQ1Q4QUwrZTg0L3dQcEJQVTNaU0hPaUpX?= =?utf-8?B?OEpCSjRtTzJrY1JjWmFucFZlTEg3U1E5NndOaTR2WlNoYjFBV3VNMGVVaDNP?= =?utf-8?B?TkFmY05CZ1k1RHFlTEMwMWc0U3NPclM0a1hLTDBsSnhsMFBpejlwRnBWZ3VF?= =?utf-8?B?bEllT3d4SVpnb0xRMlFLVkJGRWVjRnh2YnMwT1EvUFVwb2VEdG9oT29RdlhB?= =?utf-8?B?a1N2Y0kyazdzVjdkSStqd3htL3Y2Q01zQXFlWjRqaTBwN0VrNDQwOG1ERm55?= =?utf-8?B?M21wb0VhZXdmdDFpTG15K0pFSjc1dkZVRnpwZzhQRllIWXJzZWp2Y2dxMUow?= =?utf-8?B?eUE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7d89a98b-052c-4b0e-86b2-08db6bfd45ab X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 10:59:34.4241 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lfPBc1vbU/XRAHhiU02JOyRGLvD2NXOYbLJDUyvpUIjGE2l3DGjnOoa14yZ6sRjXPXI2HPgmR6xhPoKCWf68wrV73SeDECAQPEAoY/AOz/s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR11MB8386 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/29/2023 12:21 PM, Fengnan Chang wrote: > when there is enough space for memseg, we should pormpt which > config to modify, not just print numbers. > > Signed-off-by: Fengnan Chang > --- > lib/eal/linux/eal_memory.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c > index 0876974631..974db901b7 100644 > --- a/lib/eal/linux/eal_memory.c > +++ b/lib/eal/linux/eal_memory.c > @@ -716,9 +716,8 @@ remap_segment(struct hugepage_file *hugepages, int seg_start, int seg_end) > break; > } > if (msl_idx == RTE_MAX_MEMSEG_LISTS) { > - RTE_LOG(ERR, EAL, "Could not find space for memseg. Please increase %s and/or %s in configuration.\n", > - RTE_STR(RTE_MAX_MEMSEG_PER_TYPE), > - RTE_STR(RTE_MAX_MEM_MB_PER_TYPE)); > + RTE_LOG(ERR, EAL, "Could not find space for memseg. Please increase RTE_MAX_MEMSEG_PER_LIST " > + "RTE_MAX_MEMSEG_PER_TYPE and/or RTE_MAX_MEM_MB_PER_TYPE in configuration.\n"); > return -1; This is a problem with RTE_STR macro - replacing this with _RTE_STR will yield expected results (write out the RTE_MAX_MEMSEG_PER_TYPE as string). I'm not sure using _RTE_STR will be the correct solution though, because it's prefixed with an underscore (implying it should not be used directly), but I'm also not sure about writing out string literals like that explicitly. -- Thanks, Anatoly