From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0041.outbound.protection.outlook.com [104.47.38.41]) by dpdk.org (Postfix) with ESMTP id 15E577D04 for ; Tue, 12 Dec 2017 13:45:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=71MSnqkGwgejuYHYkW7rkh3q0U0tnVfGpJOy4SLbOh4=; b=BP5AZQZwj4l7Kyxf27Naer51JxSFHXc4BRyIz2CZ6GGfNV7tMKyGkye72oE0Hhxv8JKLldP8RqbIIwuUOmxzEuvnynqaL2o93J2iDLn66CgjoM3gDOyKHh7sCrN59QzdQXeJFDOJG/16CQuY7CwYuIQ1AvRRIV0qCOm+5TmkTyo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Maciej.Czekaj@cavium.com; Received: from [10.0.0.58] (31.172.191.173) by CY4PR07MB2885.namprd07.prod.outlook.com (10.169.252.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Tue, 12 Dec 2017 12:45:34 +0000 To: Shahaf Shuler , Ferruh Yigit , "jingjing.wu@intel.com" Cc: "dev@dpdk.org" References: <20171123120804.143897-1-shahafs@mellanox.com> <20171123120804.143897-3-shahafs@mellanox.com> <176b53a6-e211-a7e4-c323-df8138505f3e@intel.com> <27a75726-8c0c-9fe8-d9f3-a2cb08a9f6e9@intel.com> From: Maciej Czekaj Message-ID: <82d7dce3-91a3-9965-b798-78013af70a3d@caviumnetworks.com> Date: Tue, 12 Dec 2017 13:45:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [31.172.191.173] X-ClientProxiedBy: DB6PR0202CA0005.eurprd02.prod.outlook.com (10.169.218.15) To CY4PR07MB2885.namprd07.prod.outlook.com (10.169.252.139) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 92bb6be1-d905-4db5-d7c8-08d5415e3d8c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307); SRVR:CY4PR07MB2885; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB2885; 3:baXWARpRO4LJkIcd7vynPYB6h4uPY+I7xbJVUXYYYEfA7SgxUxJ2MUoO7ULaciYCrBYGt0m5m+Dp803XwTh21tkEIGtE10JhPWVwZiP1TK1sFRJeb+fQdtrFYSrp5BBUAX1gULLnB6bPtl8BotGb05M/iqE/y0IjzfoxFg+4NAz/xAQnKxFoFhJSDk2Oa98lEHCaM5T4ePx+KA4xqkQdOmUgkgafXg0hwjlVheD5AS1U42TqOMRqwFh30Gjp606k; 25:CYVTsYvgs4FsNXl6K7J/HYyy123xcfRpcv6mgtBJ04F2GE2yM3Vy+RRsl7PRde//fV0XKOWT3KQf69cPgm1VDkTmRqR3FWE28V4Imq8Md9eJKs121aZRp211xYGRf6BaTDJoO+pUeouIBB1ktuMwxfqV1gqW282OJ9R/uGG2ttMJum+Rhk8+SDMcHWOEfrBeFPdWQ9RbrmEI7OEHkzuhbxT+HW5cBZ2Q+rvUbU9O6dE2ExHjvXGCJVTVDI0w26UkDn3jXIJH2u294yu7ixVXYVly8Z4nsXmvTe8g6ggX7U7gyqCCefUKovJU8ZnbNGeGeUh8QKf8aW3ATlqzzo6Q2UYFRr/BLNaUqDtOe83cX4w=; 31:5hfN6waDBZw/JDKqsoeFC8768VbmW/JJYrLHK0OfvBtjmUyk9Zs/kbDx/KPlHqhwPhBVlpwhI0QI2QAuuElonh00XgjF4L41AbliTnNPGxEPtRrrmt5HHDdhUIZSG8n9HyYr6FTEq9wu92fE+CiTgNqTGqxSp6Ea85mfNNtk0HETi/fpc7orEXrlEe1KZdv7d+Yq98iViIxzU2sRc72lloacGvwAIzNBoAh+MvnFgq8= X-MS-TrafficTypeDiagnostic: CY4PR07MB2885: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB2885; 20:LaSTNF2QtEL9tZyiWb9f6BpJ+p5KhuJ/HQCTpgDWj4rRE894ZrhclAhWVeAJDhuaChYQk/ePwff1ZfpOn2ryjVzn/X9kw4/JnsSMFWb7N4kowrhtDZfnwLEFSdTpOdOhibHTsQ8T95jtAq2Mlv/sxyewAgVWsakTlkHTsHu8DqLYXeiVIH0rur4P+UDyElVN8Kon8cZeop1DyPKN+xCnFb3JeqjBEPfU5H7xTxqB5rEbNMVe8IN0nUFqS+tn3seDRLVb2OftzAlcMnTIkDQTjxIdWLqlg14bLkxfEnJHSmNXQOBQiPcaWoQUcE4y7MxE0OF887abYq8lxUfEDzjFHI5ZZtIC5FeOwPcyBfBjnnZL6uTJVwtjNYdJGcFVf6gHT1PamE/0tj1exYGsXSobw+dKeUrvpDMrQoxynRnWqLZzQgOdqNMAn9jzVjEupvkp4Pfe0jHQO/RRNj4/i28MmNxRjGyRiV5xCvON8G34cpMv5oDTGtOlT/Czavq6K8JtBZKvOhqYaBM7mCeUrdOfHJbNqOXeaaQRhrsu+AWBCwh7TcEUL9rSoQVJ8zKCAb0QMJYb6MWZprTNhrZKso018YoTEw7eaq3thkTzVAX2+qA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(189930954265078)(136908898440147); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(3002001)(3231023)(6041248)(20161123564025)(20161123558100)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011); SRVR:CY4PR07MB2885; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY4PR07MB2885; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB2885; 4:fQfu+uHA5Nnk6U0XLPXB5B7USgAFC0qbq02NCJoxJa43HW45tVYS99f7Jv7/azsM3z8DbnI/JzDxXyFVG0mokQkUgO1pDRN4cUUBV/dP0FIwr8Kg8PPlei8bx0a3n290bdLrTVyGj+AV25IAPA/A2QOkd/NCJ2u2GycUtUKClvsIsy3TRaJXE5i565OesMsEBw2IFeNDlFHybeFiOsdzH+o9Srm0FKSLKEyopd9cD3Um3OOrm7PFclyWWxe+WxuyCu799mmEwjuv6+GHxiZc6812+FmeYAyYJ+Dq1NRIPF0HHympvsBXQ28dMcdL667NIapK7fsHbiytCkeWgxRFGplxrGzS+clSvLvNaTlbhoqADZvOb9NCu4Oo6dHsS4ig X-Forefront-PRVS: 051900244E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(376002)(366004)(346002)(199004)(189003)(24454002)(76176011)(5660300001)(478600001)(65826007)(316002)(2501003)(106356001)(105586002)(4326008)(64126003)(97736004)(37036004)(110136005)(3846002)(59450400001)(93886005)(6116002)(84326002)(33964004)(58126008)(16586007)(16576012)(83506002)(54896002)(16526018)(36756003)(31686004)(229853002)(53546010)(25786009)(7736002)(31696002)(65806001)(66066001)(65956001)(2950100002)(90366009)(53936002)(6486002)(77096006)(236005)(2906002)(6246003)(72206003)(68736007)(81166006)(8936002)(6666003)(42882006)(8676002)(81156014)(52116002)(129583001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB2885; H:[10.0.0.58]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB2885; 23:PM/MOU8LIckuZyMvH2Ppfq2spOZ4S5wm/TM38rmlw?= =?us-ascii?Q?edA34v5AkfNxYBrBRje2ZyuSqf8IIT73y/ziuk2GNQXojeendRLtSO2RHk5s?= =?us-ascii?Q?cDcx5RB2e4rucIgjmDc+cZToyYWL2CIJX/WtE4mIXmpfQbecXicF4NDIwmcP?= =?us-ascii?Q?Lg+KCAnOf3aOM0blP6RuYoV/S67Dx8dRdE+jx7tWPxRT1VavdLQZoyCS35jX?= =?us-ascii?Q?Vcgb7c53aNa5sSyxQ1Crqth0yg8wV/5W+YaOxJKzm1b1H2y4tplRAZxIy43X?= =?us-ascii?Q?SQE8qJaIx1cYLONAk04LqLLEctBPpMef/a+RrbdQdmSUJjAHaV5u/E9HGUIJ?= =?us-ascii?Q?u0+aP7xzUFXQQlSGVmobssEi5KbopRCuJwSP5iGUxhobdQBUKMU1K0Du2/3S?= =?us-ascii?Q?CJkkOurcPr2QzlKWqooSr2H7w3BWgDQVEmyjAmX3ZHxV11MmvG7jKX2mhrAz?= =?us-ascii?Q?oy68CtdwjHBTEighWHcKkzn6IC1RSgJe5XYj7xQ9BYtJ0u2y8Pbns7inyeYF?= =?us-ascii?Q?t+EMb+jQ3zn54NyHhKt+xvZitYOfXSbi4CPis5wxhbonS4NwURkFrLFlkkpK?= =?us-ascii?Q?WvTe+nzdQMLx9gETTEYkS9dwzfIjnspvOySUryiMnU+upkcQNMrXk3nz42rg?= =?us-ascii?Q?cW50tnnLDHKqvNWfD3XYGLlS3MddDPZgJ49jOa0/spBJr0BHJ80XfrnKMoF8?= =?us-ascii?Q?ODqbwIP3BvjYx8tUMejDo+d1oJ+3636gcT61FatAZxT0D20k40NBKTUTSMkV?= =?us-ascii?Q?1FxsDA++CBVqzTvcHyhNJFSzsSzgPTSoAGyKYaV3VtD8ZCzHtI6Liy5LSAmu?= =?us-ascii?Q?Ql2JxJxcn/L0Do/9mDrQgGWEA6zbIGGGZzn3o6NacFwx6K3g6b2bB6RzMwaJ?= =?us-ascii?Q?FcZcGlqLb+Q3A5i7SHlVywfoS3uTfbpiUrzUP+VUkjUy84Dl3/nwsjxymB0q?= =?us-ascii?Q?0/JF52YQEjP0F2FqlL3oZ+L5JncrrJBSYOyCJGG1q7BXmPqpsqIuZxQAxlUv?= =?us-ascii?Q?xUxsE9EuR/3sBxIwD275F2xtJCeQYfoeYCw+R46avXT0U8pJ0oNSllGCviJi?= =?us-ascii?Q?1HQs2T5zZKqlcqGXBQzapkiLIic0ngmN5J6XDNQLiHLNn+c+OOoP3PUW9Yqo?= =?us-ascii?Q?DqZVOBriznjSyEmCnB01OGxiFP4PA2hp4m17o4IIAQ81IMT0MsjxOcmgnlRz?= =?us-ascii?Q?NcSJDdZ+Tewtw2q7YqyDZKwhv3fJpbJyUZNT2t/fPnyD6UpXQOOAVrl2BZcv?= =?us-ascii?Q?nHk+Z9Xl1RKECeLRzHBGM2VuQhxkVe5DQ2ea1RashMsDQVGLCfWW2Ohs59WB?= =?us-ascii?Q?9LInJROz6eCbaj4I1du4tZidaTD26GOYFZm1pxkBVwxRUXnv7c1MtL59WKp8?= =?us-ascii?Q?siv6Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB2885; 6:DXtVtyMKHTn64Oamk4Kq4HITRm1pbz3zMbVWnIC//FY3071Q1SakX/9Hz617rrMCCHqlWLczj/WpCtcNu/ixK/M3uSLuDRvDG0cAEHz+bFUceLs4F/BGk3Dpw10IXFrevJ9POcXKinW5dXVGjjxU0N6EnLTNlXOu3GNasFOya9yNlNjd68WAODAwmn6nRY/xfgOqv7yU8Rph54bifeX33ZJan0OKQs6FWVk2/pwP9VFciP6CLx1MXTD258R0zxWk01U+4mxc/7sOdZDOU0HtBqwXYTQalxaKS/Yvg5skKubVf4axaa/vq9pzg0eTbXCHMR6cbXI2KNkqYtIjRjBfu/zTpOlbT61SWE+v+bfVCF4=; 5:kH89qqqBs9vOxqcHcCoIBRKkE5/CQK75oHm+2UTQeNGm6dHJVVGzwYOzNtYrA7yqN6q5Pc/KGLpUlOFLPgRpQ23MSCMMQDSJPsbTwlQxxstNgCvE3CC0rdp7CBgUEJb6xd1sgE+6piY5jqpLW313alsRetYHDuTweSHF4Z8zftE=; 24:xgXy60KjIe+oaX1CzeklKkrkkhL+PbQ19mCCvBaQK4gJW9DPYA4vGZW9B1qckBVa4LFl9ogHxOEThQbDiQuLDh2uXpp5x4BhirxFtZsEV4Q=; 7:GdMxrz6poQitgvOnQ9hG6fsRQgRhE6RUigsu4fZGGKMqkp6blojOD1oAorKQDuzi0wZaplWCOD2mUygyxo7bWQiShI9s1v5wKlNaocqSABaFPzrHrafL09VV8Uq9wlJ8sbOhI2CZyxJFXoeOF+pppSnln8KXpNsTVpawjMwxmIZZQU+7Ja0NDIx8/tupFwtg5juVua350bpIzfKT2V4rB7X3JtajKGKTcqbFeqjqBe+wheMrJ/lmqkHjNtiJKYYn SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2017 12:45:34.8164 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 92bb6be1-d905-4db5-d7c8-08d5415e3d8c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB2885 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/5] app/testpmd: remove txqflags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 12:45:37 -0000 -- Oryginal message -- > Thursday, December 7, 2017 1:05 AM, Ferruh Yigit: >> On 12/4/2017 10:48 PM, Shahaf Shuler wrote: >>> Tuesday, December 5, 2017 12:31 AM, Ferruh Yigit: >>>> On 11/23/2017 4:08 AM, Shahaf Shuler wrote: >>>>> Since testpmd is now using the new Ethdev offloads API there is no >>>>> need for the txqflags configuration. >>>> txqflag command-line option (--txqflags=0xXXXXXXXX) and command >> (port >>>> config all txqflags value) are way to dynamically provide Tx offload >>>> configuration to testpmd. >>>> >>>> Why you are removing them without providing equivalent feature with >>>> new offload APIs? >>> There is one, and this is why the new offloads API simplifies applications >> life. >>> The txq_flags were introduced so application can disable some of the Tx >> offloads from the time the Tx offloads were set by default. >>> Now the Tx offloads are all disabled by default. And there is an option to >> set each one of the using DEV_TX_OFFLOAD_* flags. >>> Look on the Rx side (there the Rx offloads were disabled by default in the >> old API). there is no rxq_flags. >> >> I mean providing a testpmd command and command-line option. >> Or am I missing it, after this update is there a way to update enabled Tx >> offloads in testpmd via command and command-line? > There is a way to update via CLI > For example when doing "tso set " the DEV_TX_OFFLOAD_TSO will be set > When doing tx_vlan add the DEV_TX_OFFLOAD_VLAN_INSERT will be set > Same for every Tx offloads besides DEV_TX_OFFLOAD_MULTI_SEGS and DEV_TX_OFFLOAD_MBUF_FAST_FREE which I added on separate patches. > > But to make it precise you didn’t had before (with the txq_flags) a way to disable TSO from the command line (the is no TXQ flag for that) nor the tunnel TSO. > >>>> Patch 3/4 & 4/5 adds new command-line options to enable some of >>>> recently introduced Tx offloads in testpmd, why not add a generic way >>>> to update all Tx offloads instead of those two specific offloads? >>> Because those 2 new offloads were missing a way to set in testpmd. >>> The rest of the offloads can be set using the CLI commands exists today. >>> >>> Am not sure we want every Tx offloads to be set from both CLI and >> command line arguments. >>> It wasn't before (for example there was no --disable-tso flags). >> I was thinking a generic command-line instead of introducing one for all, >> overall single variable represents all offload values, why not set it at once, as >> --txqflags you are removing in this patch. > We can do it. yes. +1 for Ferruh. --txqflags argument was very handy in testing features in batch mode. Let us have something equivalent. > >>>> Also this patch removing ability to display current Tx offload >> configuration.... >>> Can you point where ? >> I mean following: >> >> - printf(" TX RS bit threshold=%d - TXQ flags=0x%"PRIx32"\n", >> - tx_conf->tx_rs_thresh, tx_conf->txq_flags); >> + printf(" TX RS bit threshold=%d\n", tx_conf->tx_rs_thresh); >> >> Why not an offloads replacement of this one? > Will be added. > >>>>> Signed-off-by: Shahaf Shuler >>>>> Acked-by: Nelio Laranjeiro >>>> <...>