Re: [PATCH v9 0/9] net/zxdh: introduce net zxdh driver

[Thomas Monjalon <thomas@monjalon.net>]

04/11/2024 12:46, Junlong Wang:
> > >>>   net/zxdh: add zxdh get device backend infos
> > >>>   net/zxdh: add configure zxdh intr implementation
> > >>>   net/zxdh: add zxdh dev infos get ops
> > >>>   net/zxdh: add zxdh dev configure ops
> > >>>
> > >
> > >> Hi Junlong,
> > >
> > >> I can see not all of the eth_dev_ops implemented, and datapath not
> > >> implemented, so driver is not functional right now.
> > >
> > >> What happens if you want to run testpmd with the current state of the
> > >> driver, I assume it crashes?
> > >
> > >> And what is the plan for the driver? Are you planning to upstream
> > >> remaining support in this release or in future releases?
> > >
> > >> As the driver is not functional yet, to set the expectation right for
> > >> the users, I suggest marking driver as experimental in the maintainers
> > >> file and document the restrictions in the driver documentation, also
> > >> clarify this in the release notes update, what do you think?
> > >
> > > Hi Ferruh,
> > >       The complete driver function has been implemented. At present, the driver function is integrated in batches.
> > >       The integrated PMD does not cause the crash but cannot support all PMD functions.We plan to integrate the driver in this version and finally provide a complete and available driver.
> > >       In the current phase, we will marking driver as experimental in the maintainers file and document the restrictions in the driver documentation, also clarify this in the release notes update.
> > >       Thanks.
> >
> > Sounds good, thanks.
> >
> >
> > Btw, build should be fine after each patch, but in this patch series
> > there are warnings in some early patches, can you please fix them in
> > next version?
> >
> > @Aaron, @David, what do you think to add patch by patch build to the CI?
> > I hit the same issue in multiple series in this release.
> 
> Sure. But I cannot see these Warnings in the [v9] net/zxdh CI/check Description.
> What do I need to do to see these Warnings？

You need to test compilation after each patch locally.
You can use "git rebase -i --exec ninja" for instance.