From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B358B45C7F; Mon, 4 Nov 2024 23:47:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F38C40281; Mon, 4 Nov 2024 23:47:07 +0100 (CET) Received: from fout-b5-smtp.messagingengine.com (fout-b5-smtp.messagingengine.com [202.12.124.148]) by mails.dpdk.org (Postfix) with ESMTP id 5D4644025F for ; Mon, 4 Nov 2024 23:47:06 +0100 (CET) Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailfout.stl.internal (Postfix) with ESMTP id 4B64D114017C; Mon, 4 Nov 2024 17:47:05 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-08.internal (MEProxy); Mon, 04 Nov 2024 17:47:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1730760425; x=1730846825; bh=If/49UI5RJAXxkhdaX4J5AbyHpWTY9g3HORbqVd2pbE=; b= n6Zo3op5AfxSdATvWGzaJMY5HwFcFbRvSvgy0YVKZDWEJ40xFPkSMg37H+bq9W7p JdAmM/bJfi98EFSS/7cfQQnsp7FIxK6tVoMgJjB/GpDExFg1y1SLIAlEso7wXoIi KZHZPuZ4bp+GxtilSpYYtfWcV0pr0OnfF4/8JphEMD2e5kwXtTVanbkKG3ddjk4u ULTcINVCJO8aGSGpAAUJgynHkNOEApkPq7LMH3urOJ2iDiunuC9gKj6TWb4ov62+ C6x8eorExYEaFaXDQKZOvB6Ib8Z0GylYieqMBXV7LXymtHh7Lj+gbJlQQuL3/jTa sRSAZqPZxtmdtSQl5t9IyA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1730760425; x= 1730846825; bh=If/49UI5RJAXxkhdaX4J5AbyHpWTY9g3HORbqVd2pbE=; b=L UzDrTVRXVwZ1N2T9sXdJaq3+V3OUTJrA4UR2BweZDDk8i6RjGHsAJDrJYn5e18+e kcz3w1i5ilmj3Snu5fH7iM17tWdgq0mdlUJLc8dqnw1O8lmyR+6fNEozx490OJSq pYW3sL1dzP3AIHNDwACP99eVMQLFTfug1knJnZHdn5dRSmDk+hqCXKACBAdK9Y7d vRI3WygJAId+aBMLvc3mtdm58vhEpfQKPannF736yqK4VWEv6tlEXqXzz7SNBf3s t0UVpnLH9QcInzDg5byz29p4zBu3sCO6+cgPEuMeouf/1iyWndrmsJD2KEwXC60W ifvu8wuGgy6c+swSO2huw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeljedgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedt heevtdekiedvueeuvdeiuddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopeeipdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehfvghrrh huhhdrhihighhithesrghmugdrtghomhdprhgtphhtthhopegrtghonhholhgvsehrvggu hhgrthdrtghomhdprhgtphhtthhopeifrghnghdrjhhunhhlohhnghduseiithgvrdgtoh hmrdgtnhdprhgtphhtthhopeguvghvseguphgukhdrohhrghdprhgtphhtthhopeguphgu khhlrggssehiohhlrdhunhhhrdgvughupdhrtghpthhtohepshhtvghphhgvnhesnhgvth ifohhrkhhplhhumhgsvghrrdhorhhg X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 4 Nov 2024 17:47:03 -0500 (EST) From: Thomas Monjalon To: ferruh.yigit@amd.com, aconole@redhat.com, Junlong Wang Cc: dev@dpdk.org, dpdklab@iol.unh.edu, stephen@networkplumber.org Subject: Re: [PATCH v9 0/9] net/zxdh: introduce net zxdh driver Date: Mon, 04 Nov 2024 23:47:02 +0100 Message-ID: <8310791.tOnEmuZJvr@thomas> In-Reply-To: <20241104114644.2794116-1-wang.junlong1@zte.com.cn> References: <20241101062156.2637339-1-wang.junlong1@zte.com.cn> <20241104114644.2794116-1-wang.junlong1@zte.com.cn> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 04/11/2024 12:46, Junlong Wang: > > >>> net/zxdh: add zxdh get device backend infos > > >>> net/zxdh: add configure zxdh intr implementation > > >>> net/zxdh: add zxdh dev infos get ops > > >>> net/zxdh: add zxdh dev configure ops > > >>> > > > > > >> Hi Junlong, > > > > > >> I can see not all of the eth_dev_ops implemented, and datapath not > > >> implemented, so driver is not functional right now. > > > > > >> What happens if you want to run testpmd with the current state of the > > >> driver, I assume it crashes? > > > > > >> And what is the plan for the driver? Are you planning to upstream > > >> remaining support in this release or in future releases? > > > > > >> As the driver is not functional yet, to set the expectation right for > > >> the users, I suggest marking driver as experimental in the maintaine= rs > > >> file and document the restrictions in the driver documentation, also > > >> clarify this in the release notes update, what do you think? > > > > > > Hi Ferruh, > > > The complete driver function has been implemented. At present, = the driver function is integrated in batches. > > > The integrated PMD does not cause the crash but cannot support = all PMD functions.We plan to integrate the driver in this version and final= ly provide a complete and available driver. > > > In the current phase, we will marking driver as experimental in= the maintainers file and document the restrictions in the driver documenta= tion, also clarify this in the release notes update. > > > Thanks. > > > > Sounds good, thanks. > > > > > > Btw, build should be fine after each patch, but in this patch series > > there are warnings in some early patches, can you please fix them in > > next version? > > > > @Aaron, @David, what do you think to add patch by patch build to the CI? > > I hit the same issue in multiple series in this release. >=20 > Sure. But I cannot see these Warnings in the [v9] net/zxdh CI/check Descr= iption. > What do I need to do to see these Warnings=EF=BC=9F You need to test compilation after each patch locally. You can use "git rebase -i --exec ninja" for instance.