From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 87A271BB76 for ; Thu, 10 May 2018 17:45:13 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E833B211C9; Thu, 10 May 2018 11:45:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 10 May 2018 11:45:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=1ZQu7rFwxaIfFWEI6Hc3D4qrnL oVwbAUEujv7dWh0qk=; b=ERObmoXpBvHtsw+zap/TUgTRrd+IdvexO0RE5U9j7r NLamhRn+fmCN4Mg2vlnOYNjKMVZBIg/a7mojJ8njdhZH2fluHbS5tJcViFJN52Y7 Y1jvmnNx+XpWjMsMbAoDp+TXYAvDnmU1MxMGskHT1XJp/2OyYa5LoSam5FqVeRXz 0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=1ZQu7r FwxaIfFWEI6Hc3D4qrnLoVwbAUEujv7dWh0qk=; b=I1q9Od1QigPi1iwn/+iGUb zYHZ8K0LlpSW36qxWC0WbsUlC9XerK27GuIcsiD/2bNIumw0p40+DD0XpeZkgu+G 6zr/9fpAe4LH/ZYC59EKOMtWSnZsH5lEINl10Y5jDXEDacINB+6IQtOeZw5Z+IZK qe5KdoWJU5kaS+qra1rU0IhMni/CxHRpg37MxCC5sQvmw86VvYGws7PBs+YMh8K/ +1CgTYRXfpQve7bYH6qFnrS/Ipu07DriwEctBgcuksZ/g320tIccjWZ32sVvfBmu 1e7hxlAdcIWm/0Elj6rojZyUnHxfSmfoHrRw0Un7cPCAcyxe8uCO+jIsa7jx6sZA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 185F2E47A0; Thu, 10 May 2018 11:45:11 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: Nikhil Rao , ferruh.yigit@intel.com, lei.a.yao@intel.com, dev@dpdk.org Date: Thu, 10 May 2018 17:45:10 +0200 Message-ID: <8310826.PepUDZemRM@xps> In-Reply-To: <20180510151642.GA25202@jerin> References: <1525893452-155596-1-git-send-email-nikhil.rao@intel.com> <1779610.xE5Tc50yFF@xps> <20180510151642.GA25202@jerin> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eventdev: make ethernet port identifiers 16 bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 15:45:13 -0000 10/05/2018 17:16, Jerin Jacob: > From: Thomas Monjalon > > 10/05/2018 16:30, Jerin Jacob: > > > From: Thomas Monjalon > > > > 10/05/2018 06:31, Jerin Jacob: > > > > > > Date: Thu, 10 May 2018 02:22:40 +0530 > > > > > > From: Nikhil Rao > > > > > > > > > > > > Ethernet port ID data size has been extended to 16 bits size 17.11 > > > > > > Update the Rx event adapter interface and implementation accordingly. > > > > > > > > > > > > Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation") > > > > > > Signed-off-by: Nikhil Rao > > > > > > Cc: stable@dpdk.org > > > > > > > > > > Since it is an ABI change, please bump the library version. > > > > > eth_rx_adapter still under experimental tag, IMO, no deprecation notice is > > > > > required. > > > > > > > > The ABI changes must be described in the release notes too. > > > > > > > > There is no deprecation notice for this ABI change. > > > > According the the policy, you must send a notice in 18.05, > > > > and do the change in 18.08. > > > > > > Even for the APIs with experimental tag? > > > > No, experimental can change without prior notice. > > > > > If so, I don't see any > > > difference between experimental vs non experimental API? > > > > Rx adapter is not experimental as far as I know. > > It is experimental. Please see the links. > > http://dpdk.org/browse/dpdk/tree/MAINTAINERS#n351 > http://dpdk.org/browse/dpdk/tree/lib/librte_eventdev/rte_event_eth_rx_adapter.h#n276 Yes, you're right. I've looked at the map file, where the symbols are not in EXPERIMENTAL block. > If you agree then take dropped patch. I'll take it.