Re: [dpdk-dev] [PATCH] app/testpmd: update start log to be less verbose

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 4/26/2018 1:16 AM, Zhang, Qi Z wrote:
> 
> 
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Wednesday, April 25, 2018 10:15 PM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
>> <jingjing.wu@intel.com>
>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>
>> Subject: [PATCH] app/testpmd: update start log to be less verbose
>>
>> A per port per queue log is too verbose with multiple port/queue log is
>> longer than full screen, make it less verbose:
>> - Reduced log to only first queue of the port, as a sample
>> - Merged a few lines
>> - Indent queue logs for readability
>>
>> The log becomes as following after update:
>>
>> testpmd> start tx_first
>> io packet forwarding - ports=2 - cores=1 - streams=8 - NUMA support enabled,
>> MP over anonymous pages disabled Logical Core 1 (socket 0) forwards
>> packets on 8 streams:
>>   RX P=0/Q=0 (socket 0) -> TX P=1/Q=0 (socket 0) peer=02:00:00:00:00:01
>>   RX P=0/Q=1 (socket 0) -> TX P=1/Q=1 (socket 0) peer=02:00:00:00:00:01
>>   RX P=0/Q=2 (socket 0) -> TX P=1/Q=2 (socket 0) peer=02:00:00:00:00:01
>>   RX P=0/Q=3 (socket 0) -> TX P=1/Q=3 (socket 0) peer=02:00:00:00:00:01
>>   RX P=1/Q=0 (socket 0) -> TX P=0/Q=0 (socket 0) peer=02:00:00:00:00:00
>>   RX P=1/Q=1 (socket 0) -> TX P=0/Q=1 (socket 0) peer=02:00:00:00:00:00
>>   RX P=1/Q=2 (socket 0) -> TX P=0/Q=2 (socket 0) peer=02:00:00:00:00:00
>>   RX P=1/Q=3 (socket 0) -> TX P=0/Q=3 (socket 0) peer=02:00:00:00:00:00
>>
>>   io packet forwarding packets/burst=32
>>   nb forwarding cores=1 - nb forwarding ports=2
>>   port 0: RX queue number: 4 Tx queue number: 4
>>   Rx offloads=0x1000 Tx offloads=0x0
>>   RX queue: 0
>>     RX desc=0 - RX free threshold=32
>>     RX threshold registers: pthresh=8 hthresh=8  wthresh=0
>>     RX Offloads=0x1000
>>   TX queue: 0
>>     TX desc=0 - TX free threshold=32
>>     TX threshold registers: pthresh=32 hthresh=0  wthresh=0
>>     TX RS bit threshold=32
>>     TX offloads=0x0
>>   port 1: RX queue number: 4 Tx queue number: 4
>>   Rx offloads=0x1000 Tx offloads=0x0
>>   RX queue: 0
>>     RX desc=0 - RX free threshold=32
>>     RX threshold registers: pthresh=8 hthresh=8  wthresh=0
>>     RX Offloads=0x1000
>>   TX queue: 0
>>     TX desc=0 - TX free threshold=32
>>     TX threshold registers: pthresh=32 hthresh=0  wthresh=0
>>     TX RS bit threshold=32
>>     TX offloads=0x0
>>
>> Fixes: 266f28b91e34 ("app/testpmd: enable per queue configure")
>> Cc: qi.z.zhang@intel.com
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>>
>> Hi Qi,
>>
>> If you are agree with the patch I can squash into original patch.
> 
> OK

Thanks, I will squash this one.

> 
>>
>> btw, desc numbers are zero, "TX desc=0","RX desc=0", is this correct?
> 
> Yes, since the default value of nb_rxd and nb_txd is 0 which mean let device take its default value.
> The patch keep rxtx_config_display just print the configure parameters but not real device configure as before.
> But maybe "TX desc=default" is better for readable?

Instead of "default" what about to display actual value, I assume user will be
interested more with it actual value.

> 
> Regards
> Qi
>