From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Wei Hu (Xavier)" <xavier_huwei@163.com>, dev@dpdk.org
Cc: xavier.huwei@huawei.com
Subject: Re: [dpdk-dev] [PATCH v3 1/6] app/testpmd: fix missing verification of port id
Date: Tue, 22 Sep 2020 15:49:36 +0100 [thread overview]
Message-ID: <831d7d94-ce37-9ce4-16d1-e2de6f1162c3@intel.com> (raw)
In-Reply-To: <20200919104708.58451-2-xavier_huwei@163.com>
On 9/19/2020 11:47 AM, Wei Hu (Xavier) wrote:
> From: Chengchang Tang <tangchengchang@huawei.com>
>
> To set Tx vlan offloads, it is required to stop port firstly. But before
> checking whether the port is stopped, the port id entered by the user
> is not checked for validity. When the port id is illegal, it would lead
> to a segmentation fault since it attempts to access a member of
> non-existent port.
>
> This patch adds verification of port id in tx vlan offloads and remove
> duplicated check.
>
> Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
next prev parent reply other threads:[~2020-09-22 14:49 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 12:02 [dpdk-dev] [PATCH 0/4] minor fixes for testpmd Wei Hu (Xavier)
2020-08-18 12:02 ` [dpdk-dev] [PATCH 1/4] app/testpmd: fix missing verification of port id Wei Hu (Xavier)
2020-08-18 12:02 ` [dpdk-dev] [PATCH 2/4] app/testpmd: fix VLAN offload configuration when config fail Wei Hu (Xavier)
2020-08-18 12:02 ` [dpdk-dev] [PATCH 3/4] app/testpmd: fix packet header in txonly mode Wei Hu (Xavier)
2020-08-18 12:02 ` [dpdk-dev] [PATCH 4/4] app/testpmd: fix displaying Rx Tx queues information Wei Hu (Xavier)
2020-08-20 1:42 ` [dpdk-dev] [PATCH v2 0/4] minor fixes for testpmd Wei Hu (Xavier)
2020-08-20 1:42 ` [dpdk-dev] [PATCH v2 1/4] app/testpmd: fix missing verification of port id Wei Hu (Xavier)
2020-09-14 16:13 ` Ferruh Yigit
2020-08-20 1:42 ` [dpdk-dev] [PATCH v2 2/4] app/testpmd: fix VLAN offload configuration when config fail Wei Hu (Xavier)
2020-09-14 16:13 ` Ferruh Yigit
2020-08-20 1:42 ` [dpdk-dev] [PATCH v2 3/4] app/testpmd: fix packet header in txonly mode Wei Hu (Xavier)
2020-09-14 16:23 ` Ferruh Yigit
2020-09-17 7:10 ` Chengchang Tang
2020-09-17 11:16 ` Ferruh Yigit
2020-09-17 11:48 ` Chengchang Tang
2020-08-20 1:42 ` [dpdk-dev] [PATCH v2 4/4] app/testpmd: fix displaying Rx Tx queues information Wei Hu (Xavier)
2020-09-14 16:31 ` Ferruh Yigit
2020-09-16 9:23 ` Wei Hu (Xavier)
2020-09-16 15:58 ` Ferruh Yigit
2020-09-03 3:19 ` [dpdk-dev] [PATCH v2 0/4] minor fixes for testpmd Wei Hu (Xavier)
2020-09-19 10:47 ` [dpdk-dev] [PATCH v3 0/6] " Wei Hu (Xavier)
2020-09-19 10:47 ` [dpdk-dev] [PATCH v3 1/6] app/testpmd: fix missing verification of port id Wei Hu (Xavier)
2020-09-22 14:49 ` Ferruh Yigit [this message]
2020-09-19 10:47 ` [dpdk-dev] [PATCH v3 2/6] app/testpmd: fix VLAN offload configuration when config fail Wei Hu (Xavier)
2020-09-19 10:47 ` [dpdk-dev] [PATCH v3 3/6] app/testpmd: remove restriction on txpkts set Wei Hu (Xavier)
2020-09-22 14:51 ` Ferruh Yigit
2020-09-23 3:14 ` Wei Hu (Xavier)
2020-09-23 11:57 ` Wei Hu (Xavier)
2020-09-23 16:59 ` Ferruh Yigit
2020-09-24 6:08 ` Chengchang Tang
2020-09-24 12:19 ` Ferruh Yigit
2020-09-19 10:47 ` [dpdk-dev] [PATCH v3 4/6] app/testpmd: fix packet header in txonly mode Wei Hu (Xavier)
2020-09-19 10:47 ` [dpdk-dev] [PATCH v3 5/6] app/testpmd: fix valid desc id check Wei Hu (Xavier)
2020-09-22 14:53 ` Ferruh Yigit
2020-09-19 10:47 ` [dpdk-dev] [PATCH v3 6/6] app/testpmd: fix displaying Rx Tx queues information Wei Hu (Xavier)
2020-09-25 12:47 ` [dpdk-dev] [PATCH v4 0/6] minor fixes for testpmd Wei Hu (Xavier)
2020-09-25 12:47 ` [dpdk-dev] [PATCH v4 1/6] app/testpmd: fix missing verification of port id Wei Hu (Xavier)
2020-09-25 12:47 ` [dpdk-dev] [PATCH v4 2/6] app/testpmd: fix VLAN offload configuration when config fail Wei Hu (Xavier)
2020-09-25 12:47 ` [dpdk-dev] [PATCH v4 3/6] app/testpmd: remove restriction on txpkts set Wei Hu (Xavier)
2020-11-23 11:50 ` Slava Ovsiienko
2020-11-24 10:27 ` Thomas Monjalon
2020-11-24 12:23 ` Ferruh Yigit
2020-11-24 13:01 ` Kevin Traynor
2020-11-25 14:06 ` Ferruh Yigit
2020-11-26 7:24 ` Slava Ovsiienko
2020-11-26 12:38 ` Ferruh Yigit
2020-11-27 13:05 ` Slava Ovsiienko
2020-12-02 12:07 ` Ferruh Yigit
2020-12-03 9:45 ` Slava Ovsiienko
2020-12-03 10:18 ` Ferruh Yigit
2020-12-11 15:07 ` [dpdk-dev] [PATCH] app/testpmd: fix segment number check Viacheslav Ovsiienko
2020-12-11 16:00 ` Andrew Boyer
2020-12-11 16:14 ` Slava Ovsiienko
2020-12-16 12:12 ` Ferruh Yigit
2020-12-16 12:33 ` Slava Ovsiienko
2020-12-16 12:36 ` Ferruh Yigit
2021-04-23 16:09 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2021-04-26 11:23 ` Li, Xiaoyun
2021-04-27 11:42 ` Ferruh Yigit
2020-09-25 12:47 ` [dpdk-dev] [PATCH v4 4/6] app/testpmd: fix packet header in txonly mode Wei Hu (Xavier)
2020-09-29 15:40 ` Ferruh Yigit
2020-09-25 12:47 ` [dpdk-dev] [PATCH v4 5/6] app/testpmd: fix valid desc id check Wei Hu (Xavier)
2020-09-25 12:47 ` [dpdk-dev] [PATCH v4 6/6] app/testpmd: fix displaying Rx Tx queues information Wei Hu (Xavier)
2020-09-29 15:40 ` [dpdk-dev] [PATCH v4 0/6] minor fixes for testpmd Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831d7d94-ce37-9ce4-16d1-e2de6f1162c3@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=xavier.huwei@huawei.com \
--cc=xavier_huwei@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).