From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 420E22C54
 for <dev@dpdk.org>; Wed, 12 Jul 2017 00:21:26 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id E4A60209CD;
 Tue, 11 Jul 2017 18:21:25 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Tue, 11 Jul 2017 18:21:25 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=QJxPiMPP5dAxEsB
 iCxfJa5mFJAJH2Cqgj+ur3omOieQ=; b=bh2DQhnz3Mmq/xDAdF6z+veeUnx7zNW
 3LVzMEsE6ca3hq6n/dHvl5NhYenysfjs3VmIXGCQH9+ACrc2pCJ0+bm3aDNkw2uT
 P7xq4oZdE6waxeercmAW+X1lC+uqFjaz7yitFFjP4hbxIhK7qYOf6QmVl44XD80z
 f2T6TVIts5Ho=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=QJxPiMPP5dAxEsBiCxfJa5mFJAJH2Cqgj+ur3omOieQ=; b=XmT8tE9A
 N9DBplfSWzxb/+ddFNoPDlggDJ1XRBLq/2az6yAf5Z68WEFm0wpfsJYbsOnNart1
 qTm/PqAc2azeDlbrs+6NQtWvDZiiHZTNztFxd5gXmTbk/U2euLBTmLAaJbvAeVpZ
 FXt33fQtI//pJB0PNSpTHVGkioKv3Xd6YbNuKPogHxljrK4agiyy9/wCemCc8v/3
 sSUEPycHFx56gu9IYUV2SAMjdbS0PB8jaRXSAB+LCDKu7nq+CwHXE2mRLeWDP9Rb
 yW1eaL9MWqD5EmVOcDEs3yC6CL26kgajlbBi9ewWYSYVyE8bq9f5zh7zynLCtNdU
 cG6HMOe45l9g0w==
X-ME-Sender: <xms:ZU9lWeWmPaOpjAVEwBX7s22bPn63MfJcKB9bklt8BAKVgWSMKw_-sg>
X-Sasl-enc: 25YhU9wtuq6VPwO+Oa6zTh4fVUj2Ts9u2r/3LFW/fX/t 1499811685
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 99CD07E83B;
 Tue, 11 Jul 2017 18:21:25 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org
Date: Wed, 12 Jul 2017 00:21:24 +0200
Message-ID: <83323603.jg1xmzcquq@xps>
In-Reply-To: <20170711214819.GZ11154@bidouze.vm.6wind.com>
References: <cover.1499564333.git.gaetan.rivet@6wind.com>
 <6696281.voRgjYsRM1@xps> <20170711214819.GZ11154@bidouze.vm.6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Subject: Re: [dpdk-dev] [PATCH v8 03/11] net/failsafe: add fail-safe PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Jul 2017 22:21:26 -0000

11/07/2017 23:48, Ga=EBtan Rivet:
> On Tue, Jul 11, 2017 at 09:57:51PM +0200, Thomas Monjalon wrote:
> > 11/07/2017 01:19, Gaetan Rivet:
> > > --- /dev/null
> > > +++ b/drivers/net/failsafe/failsafe_args.c
> > [...]
> > > +#include <errno.h>
> >=20
> > Do you really need errno in this file?
>=20
> It's used for error handling on strtoull and popen.
> Why, is it a problem to include errno.h?

I don't see errno used in this patch.
I think it is used in next patches.