From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C59943996; Mon, 5 Feb 2024 15:03:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1BCD402A2; Mon, 5 Feb 2024 15:03:11 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 17B1C402A1 for ; Mon, 5 Feb 2024 15:03:11 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 79F015C0056; Mon, 5 Feb 2024 09:03:08 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 05 Feb 2024 09:03:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1707141788; x=1707228188; bh=nnYh9cpOuuxKDuWPR9TDyohrRrpCLyxLcpb38DSA5m0=; b= srVxn2bR92WmcMxXeEUMLnnTlfOflEWh9Ai7Uyc9Fw90VC8w9r1hbik6EMrpHf7I uP3SlMajhQ0US1fycY+cfoWz3ot6UTLQan1opWMMJN1/FiMZsZzjob+zOtpw60TK OHlPcfLQDJQDaALnbI1sHLilF9j4ZR9bfXZyd9MXbBwcF0qGoblbJVp9Yqdd6wJ+ XuJuGBtvfAfqcRcr+SQzrSpwMEdhNrG0WxU0TxuXHXj+xViWJGRYhKO2/nxpl1u5 zS1HtBqDC4grUaLl3IGY2kpNIlmxN80VZzn7nlDE8+JfWiA44abhKwzoR7zsrlwx CiLu75yLxgdH23y2+B7RNA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707141788; x= 1707228188; bh=nnYh9cpOuuxKDuWPR9TDyohrRrpCLyxLcpb38DSA5m0=; b=s mnb+QXsACqIeiGvKVVFoQQsM/7Sdg4NJmL81qHb7JppSdtNLX26f8jtqspSTr6Z8 0DyY88EjWRfea3yWbNA6OuuW+NCuekZQiy6IQYnupY5nLBKzOvWGB3aetKDG6FjB jlp8WSZKZoX7TlfLy2K+YCc1SkFoAZjH8Ho6DGwcDTpe8pWwuudQgfSEFyTNY6lK n55AyMKzI43ti4rPgpNdI/UgWOUf/AsgBA/lXW2vPrL+LHXVxeYk86EpIDt30SEW dXY7DCBbf2ZAjDwVh1veFbbVG+6PYfJzjZcl8yBFqERKCrn4vibLmBuTtOWLHJ24 Hn78gvzXL+o0/3jXYUYUw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrfedvtddgiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Feb 2024 09:03:05 -0500 (EST) From: Thomas Monjalon To: Dariusz Sosnowski Cc: Slava Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad , Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" Subject: Re: [PATCH v2] ethdev: fast path async flow API Date: Mon, 05 Feb 2024 15:03:02 +0100 Message-ID: <8370937.NyiUUSuA9g@thomas> In-Reply-To: References: <20240130181751.1425388-1-dsosnowski@nvidia.com> <2171757.irdbgypaU6@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 05/02/2024 14:14, Dariusz Sosnowski: > From: Thomas Monjalon > > 31/01/2024 10:35, Dariusz Sosnowski: > > > As a result, no checks for availability of the implementation are > > > needed at library level in data path. > > > Any library-level validation checks in async flow API are compiled if > > > and only if RTE_FLOW_DEBUG macro is defined. > > > > How are we supposed to enable RTE_FLOW_DEBUG? > > I should document it, but the idea was that it must be explicitly enabled during build, > by adding -c_args=-DRTE_FLOW_DEBUG to meson options. > > Do you think doc/guides/nics/build_and_test.rst is a good place to document this option? Yes > It would be documented alongside RTE_ETHDEV_DEBUG_RX and RTE_ETHDEV_DEBUG_TX. > > > May it be enabled automatically if other debug option is globally enabled? > > Do you mean that if buildtype is defined as debug, then RTE_FLOW_DEBUG is defined automatically? Yes > I think that's a good idea. Another way of enabling it is to check #if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG