DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 1/2] net/mlx4: fix mem leak when a device configured repeatedly
@ 2021-05-12 13:18 wangyunjian
  2021-05-12 14:04 ` Slava Ovsiienko
  0 siblings, 1 reply; 3+ messages in thread
From: wangyunjian @ 2021-05-12 13:18 UTC (permalink / raw)
  To: dev; +Cc: matan, shahafs, viacheslavo, dingxiaoxiong, Yunjian Wang, stable

From: Yunjian Wang <wangyunjian@huawei.com>

Currently, configuring a mlx device, it will allocate its
own process private in mlx5_proc_priv_init() and only frees
it when closing the device. This will lead to a memory leak,
when a device is configured repeatedly.

For example:
for(...)
do
	rte_eth_dev_configure
	rte_eth_rx_queue_setup
	rte_eth_tx_queue_setup
	rte_eth_dev_start
	rte_eth_dev_stop
done

Fixes: 97d37d2c1f6b ("net/mlx4: remove device register remap")
Cc: stable@dpdk.org

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
 drivers/net/mlx4/mlx4.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
index 7cd35cd3ca..c72587b7ef 100644
--- a/drivers/net/mlx4/mlx4.c
+++ b/drivers/net/mlx4/mlx4.c
@@ -201,6 +201,8 @@ mlx4_proc_priv_init(struct rte_eth_dev *dev)
 	struct mlx4_proc_priv *ppriv;
 	size_t ppriv_size;
 
+	mlx4_proc_priv_uninit(dev);
+
 	/*
 	 * UAR register table follows the process private structure. BlueFlame
 	 * registers for Tx queues are stored in the table.
-- 
2.23.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-13  2:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12 13:18 [dpdk-dev] [PATCH 1/2] net/mlx4: fix mem leak when a device configured repeatedly wangyunjian
2021-05-12 14:04 ` Slava Ovsiienko
2021-05-13  2:36   ` wangyunjian

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).