From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F2FC41BDD; Sun, 5 Feb 2023 19:03:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3711D40A7D; Sun, 5 Feb 2023 19:03:35 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 7992040041 for ; Sun, 5 Feb 2023 19:03:34 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 2AFBC5C01F5; Sun, 5 Feb 2023 13:03:34 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 05 Feb 2023 13:03:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675620214; x= 1675706614; bh=6RkVpmmJdPAwQfcZs99PAoa2cd9BqBCyAr1j0hSukTY=; b=F OjlvcTUyyLUHQIMiflHzmVP9r5xaK7NeOdUesKsJcLE/86hHUcaoEI2W8Np0yYGZ tn0XgXYzOlmDGeb/zL/NIESUjf7a9WJA5vmGo2tQsTjlmF/UlxEIKoQkkit5f6Lo erj/0Iwd1VRlla9IaQm05BBb+klvlgziGQPIaHzsx1vPqhi6WvRuv/5YkyypLEpe zfO5ZmN9C9QA1a2Uz+uA/GgsXFkhH5JFMvDUdAJo/A8V3vTFvpfRuLMLORAXF+kV sgrZ24+tTsmjrRWMhaqU2J+tYlwMD1gRLLZAB1CcceQIrhys3BrSml/56YmY0r47 epdClbdDa/Gi4g1npD7hA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1675620214; x= 1675706614; bh=6RkVpmmJdPAwQfcZs99PAoa2cd9BqBCyAr1j0hSukTY=; b=X p87GY0Pj/PY04Ej77cj8KPZRUd/tX1dZkRPSrNY6lCuAlzJe8FL/HX9lWv0iCK6m IfrDJA/JsMyXwH6BM5d1l92icmAGfr8ny2Ti8iBSZgwvWNLynaVjstcuAlvkLAf1 fXbQfV0VnJSFvtZL0Yjc/g4xsCb2DpM48ZD1ZiAaYcnFGln6dr5SYW7xf+sxfg2q NtkX9ICe0ZAb1V9yZkz/ti6+fW6zQI/7RP08BNvlrlQBAtEYt6bnDZr2iTEIBoae NhxDcYXUEQkSWLJz+m/9Qt2zq7uRODiFQl/PHZIuJqbPh1kxu/tyncCz2EioVASd ibYAPs/mopOLM0pjvfa5A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeggedguddtjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 5 Feb 2023 13:03:33 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, Ferruh Yigit Subject: Re: [kmods PATCH] linux/igb_uio: allow modules install Date: Sun, 05 Feb 2023 19:03:32 +0100 Message-ID: <837812030.0ifERbkFSE@thomas> In-Reply-To: References: <20220412131453.3927-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 14/06/2022 12:25, Ferruh Yigit: > On 4/12/2022 2:14 PM, Bruce Richardson wrote: > > CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. > > > > > > For those still using the "igb_uio" kernel module, there may be > > occasions where the module is installed in /lib/modules/$VERSION folder > > rather than being insmod'ed from the build directory. To support this, a > > number of changes are needed to the makefile: > > > > * Change the "clean" command to a generic wildcard target where that > > target is just passed through to the top-level kernel makefile. This > > should allow all standard kernel module targets, including "clean" and > > "modules_install" to work. > > ack > > > * To install in /lib/modules, root permissions are needed, so it is > > likely that users may try installing the module using "sudo". However, > > under sudo there is often no $PWD environment variable, breaking the > > build. This can be fixed by changing the environment variable $PWD to > > the make built-in variable "CURDIR"[1]. > > It can be possible to use shell PWD: > > "make -C $(KSRC)/ M=$$PWD" > > or > > " > PWD := $(shell pwd) > > all: > make -C $(KSRC)/ M=$(PWD) > " > > But '$(CURDIR)' also seems doing the job, so lgtm. > > > * As a cleanup, the actual kernel module path is got directly by make > > from the shell, rather than relying on the shell substitution later > > when making the recursive make call. This improves things slightly for > > the user as the full recursive command is visible, with the kernel > > version appearing in place of `uname -r` in the output. > > > > ack > > > [1] While neither PWD nor CURDIR will work correctly in the case where > > one is building outside of the sources directory, this is an edge case, > > and a simple replacement of PWD by CURDIR keeps things simple while > > adding support for "sudo". > > > > Signed-off-by: Bruce Richardson > > Acked-by: Ferruh Yigit Applied, thanks.