From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E4A571B1EC for ; Thu, 12 Oct 2017 00:26:37 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8D01F217D9; Wed, 11 Oct 2017 18:26:37 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 11 Oct 2017 18:26:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=GyQcX1by0QCz0//W/94RiB68YW 8WOLHVHA0cnIN/pYI=; b=Hdx8/1Iigur3FlbObcDszGvJTtFS2bKYjnRFGI/yta /bRiz+a4muGYB9AWKOThpJseOVHigCI+TMyobumfG6iASNGg8HsAmg6grAvz1Y7L CVOy/Wb21EOhYjBMqGzIOQosqheMzQc+ISrpKSqrlvMAO38YVQnE4+LGrXE20oVd E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=GyQcX1 by0QCz0//W/94RiB68YW8WOLHVHA0cnIN/pYI=; b=YWjME6V9mQLieU8u05vEYN oW39OBPjMrZeo/67QkVtBvL3YfBREhemiPlBfBomCtmCFkbTAROT3Ip+UvpkA+v3 J+f/PBVEybrCuETDtBcrDga/eM1Ixun9dEgjfXFO1X4bjwaqMZQoDYMQeSbtN8mB X/9sQcCTdj7efPq+mJIFyUEdyPI12nP/KwA3JeLDkYJODTL9f98VmiVw52zMaxKj Wjx/LfeC8ldVvfMzGeCZ4xpWSh2/fAes7NnXssokZgIVsbiihV9VY40mhMHeOu39 PM/HfK0QxncjYms9usT/9Y4HZacxc3t271e00Fr2Umi4AO43vM1FLi2PTPkGEiAA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 39DD824038; Wed, 11 Oct 2017 18:26:37 -0400 (EDT) From: Thomas Monjalon To: Kirill Rybalchenko Cc: dev@dpdk.org, andrey.chilikin@intel.com, beilei.xing@intel.com, jingjing.wu@intel.com, ferruh.yigit@intel.com Date: Thu, 12 Oct 2017 00:26:36 +0200 Message-ID: <8389257.54itpyZSoc@xps> In-Reply-To: <1507667338-15742-2-git-send-email-kirill.rybalchenko@intel.com> References: <1507666412-15320-1-git-send-email-kirill.rybalchenko@intel.com> <1507667338-15742-1-git-send-email-kirill.rybalchenko@intel.com> <1507667338-15742-2-git-send-email-kirill.rybalchenko@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/4] ethdev: add support for raw flow type for flow director X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2017 22:26:38 -0000 Hi, 10/10/2017 22:28, Kirill Rybalchenko: > Add new structure rte_eth_raw_flow to the union rte_eth_fdir_flow > to support filter for raw flow type. > > Signed-off-by: Kirill Rybalchenko This description does not explain why you add this new flow director type. It seems you are allowing a new feature to filter custom protocols. As I replied on v2, you are implementing your new feature with a deprecated API (there is a deprecation notice without any deadline). It is dangerous because this new use case will be settled on top of a fragile foundation. And because of these new users, it will be harder to drop this API as announced. It is also dangerous because you are not trying to implement your feature with the new rte_flow API. So we cannot be sure that it will fit for every use cases. If rte_flow is not good enough, we must improve it. This is my suggestion: 1/ Implement this interesting feature with rte_flow. 2/ Switch every other use cases to rte_flow. 3/ Let's agree on a date to drop the legacy flow director API. So this is a NACK. Please let's move forward.