From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F6E1A00BE; Tue, 25 Jan 2022 18:37:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1AB4041171; Tue, 25 Jan 2022 18:37:26 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id E9C2C41161 for ; Tue, 25 Jan 2022 18:37:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643132244; x=1674668244; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=Lg0mR5iQCaIIXotTDjJxiAuigjQNiA+3jAGPID37zkg=; b=ZTkqNl/cdmE+nUQQl89v3JTWc6BX6pTdRs7tHic1LJKeliv6X64fNnYO oUORjsAjZ/N+NNROdBy2AvRRHG428LmzNZC8K5oe5IF4ODFW/O3u0GQ4E PtzKVUtCw5xoToGw3egtf5N5LJYIv6QsMAFJqswwW4qMv/yxWlXa3cC8f cY7wwkW9XVJoVCsx//ZwQAXCQUZb1EP8xjig4n/hy71/mAZZ7iFo7tQAb 6jiqRLg31a88POL2F93rH0T2fD9rKjkO/MrDcoumXVKT5SZYTxDMUHU4H r2ue5dqyzhWxRARyzqWWh2gOKn2cT/FkN4XoLoV47Br3/0zwksv7BNGCf g==; X-IronPort-AV: E=McAfee;i="6200,9189,10237"; a="233731846" X-IronPort-AV: E=Sophos;i="5.88,315,1635231600"; d="scan'208";a="233731846" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2022 09:37:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,315,1635231600"; d="scan'208";a="479574373" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga006.jf.intel.com with ESMTP; 25 Jan 2022 09:37:13 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 25 Jan 2022 09:37:12 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 25 Jan 2022 09:37:12 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 25 Jan 2022 09:37:12 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 25 Jan 2022 09:37:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jzaCVWrXxPx++LRZ1SAMsmyGbQfe51PgHezXpItW8qq1GjmOs/uf3/zBLAWVASqQZDbHAjgoX2yiuoYpFBmMl8Kocg3XWjCU1dhMnqRmf/dVpwMpCVLc06D5gBmFjphjXmalEXLwxmViSDCClMK4ZF1vczXB9/wC3I0TC4WkSea1/3nrymdD81Ma1bgozehqIBxLzZ8RVrnqtxPknyUe3ATOrgh8OOMkh9XEjLHT9hWA4edEXfnPBqmleBtMV6FF3NFL4I3pFZbLyZUfOHPPHAD/3ToF5CXAqaKWBZln6MVco1fdunqTJFAAmV8i3PsCOGX6WSlOnhDlcNuvu1x+8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gsqy/uNYAGhGsu1MFLWEcjc7FdwD2HNM+loZ9VoBWhE=; b=TIDwR8XpRadG0WqF5rorwE1CEpL/TohFU5iHJVq/6VTChxPym4eJIN6tTCqtu9J0oKvzx6wRtC41ckcVB25cbnn5KsGUXvzR8Ts0mzFPQlQz6eHDGne5xPTLnRy2LnJ+iQVjSVydJRaSd0kvgCHtLGZiRWDKU2srQgxvK+LVP2jxCEaUJv0OeS9H5WvcUjvog+sJeypcNe8TbteX3zYunj/2hK36Y13Gf1Aq15m8WXXMC6crDiYEzR/+J5ZW+FDX1Dg2eY7TevY50ZWWV7upXY+s1RknJnuKXEvj39n1XmP/owZN+F3E/Co4obQMCyhwJqvehGGhsD6iw208UTV6Qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) by CY4PR11MB1318.namprd11.prod.outlook.com (2603:10b6:903:27::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.13; Tue, 25 Jan 2022 17:37:07 +0000 Received: from SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::5097:78f8:816f:f243]) by SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::5097:78f8:816f:f243%6]) with mapi id 15.20.4930.015; Tue, 25 Jan 2022 17:37:07 +0000 Message-ID: <839ce0f4-3170-8f2d-c05b-46cf6a99553f@intel.com> Date: Tue, 25 Jan 2022 17:36:48 +0000 Content-Language: en-US To: , , Xiaoyun Li , Aman Singh , Yuying Zhang CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20220109105851.734687-1-skori@marvell.com> <20220113102718.3167282-1-jerinj@marvell.com> <20220113102718.3167282-2-jerinj@marvell.com> From: Ferruh Yigit Subject: Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add queue based pfc CLI options X-User: ferruhy In-Reply-To: <20220113102718.3167282-2-jerinj@marvell.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0148.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::9) To SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de839546-6b61-420e-fa79-08d9e0294e71 X-MS-TrafficTypeDiagnostic: CY4PR11MB1318:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2657; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cpVA8YjyrB8WFEzOAfzjMC+j7Sci48U2PqpLL9V2eMSQomSm7jnahfh4DbeuivMqF/jVmxorzpiNhHWcxHaxjyqB2kElAJUSflV9lgPig1OuRbI/zt9eAnZb/FabOlqxm/MaVt1Y0kw6gj3dy30+K+3aEiFgO9vzsGRlqyGTBpfMaW317VNGxcVxps6+iAYVgH9q2U85VC0V5/rVI32cXWDR3HplcEBifStaC3rbM8v9xRXA6gaw95Zhx/A6i4DcxsRvCX2Fyn8RdaqMPPMeeXzRsrtr7jvmQFkYRj3V1F91583bDIvbZZhjvjklmuiuQGilCOjX+saUKH92RXvIjE/5WkS3In/Crodet3BDx9hwrxbYHvgsxMyOIPlRF/Q+Fjq6IhCnPD7PjJyYu9Q5KZ54iX61mQtHuThnq39gsnw025vsEUjHPuiFD0HGIK/EIHnml3m2mKEnxZ+MXAmvMcERiAmQdO7Jz6T3tYNgvsgPHs5C7paN8+U47JFzonRCwy2V5JCyjdK/rUZi4siEeW8sDXAsP2SG0VfpKTuowFcMrCo5lWp8n0j3c3353aL6f0nUibkqKqWXcDpjPR78Nx3msmCnZA51Rq2CiboEpc1k/tCwtPILUi3uowi/4i0mAqUwxa+yJiIXKtoy/p4x9qT3W4kKRNKAu7we/1SgJWPnc9rCfQqJPPB5LTbeiVBp+A+rapbuvk0Rk8ds3Fx8zA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5005.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6636002)(38100700002)(186003)(316002)(36756003)(6666004)(110136005)(4744005)(31696002)(66556008)(508600001)(83380400001)(8676002)(66946007)(5660300002)(66476007)(6486002)(4326008)(7406005)(26005)(7416002)(7366002)(6512007)(2906002)(86362001)(2616005)(8936002)(6506007)(31686004)(82960400001)(53546011)(44832011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bS9VVFZCU1dlTGExVXJoQVlhUXRqYUkrbUQxRjQrM2w4aDFOdHBRbzdTaFQr?= =?utf-8?B?Slp4NGVQcWRobkgwR25xNGgwZGtBS2Z0aERxODFFMDFMOG9Vazl4dnJKRm5q?= =?utf-8?B?alFEZVFHWWdiRk5yY3dVaWxWK253QlpKN3JScGYxSkFOZHpXby9Jai9ZNTJI?= =?utf-8?B?Qk5QaWh2SEVIcFN3SlhvSjhUOVNXRzZqZTJhTFpTTndNK0o2eUJHV2pCKzlX?= =?utf-8?B?SVNtS0hMWFBPNWlEbmpTWFpkc3ExVHNzYTVGVGVhbkpjVDRIdEdDa0VQY0Z0?= =?utf-8?B?RU91RWtoQU5RYlJSNHQvaFN1Y3ZNWDF5cHRpVzd2YUU1REswc1BQcS9oWVE5?= =?utf-8?B?TTNXMHNUVDU2akt2ZVFjUkdvTmxaTk5xTmhoS3pLRUJIUTNDWFo4OUxHMkJS?= =?utf-8?B?blFqU3FxKzBZcURMUW1SVHJtaEM4dHdlN2FldXdsRnJoTDlOUGxwTUtUdGh3?= =?utf-8?B?SjcxSUtJU2I5YlpiYThqNDlqcGJCS25vRlZoRmRxVUE3d3NabFpkYS9jR0M4?= =?utf-8?B?Sk5wcFNtSTlkNVFvZHBjbFZpbDZGd0hDOHQyNnNZM2NEWExqWDZkWjZ6dUo2?= =?utf-8?B?REZoMi96ODlkRE81NWhncGxyWW90bzZiMUhPS3dvdktaenZLUTdjWG1PYWh1?= =?utf-8?B?TXNhVzIwRGdNR3hrTmFOekV5S29MSVFrVERyT0htYTYwTHk0Wk96QTdYSkF6?= =?utf-8?B?VG1rRzVRS3MrYzlySGZ0MTFiMlhzQjZQYmhOUmp4cTg5ZUh2VHE4aVpwUmFM?= =?utf-8?B?WVBkL0JkMGhVVTN0SllYY0FTaXVmVUdmYVlYaFdwcm51d2JlSEczZEFHL3Vj?= =?utf-8?B?eXhCRUFVdE5xdmlMU3NaWDJoWTR0cXZXbjRwQ0RsRHdFTnlvaXBoOVFZWHBX?= =?utf-8?B?SFZVcC9MSDVtRzJ2NnYzTExwZTNkTXJBdyt4RStUZzJ0UHJCNktqQXhxU2l6?= =?utf-8?B?MUdqV3pYWDhabGUwdUhJWjA0QUREV3BjQ2JwR0RJdlNreUVKZkNCR1FJeVJX?= =?utf-8?B?eTh4R2txRkEyNnYyYlZHSVA4ZGdGVW9GTlYzZlU3TGNkUi9Sa0Z5TEdleitu?= =?utf-8?B?Wjk1aHVQMnBnb2p5UEIyYzdJWGtPTGNYZEdaY1c0UDhOeW1YMlp4b2F2ZXRn?= =?utf-8?B?RXVYays2aUYvMXRlbWZKMndUa2Zkc3RVV2k3RUVCeDFtYlQ3L1hrOFZYOVFr?= =?utf-8?B?V2YxTjBWWUVIQ3hTMGFCQnY1T3E5WWxzcUo1MmlrVmRQZDMvSWZla2RuSHVz?= =?utf-8?B?TGZTMnNjVVhVdDA0dzRTaVliWUdEQzkzZ0ZsRm15RTczb1IwRnhwY1FvSGQ2?= =?utf-8?B?QUJYd3VaMzdvdUFwUGYrSyt1V1ZpWU0vaTBsMmxmcHVLRnJBU25RWHd6YzJG?= =?utf-8?B?bG9kaHFQcjJyTEcvWWUrRTM4d1AwTWVCZytOZUYrS2ptYzl6Z2JJZkNhSlhv?= =?utf-8?B?VkhvaGp6Z1M5OW9TcVhTUGR0RVd4SkY4SDV2aFpBNGR4c243dHptU1ZFT0d2?= =?utf-8?B?SGdmZW1KNHc5VUwzMXFUbGY4RFJ0bmtaSzV0Nks2aVlKU3JKNW9IZGpKbWhj?= =?utf-8?B?VGJ0SllMbG9IOG9yelVvQlFYRmlXd1dBZDIvMGQyZzR2bkNSWXJmc05hRm1I?= =?utf-8?B?aWdMTThFRVJMTzhyNjY3MjBUbHEybktKWGdhNUpWUitWYUJUNHpZVUtTejkv?= =?utf-8?B?dnkzdGxnTEk5TEd1c2lndm9FUVV3ZU9iekVYNkFQOXdTOWRiVU93YTRmUWlL?= =?utf-8?B?MVRQRUtPaUlFcU9MR1ZqVXdQZTRBa2lSNS8yb0hiYmZWamdSOHZNMWJlSUJj?= =?utf-8?B?a3VZeHYzUExNWHhta296S3JqL2cvYlVWT2RXYkRxaTV6SHZ0RjB3QnZJN3N4?= =?utf-8?B?Y3oxSGRxdXJnSnV3MThlc3NEVjZvNnRITVNTRHJXci90ZHJSVUVtN1I3WmtY?= =?utf-8?B?elIrOUh4dGFzSEprUXRhOFJZbzRJY0RSeE9pbXFGOXRhSXd6MXNZdWM5RXFi?= =?utf-8?B?OUNBelU2OGxaaEU2UVZEVmlRY3gvMU5vNWRBN3l5di9VVnBlTWVPUTRnYyt4?= =?utf-8?B?Rnh6TCtZVWZNNGZ5WkhwWmhRYVExdDJudFd5Tnlobm9hLytnRGdSajRucmIr?= =?utf-8?B?N21SYmRwNUFIRXhSYXJPb0VKcXIvWkJHc2t4d0xrL0Q2VjNmVnJBZVlHRG9z?= =?utf-8?Q?36ZXaKtCXfNkKZMRcFkUgSg=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: de839546-6b61-420e-fa79-08d9e0294e71 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5005.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2022 17:37:07.0415 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1ycbtV+zDkbKp8TfXRsRumaVdDx3/ZlEHblVv0ryrno7CQDiN7RUbQTNvP8dG6txVktQbudhg06dTShIucXMJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1318 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/13/2022 10:27 AM, jerinj@marvell.com wrote: > From: Sunil Kumar Kori > > Patch adds command line options to configure queue based > priority flow control. > > - Syntax command is given as below: > > set pfc_queue_ctrl rx \ > tx > Isn't the order of the paramters odd, it is mixing Rx/Tx config, what about ordering Rx and Tx paramters? > - Example command to configure queue based priority flow control > on rx and tx side for port 0, Rx queue 0, Tx queue 0 with pause > time 2047 > > testpmd> set pfc_queue_ctrl 0 rx on 0 0 tx on 0 0 2047 > > Signed-off-by: Sunil Kumar Kori <...>