Re: [dpdk-dev] [PATCH v3 1/5] devargs: unify scratch buffer storage

["Kinsella, Ray" <mdr@ashroe.eu>]

On 30/03/2021 13:15, Xueming Li wrote:
> In current design, legacy parser rte_devargs_parse() saved scratch
> buffer to devargs.args while new parser rte_devargs_layers_parse() saved
> to devargs.data. Code using devargs had to know the difference and
> cleaned up memory accordingly - error prone.
> 
> This patch unifies scratch buffer to data field, introduces
> rte_devargs_reset() function to wrap the memory clean up logic.
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> ---
>  app/test-pmd/config.c                        |  3 +-
>  app/test-pmd/testpmd.c                       |  5 +--
>  drivers/bus/vdev/vdev.c                      |  9 +++---
>  drivers/net/failsafe/failsafe_args.c         |  3 +-
>  drivers/net/failsafe/failsafe_eal.c          |  2 +-
>  examples/multi_process/hotplug_mp/commands.c |  6 ++--
>  lib/librte_eal/common/eal_common_dev.c       |  9 +++---
>  lib/librte_eal/common/eal_common_devargs.c   | 34 +++++++++++---------
>  lib/librte_eal/common/hotplug_mp.c           |  6 ++--
>  lib/librte_eal/include/rte_devargs.h         | 18 ++++++++---
>  lib/librte_eal/rte_eal_exports.def           |  1 +
>  lib/librte_eal/version.map                   |  1 +
>  lib/librte_ethdev/rte_ethdev.c               |  8 ++---
>  13 files changed, 59 insertions(+), 46 deletions(-)
> 

Acked-by: Ray Kinsella <mdr@ashroe.eu>