From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 86CC0A034E;
	Wed,  9 Feb 2022 02:07:06 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 688D1410F3;
	Wed,  9 Feb 2022 02:07:06 +0100 (CET)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by mails.dpdk.org (Postfix) with ESMTP id C0B554067E
 for <dev@dpdk.org>; Wed,  9 Feb 2022 02:07:04 +0100 (CET)
Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.55])
 by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4JthSV5CqnzZfVl;
 Wed,  9 Feb 2022 09:02:50 +0800 (CST)
Received: from [10.67.103.128] (10.67.103.128) by
 dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id
 15.1.2308.21; Wed, 9 Feb 2022 09:07:02 +0800
Subject: Re: [PATCH] ethdev: introduce ethdev dump API
To: Thomas Monjalon <thomas@monjalon.net>, =?UTF-8?Q?Morten_Br=c3=b8rup?=
 <mb@smartsharesystems.com>, <dev@dpdk.org>, Ferruh Yigit
 <ferruh.yigit@intel.com>
CC: Ray Kinsella <mdr@ashroe.eu>, Ajit Khaparde <ajit.khaparde@broadcom.com>, 
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
References: <20220111115437.32855-1-humin29@huawei.com>
 <8ca8568e-b88c-e758-fc0b-d11b7cb997af@huawei.com>
 <9900011f-89a2-dc69-523f-2259cb4a7085@intel.com> <5691769.MhkbZ0Pkbq@thomas>
From: "Min Hu (Connor)" <humin29@huawei.com>
Message-ID: <83b676bf-c7f9-ce05-97d3-63caba88bb5f@huawei.com>
Date: Wed, 9 Feb 2022 09:07:02 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <5691769.MhkbZ0Pkbq@thomas>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.103.128]
X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To
 dggeme756-chm.china.huawei.com (10.3.19.102)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org



在 2022/2/8 21:52, Thomas Monjalon 写道:
> 08/02/2022 13:59, Ferruh Yigit:
>> On 2/8/2022 11:14 AM, Min Hu (Connor) wrote:
>>> 在 2022/2/8 18:21, Ferruh Yigit 写道:
>>>> What I understand was this API can return any device private information,
>>>> it is not limited to 'ethdev->data->dev_private', (although most of the
>>> I think this API is limited to 'ethdev->data->dev_private'.
>>>> data
>>>> is represented in this struct), like if you want to dump queue state,
>>>> this is out of 'ethdev->data->dev_private'.
>>> Queue state can be dumped using API 'rte_eth_tx_queue_info_get'.
>>>
>>
>> Yes it can be. But as far as I can see there is nothing prevents the dump()
>> API to provide the same, it is up to PMD.
>>
>> If the intention is to limit what can be dump to 'ethdev->data->dev_private',
>> it is not clear from API documentation/implementation.
> 
> Why limiting?
> The dump could even print debug infos which are nowhere else.
Yes, no need to limit, it is up to PMD, just as Ferruh said.
> 
> 
> 
> .
>