From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B505043C8B; Tue, 12 Mar 2024 07:07:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 894C2402DC; Tue, 12 Mar 2024 07:07:30 +0100 (CET) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id 670AE40282 for ; Tue, 12 Mar 2024 07:07:29 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.88.163]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Tv35T2G8yz2BfbZ; Tue, 12 Mar 2024 14:05:01 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 88FD018002D; Tue, 12 Mar 2024 14:07:27 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 12 Mar 2024 14:07:27 +0800 Subject: Re: [PATCH v2] doc: update size parameter details To: Vipin Varghese , CC: , References: <20231212104508.1941-1-vipin.varghese@amd.com> <20240312042201.157-1-vipin.varghese@amd.com> From: fengchengwen Message-ID: <83c1f9b2-74f1-6d78-ae6c-a89392a9e88d@huawei.com> Date: Tue, 12 Mar 2024 14:07:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20240312042201.157-1-vipin.varghese@amd.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Chengwen Feng On 2024/3/12 12:22, Vipin Varghese wrote: > For configuration parameters `mem_size` and `buf_size` are represented > as megabytes and bytes respectively in application. Update the > documentation and to represent the same. > > V2 Changes: > - add mem_size and buf_size in config.ini, suggested by Chengwen. > > Signed-off-by: Vipin Varghese > --- > --- > app/test-dma-perf/config.ini | 4 ++-- > doc/guides/tools/dmaperf.rst | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/app/test-dma-perf/config.ini b/app/test-dma-perf/config.ini > index b550f4b23f..17aa91c22d 100644 > --- a/app/test-dma-perf/config.ini > +++ b/app/test-dma-perf/config.ini > @@ -5,8 +5,8 @@ > ; Supported test types are DMA_MEM_COPY and CPU_MEM_COPY. > > ; Parameters: > -; "mem_size" denotes the size of the memory footprint. > -; "buf_size" denotes the memory size of a single operation. > +; "mem_size" denotes the size of the memory footprint in megabytes (MB) for source and destination. > +; "buf_size" denotes the memory size of a single operation in bytes (B). > ; "dma_ring_size" denotes the dma ring buffer size. It should be must be a power of two, and between > ; 64 and 4096. > ; "kick_batch" denotes the dma operation batch size, and should be greater than 1 normally. > diff --git a/doc/guides/tools/dmaperf.rst b/doc/guides/tools/dmaperf.rst > index 9e3e78a6b7..6f85fceb8a 100644 > --- a/doc/guides/tools/dmaperf.rst > +++ b/doc/guides/tools/dmaperf.rst > @@ -74,10 +74,10 @@ Configuration Parameters > Currently supported types are ``DMA_MEM_COPY`` and ``CPU_MEM_COPY``. > > ``mem_size`` > - The size of the memory footprint. > + The size of the memory footprint in megabytes (MB) for source and destination. > > ``buf_size`` > - The memory size of a single operation. > + The memory size of a single operation in bytes (B). > > ``dma_ring_size`` > The DMA ring buffer size. Must be a power of two, and between ``64`` and ``4096``. >