From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 535F6A0093; Wed, 20 May 2020 22:46:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B60E1C1DC; Wed, 20 May 2020 22:46:38 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 8E5211C1C0 for ; Wed, 20 May 2020 22:46:36 +0200 (CEST) IronPort-SDR: ZWbCmBhHCtOStiY0tUue+OpasmitEWhQmSEQRTQXWFR9AZS2wzoVwttQvrfLuEnGKMrRcU22EJ Hdlh1KOp/pag== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2020 13:46:35 -0700 IronPort-SDR: 24cKvnme/iAN5/g7XQqnw5O9vZOwlLXiScee2NwgFnxaWMqSzixCDVm2i8zAKjiwbZ+il+umCo cwUnkdNQhmgw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,415,1583222400"; d="scan'208";a="253775908" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by fmsmga007.fm.intel.com with ESMTP; 20 May 2020 13:46:34 -0700 Received: from [10.166.30.253] (10.166.30.253) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 May 2020 13:46:34 -0700 To: Fady Bader , CC: , , , , , , , References: <20200520104445.9072-1-fady@mellanox.com> From: Ranjit Menon Message-ID: <83c25e3c-f77d-25d2-47f1-4484b69265d3@intel.com> Date: Wed, 20 May 2020 13:46:31 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200520104445.9072-1-fady@mellanox.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.166.30.253] Subject: Re: [dpdk-dev] [PATCH v2] ring: build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/20/2020 3:44 AM, Fady Bader wrote: > Exported per_lcore__rte_errno function to compile ring for windows. > > compilation error logs: > librte_ring_rte_ring.c.obj : error LNK2019: unresolved > external symbol per_lcore__rte_errno referenced in > function rte_ring_lookup > > The cause was that per_lcore__rte_errno function wasn't included > in the export list. > To solve this per_lcore__rte_errno was added to the Windows export > list. > > Signed-off-by: Fady Bader > Depends-on: series-9374 ("Windows basic memory management") > --- > lib/librte_eal/rte_eal_exports.def | 1 + > lib/librte_eal/rte_eal_version.map | 3 +++ > lib/meson.build | 5 ++++- > 3 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def > index 854b83bcd..cbb6b8cfe 100644 > --- a/lib/librte_eal/rte_eal_exports.def > +++ b/lib/librte_eal/rte_eal_exports.def > @@ -1,5 +1,6 @@ > EXPORTS > __rte_panic > + per_lcore__rte_errno > rte_calloc > rte_calloc_socket > rte_eal_get_configuration > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map > index bdd014638..0f1b983b8 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -390,4 +390,7 @@ EXPERIMENTAL { > rte_trace_point_lookup; > rte_trace_regexp; > rte_trace_save; > + > + # added in 20.08 > + __emutls_v.per_lcore__rte_errno; > }; > diff --git a/lib/meson.build b/lib/meson.build > index d190d84ef..98ee5ec57 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -36,7 +36,10 @@ libraries = [ > 'flow_classify', 'bpf', 'graph', 'node'] > > if is_windows > - libraries = ['kvargs','eal'] # only supported libraries for windows > + libraries = [ > + 'kvargs', > + 'eal', > + 'ring'] # only supported libraries for windows Please tab out the list of libraries above for formatting purposes. Also, to make future changes simpler, you could do this as: libraries = [         'kvargs',         'eal',         'ring',         ] # only supported libraries for windows ranjit m.