From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1BAFA2EDB for ; Tue, 1 Oct 2019 18:45:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CCEDF1B9A9; Tue, 1 Oct 2019 18:45:19 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E655E1B94A for ; Tue, 1 Oct 2019 18:45:17 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2019 09:45:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,571,1559545200"; d="scan'208";a="216130068" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by fmsmga004.fm.intel.com with ESMTP; 01 Oct 2019 09:45:13 -0700 To: "Iremonger, Bernard" , Andrew Rybchenko , "Su, Simei" , "Zhang, Qi Z" , "Ye, Xiaolong" Cc: "dev@dpdk.org" References: <1569740956-69634-1-git-send-email-simei.su@intel.com> <1569940564-311988-1-git-send-email-simei.su@intel.com> <1569940564-311988-3-git-send-email-simei.su@intel.com> <155d1d0d-c5cd-2fc1-ad48-345d219bd02f@solarflare.com> <8CEF83825BEC744B83065625E567D7C260DFF4DE@IRSMSX108.ger.corp.intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <83c85014-249b-2451-4df8-57e8ff22a3ec@intel.com> Date: Tue, 1 Oct 2019 17:45:13 +0100 MIME-Version: 1.0 In-Reply-To: <8CEF83825BEC744B83065625E567D7C260DFF4DE@IRSMSX108.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v8 2/3] ethdev: extend RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/1/2019 5:02 PM, Iremonger, Bernard wrote: > Hi Simei, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andrew Rybchenko >> Sent: Tuesday, October 1, 2019 3:49 PM >> To: Su, Simei ; Zhang, Qi Z ; Ye, >> Xiaolong ; Yigit, Ferruh >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v8 2/3] ethdev: extend RSS offload types >> >> On 10/1/19 5:36 PM, Simei Su wrote: >>> This patch reserves several bits as input set selection from the high >>> end of the 64 bits. It is combined with exisiting ETH_RSS_* to >>> represent RSS types. >>> >>> Signed-off-by: Simei Su >>> Reviewed-by: Qi Zhang >>> Acked-by: Ori Kam >>> --- >>> lib/librte_ethdev/rte_ethdev.c | 22 ++++++++++++++++++++++ >>> lib/librte_ethdev/rte_ethdev.h | 14 ++++++++++++++ >>> 2 files changed, 36 insertions(+) >>> >>> diff --git a/lib/librte_ethdev/rte_ethdev.c >>> b/lib/librte_ethdev/rte_ethdev.c index af82360..5e5a974 100644 >>> --- a/lib/librte_ethdev/rte_ethdev.c >>> +++ b/lib/librte_ethdev/rte_ethdev.c >>> @@ -1269,6 +1269,17 @@ struct rte_eth_dev * >>> goto rollback; >>> } >>> >>> + /* simplified the SRC/DST_ONLY RSS offload modificaiton */ >>> + if (dev_conf->rx_adv_conf.rss_conf.rss_hf & >> ETH_RSS_L3_SRC_ONLY && >>> + dev_conf->rx_adv_conf.rss_conf.rss_hf & >> ETH_RSS_L3_DST_ONLY) >> >> I'm afraid some compiler versions could bark about missing parenthesis here. >> Consider to use something like: >>  (rss_conf->rss_hf & (ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY) == >>   (ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY)) May be parenthesis >> around & is not required. >> >>> + dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf >> &= >>> + ~(ETH_RSS_L3_SRC_ONLY | >> ETH_RSS_L3_DST_ONLY); >>> + >>> + if (dev_conf->rx_adv_conf.rss_conf.rss_hf & >> ETH_RSS_L4_SRC_ONLY && >>> + dev_conf->rx_adv_conf.rss_conf.rss_hf & >> ETH_RSS_L4_DST_ONLY) >>> + dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf >> &= >>> + ~(ETH_RSS_L4_SRC_ONLY | >> ETH_RSS_L4_DST_ONLY); >>> + >> >> I think it is wrong to duplicate the logic twice (here and below). >> Helper static function should be used to avoid it. >> >>> /* Check that device supports requested rss hash functions. */ >>> if ((dev_info.flow_type_rss_offloads | >>> dev_conf->rx_adv_conf.rss_conf.rss_hf) != @@ -3112,6 +3123,17 >>> @@ struct rte_eth_dev * >>> if (ret != 0) >>> return ret; >>> >>> + /* simplified the SRC/DST_ONLY RSS offload modificaiton */ >>> + if (rss_conf->rss_hf & ETH_RSS_L3_SRC_ONLY && >>> + rss_conf->rss_hf & ETH_RSS_L3_DST_ONLY) >>> + rss_conf->rss_hf &= >>> + ~(ETH_RSS_L3_SRC_ONLY | >> ETH_RSS_L3_DST_ONLY); >>> + >>> + if (rss_conf->rss_hf & ETH_RSS_L4_SRC_ONLY && >>> + rss_conf->rss_hf & ETH_RSS_L4_DST_ONLY) >>> + rss_conf->rss_hf &= >>> + ~(ETH_RSS_L4_SRC_ONLY | >> ETH_RSS_L4_DST_ONLY); >>> + >>> dev = &rte_eth_devices[port_id]; >>> if ((dev_info.flow_type_rss_offloads | rss_conf->rss_hf) != >>> dev_info.flow_type_rss_offloads) { diff --git >>> a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h >>> index 7722f70..6d61b84 100644 >>> --- a/lib/librte_ethdev/rte_ethdev.h >>> +++ b/lib/librte_ethdev/rte_ethdev.h >>> @@ -505,6 +505,20 @@ struct rte_eth_rss_conf { >>> #define ETH_RSS_GENEVE (1ULL << 20) >>> #define ETH_RSS_NVGRE (1ULL << 21) >>> >>> +/* >>> + * We use the following macros to combine with above ETH_RSS_* for >>> + * more specific input set selection. These bits are defined starting >>> + * from the high end of the 64 bits. >>> + * Note: If we use above ETH_RSS_* without SRC/DST_ONLY, it >>> +represents >>> + * both SRC and DST are taken into account. If SRC_ONLY and DST_ONLY >>> +of >>> + * the same level be used simultaneously, it is the same case as none >>> +of >>> + * them are added. >>> + */ >>> +#define ETH_RSS_L3_SRC_ONLY (1ULL << 63) >>> +#define ETH_RSS_L3_DST_ONLY (1ULL << 62) >>> +#define ETH_RSS_L4_SRC_ONLY (1ULL << 61) >>> +#define ETH_RSS_L4_DST_ONLY (1ULL << 60) >>> + >>> #define ETH_RSS_IP ( \ >>> ETH_RSS_IPV4 | \ >>> ETH_RSS_FRAG_IPV4 | \ > > This patch fails to apply to the latest master branch, a rebase may be needed. Patch applies well to next-net, which this patch should be for, no rebase required.