From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88EAEA04B3; Fri, 8 Nov 2019 13:20:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 05BEC1C122; Fri, 8 Nov 2019 13:20:31 +0100 (CET) Received: from dispatchb-us1.ppe-hosted.com (dispatchb-us1.ppe-hosted.com [148.163.129.53]) by dpdk.org (Postfix) with ESMTP id 9BB271C11D for ; Fri, 8 Nov 2019 13:20:29 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 4659D800072; Fri, 8 Nov 2019 12:20:27 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 8 Nov 2019 12:20:19 +0000 To: Ori Kam , "Zhang, Qi Z" , "Thomas Monjalon" CC: "dev@dpdk.org" , "pbhagavatula@marvell.com" , "Yigit, Ferruh" , "jerinj@marvell.com" , "Mcnamara, John" , "Kovacevic, Marko" , Adrien Mazarguil , "david.marchand@redhat.com" , "ktraynor@redhat.com" , Olivier Matz References: <20191025152142.12887-1-pbhagavatula@marvell.com> <1594828.JO7TyvRWtP@xps> <1784584.NQqjHnNvIa@xps> <039ED4275CED7440929022BC67E7061153DC6603@SHSMSX105.ccr.corp.intel.com> From: Andrew Rybchenko Openpgp: preference=signencrypt Autocrypt: addr=arybchenko@solarflare.com; keydata= mQINBF2681gBEACbdTxu8eLL3UX2oAelsnK9GkeaJeUYSOHPJQpV7RL/iaIskqTwBRnhjXt7 j9UEwGA+omnOmqQMpeQTb/F9Ma2dYE+Hw4/t/1KVjxr3ehFaASvwR4fWJfO4e2l/Rk4rG6Yi 5r6CWU2y8su2654Fr8KFc+cMGOAgKoZTZHZsRy5lHpMlemeF+VZkv8L5sYJWPnsypgqlCG3h v6lbtfZs+QqYbFH6bqoZwBAl5irmxywGR7ZJr1GLUZZ1lfdazSY8r6Vz0/Ip/KVxGu2uxo81 QCsAj0ZsQtwji9Sds/prTiPrIjx8Fc/tfbnAuVuPcnPbczwCJACzQr4q26XATL3kVuZhSBWh 4XfO/EAUuEq5AemUG5DDTM87g7Lp4eT9gMZB6P+rJwWPNWTiV3L7Cn+fO+l9mTPnOqdzBgDe OaulKiNSft1o0DY4bGzOmM2ad2cZt0jfnbMPMTE9zsr6+RFa+M8Ct20o6U1MUE4vP6veErMK of4kZ8PdoMM+Sq1hxMPNtlcVBSP9xMmdSZPlfDYI5VWosOceEcz7XZdjBJKdwKuz70V7eac4 ITSxgNFCTbeJ03zL2MR5s0IvD9ghISAwZ6ieCjU5UATn5+63qpD0nVNLsAdb/UpfvQcKAmvj 0fKlxu/PMVkjBa7/4cfNogYOhWDKUO+1pMaFwvb6/XTo6uMpfQARAQABtCxBbmRyZXcgUnli Y2hlbmtvIDxhcnliY2hlbmtvQHNvbGFyZmxhcmUuY29tPokCVAQTAQoAPhYhBP6NPgcKRj/Y X0yXQahue0sAy4m+BQJduvNYAhsDBQkB4TOABQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKhue0sAy4m+t3gP/j1MNc63CEozZo1IZ2UpVPAVWTYbLdPjIRdFqhlwvZYIgGIgIBk3ezKL K0/oc4ZeIwL6wQ5+V24ahuXvvcxLlKxfbJ6lo2iQGC7GLGhsDG9Y2k6sW13/sTJB/XuR2yov k5FtIgJ+aHa1PDZnepnGGOt9ka9n/Jzrc9WKYapOIIyLRe9U26ikoVgyqsD37PVeq5tLWHHA NGTUKupe9G6DFWidxx0KzyMoWDTbW2AWYcEmV2eQsgRT094AZwLFN5ErfefYzsGdO8TAUU9X YTiQN2MvP1pBxY/r0/5UfwV4UKBcR0S3ZvzyvrPoYER2Kxdf/qurx0Mn7StiCQ/JlNZb/GWQ TQ7huduuZHNQKWm7ufbqvKSfbPYvfl3akj7Wl8/zXhYdLqb5mmK45HXrgYGEqPN53OnK2Ngx IgYKEWr05KNv09097jLT5ONgYvszflqlLIzC4dV245g7ucuf9fYmsvmM1p/gFnOJBJL18YE5 P1fuGYNfLP+qp4WMiDqXlzaJfB4JcinyU49BXUj3Utd6f6sNBsO8YWcLbKBV9WmA324S3+wj f4NPRp3A5E+6OmTVMLWire2ZvnYp3YvifUj1r8lhoZ2B2vKuWwiTlHOKYBEjnOQJQnqYZEF0 JQQ1xzVDBQKE01BPlA3vy6BGWe6I4psBVqMOB9lAev/H+xa4u6Z3uQINBF269JsBEAC2KB3W 8JES/fh74avN7LOSdK4QA7gFIUQ4egVL81KnxquLzzilABuOhmZf3Rq6rMHSM8xmUAWa7Dkt YtzXStjEBI/uF0mAR3mMz1RcL2Wp+WD/15HjVpA7hPjXSEsWY0K2ymPerK4yrLcfFTHdMonY JfuACCC9NtOZxrWHOJoUS+RT7AWk80q/6D2iwQ47/2dBTznVG+gSeHSes9l91TB09w6f9JX/ sT+Ud0NQfm7HJ7t2pmGI9O6Po/NLZsDogmnIpJp/WwYOZN9JK7u2FyX2UyRzR8jK42aJkRsh DXs16Cc2/eYGakjrdO3x9a+RoxN7EuFtYhGR1PzMXdUiB5i+FyddYXkYUyO43QE/3VPA5l1v TUOagzZq6aONsdNonGJkV3TIG3JmUNtM+D/+r6QKzmgoJ8w576JxEZI09I/ZFN+g7BnUmlMx 6Z3IUOXVX/SWfGFga0YajwajHz03IBhChEbYbbqndVhmshu2GFURxrfUPYWdDXEqkh+08a5U Didia9jm2Opv4oE1e1TXAePyYJl/Zyps4Cv00GObAxibvMBQCUZQ+IBnNldRBOwXXRQV2xpx P+9iO1VYA/QXn0KqRK+SH1JGRXbJYi42YFaW1gE0EU0fiR2Wb9pK+doNEjjOhlzUGuvOEAUS +4m0m3dlfEvpCV9GMr7ERRpZzh9QkQARAQABiQI8BBgBCgAmFiEE/o0+BwpGP9hfTJdBqG57 SwDLib4FAl269JsCGwwFCQlmAYAACgkQqG57SwDLib7x6g//e+eCtNnJz7qFGbjWRJYNLCe5 gQwkhdyEGk4omr3VmjGj3z9kNFy/muh4pmHUngSAnnpwZggx14N4hhKf9y8G4Dwvsqa6b1zB Jq/c4t/SBDtGW4M/E331N04PaQZpcrbTfp1KqHNknk2N7yOk4CcoLVuIZmA5tPguASV8aAfz ZwhWAwn6vUEw9552eXEAnGFGDTCbyryNwzB5jtVQOEEDjTxcCkpcXMB45Tb1QUslRTu/sBAe HhPCQSUcJHR+KOq+P6yKICGAr291PZd6Qc7C3UyE+A3pY/UfdEVWj0STBWx1qvYLaHLrI4O9 KXDgh7luLjZZafcueCaPYmNo4V2lmNb3+7S4TvqhoZS+wN+9ldRQ4gH3wmRZybN6Y/ZCqxol RaZpE3AqdWsGvIgAkD0FpmtZNii9s2pnrhw0K6S4t4tYgXGTossxNSJUltfFQZdXM1xkZhtv dBZuUEectbZWuviGvQXahOMuH2pM64mx2hpdZzPcI2beeJNHkAsGT2KcaMETgvtHUBFRlLVB YxsUYz3UZmi2JSua4tbcGd6iWVN90eb8CxszYtivfpz6o2nPSjNwg0NaVGSHXjAK0tdByZ9t SkwjC3tEPljVycRSDpbauogOiAkvjENfaPd/H26V5hY822kaclaKDAW6ZG9UKiMijcAgb9u5 CJoOyqE8aGS5Ag0EXbr1RwEQAMXZHbafqmZiu6Kudp+Filgdkj2/XJva5Elv3fLfpXvhVt0Y if5Rzds3RpffoLQZk9nPwK8TbZFqNXPu7HSgg9AY7UdCM94WRFTkUCGKzbgiqGdXZ7Vyc8cy teGW+BcdfQycDvjfy50T3fO4kJNVp2LDNdknPaZVe8HJ80Od63+9ksB6Ni+EijMkh6Uk3ulB CSLnT4iFV57KgU2IsxOQVLnm+0bcsWMcCnGfphkY0yKP+aJ6MfmZkEeaDa7kf24N14ktg50m vOGDitcxA/+XXQXOsOIDJx1VeidxYsQ2FfsKu1G8+G6ejuaLf4rV5MI/+B/tfLbbOdikM5PF pxZVgTir9q13qHumMxdme7w5c7hybW412yWAe9TsrlXktFmFjRSFzAAxQhQSQxArS6db4oBk yeYJ59mW52i4occkimPWSm/raSgdSM+0P6zdWUlxxj+r1qiLgCYvruzLNtp5Nts5tR/HRQjE /ohQYaWDSVJEsc/4eGmgwzHzmvHtXeKkasn01381A1Lv3xwtpnfwERMAhxBZ8EGKEkc5gNdk vIPhknnGgPXqKmE1aWu8LcHiY+RHAF8gYPCDMuwyzBYnbiosKcicuIUp0Fj8XIaPao6F+WTi In4UOrqrYhsaCUvhVjsTBbNphGih9xbFJ8E+lkTLL8P3umtTcMPnpsB4xqcDABEBAAGJBHIE GAEKACYWIQT+jT4HCkY/2F9Ml0GobntLAMuJvgUCXbr1RwIbAgUJCWYBgAJACRCobntLAMuJ vsF0IAQZAQoAHRYhBNTYjdjWgdaEN5MrAN+9UR5r/4d3BQJduvVHAAoJEN+9UR5r/4d3EiQP /3lyby6v49HTU94Q2Fn2Xat6uifR7kWE5SO/1pUwYzx6v+z5K2jqPgqUYmuNoejcGl0CTNhg LbsxzUmAuf1OTAdE+ZYvOAjjKQhY4haxHc4enby/ltnHfWJYWJZ9UN5SsIQLvITvYu6rqthO CYjpXJhwkj3ODmC9H1TrvjrBGc6i7CTnR8RCjMEwCs2LI2frHa4R6imViEr9ScMfUnzdABMQ B0T5MOg8NX92/FRjTldU2KovG0ML9mSveSvVHAoEBLy4UIs5nEDdNiO1opJgKb5CXvWQugub 7AR52phNdKVdEB0S4tigJT4NalyTaPiUhFEm+CzZpMQDJ5E+/OowaPRfN4HeJX+c8sB+vUAZ mkAaG75N+IEk5JKFK9Z+bBYgPgaBDFZYdWDB/TMH0ANt+KI5uYg0i12TB4M8pwKG1DEPUmWc F2YpvB3jnbwzsOpSFiJOOlSs6nOB0Sb5GRtPOO3h6XGj+6mzQd6tcL63c9TrrUkjq7LDkxCz SJ2hTYRC8WNX8Uw9skWo5728JNrXdazEYCenUWmYiKLNKLslXCFodUCRDh/sUiyqRwS7PHEA LYC/UIWLMomI0Yvju3KA5v3RQVXhL+Gx2CzSj3GDz9xxGhJB2LfRfjzPbTR/Z27UpjCkd8z0 Ro3Ypmi1FLQwnRgoOKDbetTAIhugEShaLTITzJAP/iRDJCQsrZah5tE8oIl81qKEmBJEGcdt HYikbpQe7ydcXhqTj7+IECa3O7azI5OhCxUH2jNyonJ/phUslHH2G1TTBZK8y4Hrx5RpuRNS esn3P9uKu9DHqBAL7DMsCPwb2p1VNnapD72DBmRhzS/e6zS2R4+r9yNv03Hv7VCxKkmtE63H qpS//qpjfrtsIcHAjnKDaDtL1LYCtHoweI+DOpKKULSAYp/JE6F8LNibPQ0/P3S5ZIJNC4QZ uESjFOalJwFIqGQdkQB7ltRNJENLrHc+2jKGOuyFHm/Sbvp5EMGdaeQ0+u8CY0P+y6oXenwx 7WrJz/GvbNoFhJoJ6RzxCMQrFgxrssVZ7w5HcUj94lbnJ6osdYE/WpSd50B6jet6LKh5revg u9XI9CoqsPQ1V4wKYYdllPuogCye7KNYNKuiiuSNpaF4gHq1ZWGArwZtWHjgc2v3LegOpRQF SwOskMKmWsUyHIRMG1p8RpkBQTqY2rGSeUqPSvaqjT0nq+SUEM6qxEXD/2Wqri/X6bamuPDb S0PkBvFD2+0zr5Bc2YkMGPBYPNGZiTp3UjmZlLfn3TiBKIC92jherY563CULjSsiBEJCOSvv 4VPLn5aAcfbCXJnE3IGCp/hPl50iQqu7BPOYBbWXeb9ptDjGCAThNxSz0WAXkmcjAFE8gdE6 Znk9 Message-ID: <83dda74c-c5b4-13f4-626d-59cbb7793239@solarflare.com> Date: Fri, 8 Nov 2019 15:20:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-25028.003 X-TM-AS-Result: No-19.024500-8.000000-10 X-TMASE-MatchedRID: yebcs53SkkAeimh1YYHcKPZvT2zYoYOwC/ExpXrHizxIXJo+eGm+FOmW pqKXmZL548HHE4FHGXNwOt2cMbsmPtgwSqFJytAFLIrMljt3adsufEetamGGBC62hjZS0WoYVXp qymgIxTn5Ogc+ousCKNhU31UmZwEgEmj7CGXUVS4ea0JeKHt/0xmyTBaqiJvc+frbXg+Uc4UZIT 1bzAe3Rq6SFzrhphRrP4w+DObB57EdpNb7ZdqI99m6V9lyTcKhOYqKF7UrYh4aVuuTY4OGgzm/4 j0y1YWGuqXQhOxa0/PQAE2bD9BpcnAPv9fe5w++GMURfhQkELLnaaW2UTafyNDxDdXabYEQHu3G BT0Qw5MVi/VyQSYQ1EuduLMOjKpuBmjPEm4v5DNFM72aEhcbjRfbPFE2GHrVKBVvFbsUM5WHOw2 lOr0j7iUcbH8pz9oIxj5CCZ57+XMCC0ycMqrvIyAI8aJmq0jwUk7yUtNRk6cJeMOJX8c9nIvl3T oEz777Dkje7wtquzTlh94RfPcypuRMlopQwYJjdhnFihmbnwU7IFMOvFEK2OZMicrOlIVJhLVQ9 aAfflzxtERWzypybkcIEB3jcSAO7WdE1ZzvLpyJLx4p0P/u5DENNNCs7yCJSg8ufp5n3T4Pdst0 ymbnBOXziZrM8Ce+ffiXoLAXQ9tvbXBsD7dvU7vfflhkCHgLNzLkqvV3TtM/V+CJ+fI8YdMvz+I PE7DWUDYGlQbJDZb0yTKKigNGcdr2+9d7lYRrW1M77Gh1ugZcKeig6Dj9ufwl4RWl2uGKZ0CMAo UM/V8tIlsEJXCeuE3hmRzJ2aB1rTANh8l7gTCeAiCmPx4NwFkMvWAuahr8+gD2vYtOFhgqtq5d3 cxkNZqA1z3JIJT+PXJsarR+66HI3swI1e1dSQfQMmlzdh7vKgCKljLiRqI= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--19.024500-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-25028.003 X-MDID: 1573215628-wS0lHpNmloho Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/8/19 3:12 PM, Ori Kam wrote: > > Hi Andrew, > > Thanks very much for the summery, I think this makes the discussion much better. > (we even got some new folks 😊) > > I vote for B and C, > > Please read my comments below. > > Ori > >> -----Original Message----- >> From: dev On Behalf Of Zhang, Qi Z >> Sent: Friday, November 8, 2019 1:41 PM >> To: Thomas Monjalon ; Andrew Rybchenko >> >> Cc: Ori Kam ; dev@dpdk.org; >> pbhagavatula@marvell.com; Yigit, Ferruh ; >> jerinj@marvell.com; Mcnamara, John ; >> Kovacevic, Marko ; Adrien Mazarguil >> ; david.marchand@redhat.com; >> ktraynor@redhat.com; Olivier Matz >> Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as >> an offload >> >> >> >>> -----Original Message----- >>> From: dev On Behalf Of Thomas Monjalon >>> Sent: Friday, November 8, 2019 7:04 PM >>> To: Andrew Rybchenko >>> Cc: Ori Kam ; dev@dpdk.org; >>> pbhagavatula@marvell.com; Yigit, Ferruh ; >>> jerinj@marvell.com; Mcnamara, John ; >>> Kovacevic, Marko ; Adrien Mazarguil >>> ; david.marchand@redhat.com; >>> ktraynor@redhat.com; Olivier Matz >>> Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as >> an >>> offload >>> >>> 08/11/2019 11:42, Andrew Rybchenko: >>>> On 11/8/19 1:28 PM, Thomas Monjalon wrote: >>>>> 08/11/2019 09:35, Andrew Rybchenko: >>>>>> The problem: >>>>>> ~~~~~~~~~~~~ >>>>>> PMD wants to know before port start if application wants to to use >>>>>> flow MARK/FLAG in the future. It is required because: >>>>>> >>>>>> 1. HW may be configured in a different way to reserve resources >>>>>> for MARK/FLAG delivery >>>>>> >>>>>> 2. Datapath implementation choice may depend on it (e.g. vPMD >>>>>> is faster, but does not support MARK) >>>>> >>>>> Thank you for the clear problem statement. >>>>> I agree with it. This is a real design issue. >>>>> >>>>> >>>>>> Discussed solutions: >>>>>> ~~~~~~~~~~~~~~~~~~~~ >>>> >>>> May be it is not 100% clear since below are alternatives. >>>> >>>>>> A. Explicit Rx offload suggested by the patch. >>>>>> >>>>>> B. Implicit by validation of a flow rule with MARK/FLAG actions used. >>>>>> > > I don’t agree that this method is implicit it is quit explicit, do we support it in PMD > with the use case or not. Sound very explicit. You can argue that the PMD uses > validation flow to understand that it need to support MARK, but from every perspective > it is more correct . what does it mean if the application enabled mark and never download a flow? It is implicit from PMD point of view, since there is no command to enable it. The decision to enable is the result of seen attempt to validate mark. If few rules are validated, but an application decides to have it disabled finally, how to achieve it? Last validation attempt wins? Other points are covered by (6) below. >>>>>> C. Use dynamic field/flag (i.e. application registers dynamic field >>>>>> and/or flag and PMD uses lookup to solve the problem) plus part >>>>>> of (B) to discover if a feature is supported. >>>>> >>>>> The dynamic field should be registered via a new API function named >>>>> '_init'. >>>>> It means the application must explicit request the feature. >>>>> I agree this is the way to go. >>>> >>>> If I understand your statement correctly, but (C) is not ideal since >>>> it looks global. If registered dynamic field of mbuf and is flag that >>>> the feature should be enabled, it is a flag to all ports/devices. >>>> >>>>>> All solutions require changes in applications which use these >>>>>> features. There is a deprecation notice in place which advertises >>>>>> DEV_RX_OFFLOAD_FLOW_MARK addition, but may be it is OK to >>>>>> substitute it with solution (B) or (C). Solution (C) requires >>>>>> changes since it should be combined with (B) in order to understand >>>>>> if the feature is supported. >>>>> >>>>> I don't understand. >>>>> Application request and PMD support are two different things. >>>>> PMD support must be via rte_flow validation on a case by case anyway. >>>> >>>> I mean that application wants to understand if the feature is >>>> supported. Then, it wants to enable it. In the case of (B), if I >>>> understand the solution correctly, there is no explicit way to enable, >>>> PMD just detects it because of discovery is done (that's what I mean >>>> by "implicit" and it is a drawback from my point of view, but still >>>> could be considered). (C) solves the problem of (B). >>>> >>>>>> Advantages and drawbacks of solutions: >>>>>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>>>> 1. The main drawback of (A) is a "duplication" since we already >>>>>> have a way to request flow MARK using rte_flow API. >>>>>> I don't fully agree that it is a duplication, but I agree >>>>>> that it sounds like duplication and complicates a bit flow >>>>>> MARK usage by applications. (B) complicates it as well. >>>>>> >>>>>> 2. One more drawback of the solution (A) is the necessity of >>>>>> similar solution for META and it eats one more offload bit. >>>>>> Yes, that's true and I think it is not a problem. >>>>>> It would make it easier for applications to find out if >>>>>> either MARK or META is supported. >>>>>> >>>>>> 3. The main advantage of the solution (A) is simplicity. >>>>>> It is simple for application to understand if it supported. >>>>>> It is simple in PMD to understand that it is required. >>>>>> It is simple to disable it - just reconfigure. >>>>>> Also it is easier to document it - just mention that >>>>>> the offload should be supported and enabled. >>>>>> > > This is not true, for example the PMD support Mark only in Nic mode > While the application needs E-Switch then the PMD reports incorrectly. > Or for example if the mark is supported only as only action, and the application needs > decap and mark. this means that the user will never be able to use the mark > so the PMD uses slower Rx function without the mark ever being used. It is covered by (6) below. >>>>>> 4. The main advantage of the solution (B) is no "duplication". >>>>>> I agree that it is valid argument. Solving the problem >>>>>> without extra entities is always nice, but unfortunately >>>>>> it is too complex in this case. >>>>>> > > You forgot a one more very important reason, the fact that the mark > may be supported only on some flows. So if the user needs mark with decap > and this combination is not supported the user will never we able to use mark > while using mark Rx function. So you get slow data path with no ability to use it. Again, see (6) below. >>>>>> 5. The main drawback of the solution (B) is the complexity. >>>>>> It is necessary to choose a flow rule which should be used >>>>>> as a criteria. It could be hardware dependent. >>>>>> Complex logic is require in PMD if it wants to address the >>>>>> problem and control MARK delivery based on validated flow >>>>>> rules. It adds dependency between start/stop processing and >>>>>> flow rules validation code. >>>>>> It is pretty complicated to document it. >>>>>> >>>>>> 6. Useless enabling of the offload in the case of solution (A) >>>>>> if really used flow rules do not support MARK looks like >>>>>> drawback as well, but easily mitigated by a combination >>>>>> with solution (B) and only required if the application wants >>>>>> to dive in the level of optimization and complexity and >>>>>> makes sense if application knows required flow rules in >>>>>> advance. So, it is not a problem in this case. >>>>>> >>>>>> 7. Solution (C) has drawbacks of the solution (B) for >>>>>> applications to understand if these features are supported, >>>>>> but no drawbacks in PMD, since explicit criteria is used to >>>>>> enable/disable (dynamic field/flag lookup). >>>>>> >>>>>> 8. Solution (C) is nice since it avoids "duplication". >>>>>> >>>>>> 9. The main drawback of the solution (C) is asymmetry. >>>>>> As it was discussed in the case of RX_TIMESTAMP >>>>>> (if I remember it correctly): >>>>>> - PMD advertises RX_TIMESTAMP offload capability >>>>>> - application enables the offload >>>>>> - PMD registers dynamic field for timestamp >>>>>> Solution (C): >>>>>> - PMD advertises nothing >>>>>> - application uses solution (B) to understand if >>>>>> these features are supported >>>>>> - application registers dynamic field/flag >>>>>> - PMD does lookup and solve the problem >>>>>> The asymmetry could be partially mitigated if RX_TIMESTAMP >>>>>> solution is changed to require an application to register >>>>>> dynamic fields and PMD to do lookup if the offload is >>>>>> enabled. So, the only difference will be in no offload >>>>>> in the case of flow MARK/FLAG and usage of complex logic >>>>>> to understand if it is supported or no. >>>>>> May be it would be really good since it will allow to >>>>>> have dynamic fields registered before mempool population. >>>>>> >>>>>> 10. Common drawback of solutions (B) and (C) is no granularity. >>>>>> Solution (A) may be per queue while (B) and (C) cannot be >>>>>> per queue. Moreover (C) looks global - for all devices. >>>>>> It could be really painful. >>>>>> >>>>>> (C) is nice, but I still vote for simplicity and granularity of >>>>>> (A). >>>>> >>>>> I vote for clear separation of application needs and PMD support, by >>>>> using the method C (dynamic fields). >>>>> I agree timestamp must use the same path. >>>>> I agree it's complicate because we don't know in advance whether a >>>>> flow rule will be accepted, but that's the reality, config is complex. >>>> >>>> Do you think that global nature of the (C) is acceptable? >>> >>> That's a good question. >>> Maybe the feature request should be per port. >>> In this case, we are back to solution A with a flag per port? >>> >>> Note that A and C will not guarantee that the offload will be possible. >>> We need B (flow rule validation) anyway. >> >> I may not understand how solution B can works well for all the cases. >> > > That is the point of solution B it always work, it is a bit harder to use maybe, > but you can check and decide everything. > >> A rte_flow rule can be issued after dev_start, which means the rx_burst >> function is already selected at that time, >> so does that mean the driver need to switch from a non- mark offload aware >> path to a mark offload aware path without stop device? or it has to reject the >> flow? >> The question is if we have 2 data path, one support some offload , one not >> but more fast, which one should be selected during dev_start? Isn't Offload >> widely used to solve this problem? >> >> I think the option A solve all the problems, option C might also works, but A is >> looks much straightforward for me. >> > > Solution A my result in selecting incorrect datapath please see my answer above. > > As you can guess I'm in favor of B and C (C need B) > >> Regards >> Qi >> >> >>> >>> It seems A, B, C are not alternatives but all required as pieces of a puzzle... >>> >