From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5428B200 for ; Wed, 22 Nov 2017 00:58:34 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2017 15:58:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,432,1505804400"; d="scan'208";a="4995788" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.243]) ([10.241.224.243]) by orsmga003.jf.intel.com with ESMTP; 21 Nov 2017 15:58:33 -0800 To: Jingjing Wu , dev@dpdk.org Cc: wenzhuo.lu@intel.com References: <1508488012-82704-1-git-send-email-jingjing.wu@intel.com> From: Ferruh Yigit Message-ID: <83edc3b1-ca79-a401-f6da-51765663976a@intel.com> Date: Tue, 21 Nov 2017 15:58:33 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1508488012-82704-1-git-send-email-jingjing.wu@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC 0/9] add new avf PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 23:58:35 -0000 On 10/20/2017 1:26 AM, Jingjing Wu wrote: > Adaptive Virtual Function (AVF) Driver is VF driver which supports > for all future Intel devices without requiring a VM update. > It promises the basic high speed connectivity. And since this happens > to be an adaptive VF driver, every new drop of the VF driver would > add more and more advanced features that can be turned on in the VM > if the underlying HW device supports those advanced features. Most > importantly in a device agnostic way without ever compromising on the > base functionality. All the AVF's interface need to follow AVF spec, > and AVF compliant interface is supported start from the > Intel® Ethernet Controller 710 Series. This looks like a good idea. Still there will be device specific drivers, right? AVF will cover only basic features of all future Intel NICs. > > This patch set adds AVF PMD supporting. > - Device initialization > - Queue setup and Device start > - Basic Rx and Tx. > - MAC address offload feature > - Vlan offload feature > - RSS offload feature > > Which need to be done in later version > - Vectored Rx and Tx func > - Rx interrupt support > - Statistics query > - performance tuning > > Jingjing Wu (9): > net/avf/base: add base code for avf PMD > net/avf: initilization of avf PMD > net/avf: enable queue and device > net/avf: enable basic Rx Tx func > net/avf: enable link status update > net/avf: enable ops for MAC VLAN offload > net/avf: enable ops for rss setting > net/avf: enable ops to check queue info and status > net/i40e: support AVF basic interface Overall comment to whole patchset: - Missing some documentation: Driver documentation, with describing config options as well .ini file, please update it per patch that add feature release notes update to announce new PMD - There are some checkpatch warnings even except base files - Commit logs and patch titles missing details and doesn't cover all modifications in the patch. <...>