From: Ferruh Yigit <ferruh.yigit@amd.com>
To: "Morten Brørup" <mb@smartsharesystems.com>,
thomas@monjalon.net, david.marchand@redhat.com
Cc: dev@dpdk.org
Subject: Re: Where to best ack a series
Date: Fri, 23 Feb 2024 08:38:22 +0000 [thread overview]
Message-ID: <83fdf01b-afcd-41f0-9e12-81e05e7646d1@amd.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F25C@smartserver.smartshare.dk>
On 2/23/2024 8:15 AM, Morten Brørup wrote:
> Dear maintainers,
>
> Is it easier for you to spot if we ack a series in patch 0, patch 1, or the last patch of the series? Or don't you have any preferences?
>
When a patch is ack'ed, not cover letter (patch 0), patchwork detects it
and both shows it in the web interface (A/R/T), and automatically adds
it when patch applied from patchwork, so this makes life easy.
But to ack each patch in a series one by one is noise for mailing list
and overhead for reviewer. For this case I think better to ack whole
series in reply to cover letter, maintainer can apply this manually to
each patch.
When there is a patch series, but it doesn't have a cover letter, I tend
to reply to patch 1, but I don't think patch 1 or last patch matters,
only to differentiate if the ack is for that patch or whole, I am adding:
```
For series,
Acked-by: ...
```
From maintainers perspective this manually adding tags is small enough
work to ignore, but I see authors are impacted too, like if a previous
version cover letter is acked, they are not adding this ack manually to
each patch in next version, requiring reviewer ack the new version again
I guess best solution is add this series ack support to patchwork,
it can be either:
- Ack in cover letter automatically add ack to each patch in the series.
or
- Add new "Series-acked-by: " syntax, which if patchwork detects it in
any of patch in the series automatically add ack to each patch in the
series.
next prev parent reply other threads:[~2024-02-23 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 8:15 Morten Brørup
2024-02-23 8:38 ` Ferruh Yigit [this message]
2024-02-23 13:55 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fdf01b-afcd-41f0-9e12-81e05e7646d1@amd.com \
--to=ferruh.yigit@amd.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).