From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by dpdk.org (Postfix) with ESMTP id 0DC46590B; Fri, 16 Sep 2016 07:04:03 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0ODK00JDVZEPPK40@mailout4.w1.samsung.com>; Fri, 16 Sep 2016 06:04:01 +0100 (BST) Received: from eusmges2.samsung.com (unknown [203.254.199.241]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20160916050359eucas1p10e381e18bbdee95dca079bb0dd22f700~0tTpJGQ1H1430114301eucas1p1W; Fri, 16 Sep 2016 05:03:59 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2.samsung.com (EUCPMTA) with SMTP id 6D.6F.02283.F3D7BD75; Fri, 16 Sep 2016 06:03:59 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20160916050359eucas1p22998d07e190781e165082cdd9c917470~0tToUZGoJ0614906149eucas1p2z; Fri, 16 Sep 2016 05:03:59 +0000 (GMT) X-AuditID: cbfec7f1-f79f46d0000008eb-e5-57db7d3f066e Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id DD.B9.10494.F0D7BD75; Fri, 16 Sep 2016 06:03:11 +0100 (BST) Received: from [106.109.129.180] by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0ODK0090TZELTK20@eusync1.samsung.com>; Fri, 16 Sep 2016 06:03:58 +0100 (BST) To: dev@dpdk.org, Declan Doherty Cc: Heetae Ahn , Yuanhan Liu , Eric Kinzie , Bernard Iremonger , stable@dpdk.org, Dyasly Sergey From: Ilya Maximets Message-id: <83ff901c-dc74-66a9-aaf5-1e6f4afd71ed@samsung.com> Date: Fri, 16 Sep 2016 08:03:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <1473251290-22053-1-git-send-email-i.maximets@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJKsWRmVeSWpSXmKPExsWy7djP87r2tbfDDboO61hsbhS2ePOgicXi 3aftTBbzTu1lt5j2+Ta7xZX2n+wWk2dLWfzr+MNucX3CBVYHTo9fC5ayeuycdZfdY/Gel0we 804GevRtWcUYwBrFZZOSmpNZllqkb5fAldGz6CNjQYtwxdcZbWwNjFf4uxg5OSQETCT2N7Uy QthiEhfurWfrYuTiEBJYyijxd9FVFgjnM6PEwxerWWE6nn28ygyRWMYocf/kI1YI5wWjRNvL I0wgVcICXhK/32xnAbFFBKwlLqxdATaXWeAJo8Sua4vBitgEdCROrT4CtpxXwE5i+/+JQHEO DhYBVYkn80pATFGBCIndd1MhKgQlfky+BzaSU8BdYv+qD2BTmAUMJGZMOQxly0tsXvMW7DgJ gW3sEk8u3mMEmSMhICux6QAzxAMuEs9PXGSDsIUlXh3fwg5hy0hcntzNAmFXS0zc2sYOMaeF UWLhxB9Q39tLnLp5FWoZn8SkbdOZIebzSnS0CUGUeEgcvLcMar6jREt7HzRIZzFKrL/2k3EC o/wsJP/MQvLDLCQ/LGBkXsUoklpanJueWmykV5yYW1yal66XnJ+7iRGYYE7/O/5xB+P7E1aH GAU4GJV4eFfMvRUuxJpYVlyZe4hRgoNZSYQ3pOp2uBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHe PQuuhAsJpCeWpGanphakFsFkmTg4pRoY+dT97iqb5ARnRM+bwLB23c8aQ3eJ/I7DK4W2Nnua zZapz1bb86PgVVxJyWemWq4VvG0KX7N7u1fP8XV+n6bgWJs1P09vyrJ51XlBOQeTpne9llre MlP+luvtsM65/GG28swbTktxbw3JSuUquvZb7+xbqbVTHE59czCovL2J5Vpl2DUv2XlKLMUZ iYZazEXFiQBJZBDGLAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGIsWRmVeSWpSXmKPExsVy+t/xy7r8tbfDDR5PU7TY3Chs8eZBE4vF u0/bmSzmndrLbjHt8212iyvtP9ktJs+WsvjX8Yfd4vqEC6wOnB6/Fixl9dg56y67x+I9L5k8 5p0M9OjbsooxgDXKzSYjNTEltUghNS85PyUzL91WKTTETddCSSEvMTfVVilC1zckSEmhLDGn FMgzMkADDs4B7sFK+nYJbhk9iz4yFrQIV3yd0cbWwHiFv4uRk0NCwETi2cerzBC2mMSFe+vZ uhi5OIQEljBK3Ll5kB3CecEosWb/MbAqYQEvid9vtrOA2CIC1hIX1q4A6uAAKnKT+L84BKSe WeAJo8SRBxOYQGrYBHQkTq0+wghi8wrYSWz/P5EJpJ5FQFXiybwSkLCoQITErVUfoUoEJX5M vgc2nlPAXWL/qg9g5cwCehL3L2qBhJkF5CU2r3nLPIFRYBaSjlkIVbOQVC1gZF7FKJJaWpyb nltspFecmFtcmpeul5yfu4kRGGfbjv3csoOx613wIUYBDkYlHt4Vc2+FC7EmlhVX5h5ilOBg VhLhDam6HS7Em5JYWZValB9fVJqTWnyI0RTog4nMUqLJ+cAUkFcSb2hiaG5paGRsYWFuZKQk zjv1w5VwIYH0xJLU7NTUgtQimD4mDk6pBsZ1zbVBbYrvW8/M0mUvDJ2kw/inIfi687V18S5v 06wuVal53uHxOPJS+9SaNeEG4glLtr5Y/ULz9oX/Nb0JdVc/2QbJs/zMPrzm9sKQaomij9Ku WnIu1yfLf5q3r2t2YPym3ZIL5+WYyGt6MnrsKzE3yXH9nibonR2S8Oex44vJzUab3tb7aiix FGckGmoxFxUnAgAXMml8yQIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20160916050359eucas1p22998d07e190781e165082cdd9c917470 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?SWx5YSBNYXhpbWV0cxtTUlItVmlydHVhbGl6YXRpb24gTGFi?= =?UTF-8?B?G+yCvOyEseyghOyekBtFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?SWx5YSBNYXhpbWV0cxtTUlItVmlydHVhbGl6YXRpb24gTGFi?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0NJU0hRG0MxMEdEMDFHRDAxMDE1NA==?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20160916050359eucas1p22998d07e190781e165082cdd9c917470 X-RootMTR: 20160916050359eucas1p22998d07e190781e165082cdd9c917470 References: <1473251290-22053-1-git-send-email-i.maximets@samsung.com> Subject: Re: [dpdk-dev] [PATCH] Revert "bonding: use existing enslaved device queues" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2016 05:04:03 -0000 Ping. Best regards, Ilya Maximets. On 07.09.2016 15:28, Ilya Maximets wrote: > This reverts commit 5b7bb2bda5519b7800f814df64d4e015282140e5. > > It is necessary to reconfigure all queues every time because configuration > can be changed. > > For example, if we're reconfiguring bonding device with new memory pool, > already configured queues will still use the old one. And if the old > mempool be freed, application likely will panic in attempt to use > freed mempool. > > This happens when we use the bonding device with OVS 2.6 while MTU > reconfiguration: > > PANIC in rte_mempool_get_ops(): > assert "(ops_index >= 0) && (ops_index < RTE_MEMPOOL_MAX_OPS_IDX)" failed > > Cc: > Signed-off-by: Ilya Maximets > --- > drivers/net/bonding/rte_eth_bond_pmd.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index b20a272..eb5b6d1 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -1305,8 +1305,6 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, > struct bond_rx_queue *bd_rx_q; > struct bond_tx_queue *bd_tx_q; > > - uint16_t old_nb_tx_queues = slave_eth_dev->data->nb_tx_queues; > - uint16_t old_nb_rx_queues = slave_eth_dev->data->nb_rx_queues; > int errval; > uint16_t q_id; > > @@ -1347,9 +1345,7 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, > } > > /* Setup Rx Queues */ > - /* Use existing queues, if any */ > - for (q_id = old_nb_rx_queues; > - q_id < bonded_eth_dev->data->nb_rx_queues; q_id++) { > + for (q_id = 0; q_id < bonded_eth_dev->data->nb_rx_queues; q_id++) { > bd_rx_q = (struct bond_rx_queue *)bonded_eth_dev->data->rx_queues[q_id]; > > errval = rte_eth_rx_queue_setup(slave_eth_dev->data->port_id, q_id, > @@ -1365,9 +1361,7 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, > } > > /* Setup Tx Queues */ > - /* Use existing queues, if any */ > - for (q_id = old_nb_tx_queues; > - q_id < bonded_eth_dev->data->nb_tx_queues; q_id++) { > + for (q_id = 0; q_id < bonded_eth_dev->data->nb_tx_queues; q_id++) { > bd_tx_q = (struct bond_tx_queue *)bonded_eth_dev->data->tx_queues[q_id]; > > errval = rte_eth_tx_queue_setup(slave_eth_dev->data->port_id, q_id, >