From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0980A0C47; Tue, 12 Oct 2021 10:50:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BAE2E40E0F; Tue, 12 Oct 2021 10:50:34 +0200 (CEST) Received: from mail-108-mta83.mxroute.com (mail-108-mta83.mxroute.com [136.175.108.83]) by mails.dpdk.org (Postfix) with ESMTP id 9C93D40151 for ; Tue, 12 Oct 2021 10:50:33 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta83.mxroute.com (ZoneMTA) with ESMTPSA id 17c73b22bac0000b55.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 12 Oct 2021 08:50:28 +0000 X-Zone-Loop: 0d9c31f4abdf5afadeb90815bcfd86e7467204320dc9 X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=P6BS9Hun9NB0vfpH9V90tUHS2iPn0Zr9wBxTgIz3Nmc=; b=QzLqbhb2qAtr5UO7XvjVqmh6YQ wBMA8+ve7CbQvyklvnO76pz+b6TKd16EneLcqgW2XRNeArQ/fsil7V2ekxhlV7B8BG6eLalD1CpmE B0rSt1+EdGG21mdjih8Ze39vDNM3kebbK1MfYQmlSGfIls5g0qXvwjHKvcSL5pURyySZGSQgSgIPC bjjkkfdTiJpeI/Y5oShGvrAT7Yj/bHd3EyUBAwS2/2lBD2UGflNrboPNX0f1TDsBkFwujAOyAEHVv d4CI4l2Zm8tpWMSUU3tfNVIamB+4PYc6MnWWkJDmH/WY7as/9Xaur//Iehd2TkJtDNlw+B0y41nRU MWOLTjxw==; To: dev@dpdk.org References: <20210731181327.660296-1-gakhil@marvell.com> <20211008204516.3497060-1-gakhil@marvell.com> <20211008204516.3497060-3-gakhil@marvell.com> From: "Kinsella, Ray" Message-ID: <8405f4af-cd86-e385-f3d7-175ffeb65593@ashroe.eu> Date: Tue, 12 Oct 2021 09:50:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211008204516.3497060-3-gakhil@marvell.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu X-Zone-Spam-Resolution: no action X-Zone-Spam-Status: No, score=-0.1, required=15, tests=[ARC_NA=0, NEURAL_SPAM=0, FROM_HAS_DN=0, MIME_GOOD=-0.1, FROM_EQ_ENVFROM=0, MIME_TRACE=0, RCVD_COUNT_ZERO=0, RCPT_COUNT_ONE=0, MID_RHS_MATCH_FROM=0, TO_DN_NONE=0] Subject: Re: [dpdk-dev] [PATCH v2 3/3] security: add reserved bitfields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08/10/2021 21:45, Akhil Goyal wrote: > In struct rte_security_ipsec_sa_options, for every new option > added, there is an ABI breakage, to avoid, a reserved_opts > bitfield is added to for the remaining bits available in the > structure. > Now for every new sa option, these reserved_opts can be reduced > and new option can be added. > > Signed-off-by: Akhil Goyal > Acked-by: Konstantin Ananyev > --- > v2: rebase and removed libabigail.abignore change. > Exception may be added when there is a need for change. > > lib/security/rte_security.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h > index 7eb9f109ae..c0ea13892e 100644 > --- a/lib/security/rte_security.h > +++ b/lib/security/rte_security.h > @@ -258,6 +258,12 @@ struct rte_security_ipsec_sa_options { > * PKT_TX_UDP_CKSUM or PKT_TX_L4_MASK in mbuf. > */ > uint32_t l4_csum_enable : 1; > + > + /** Reserved bit fields for future extension > + * > + * Note: reduce number of bits in reserved_opts for every new option > + */ > + uint32_t reserved_opts : 18; > }; > > /** IPSec security association direction */ > Acked-by: Ray Kinsella