From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A3763324E for <dev@dpdk.org>; Wed, 21 Jun 2017 09:57:19 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3EAE8209EF; Wed, 21 Jun 2017 03:57:19 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 21 Jun 2017 03:57:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=GdSkzwVOlDkpIDQ X7Of8j85O6ZT3QGUTcBJDB8Es5Ko=; b=ZimhVm/ePOtu7/r+1dzTsdCIldGcpFt +tNC8xjTR75vYaTTHQCcFNKJ04L/UyUjrJtPxKUkOrFXDlxH64ioqmVB++9exmZo wRzk9BS7MWdp3zGnhPVokApXMCJUEWS5xLc4Fj+mdNf+pzIEwUQd5NqYQVviTcvV V2PkCxVEa7oY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=GdSkzwVOlDkpIDQX7Of8j85O6ZT3QGUTcBJDB8Es5Ko=; b=nfuHEjAM 9YCBU+TmaKS7AsiGwTGrM4GiS6pHVOdmgc74b22y/Y2X6W9g9XKcIMdNYNlLzSrd EihUgDPw+4pY9evbfDNudenVJJVl7/sqRLIwDi1UG1l6bsGjo/T3ayDCr0Udr+qI 7y8lO8RNoXtb9bAmafuEFcpUS7WzEBNiJOc6ydsf9GGzfhN03Js1MLw/7KRpsI1c A/x/+DEr0rJhLrz/vKQsdgR+6kVsgU034kiUNnQ7HZWYYNKP3I08xa9fq9ithPpd iggzsGM2QwQ+AARaVQrpyqfbqVD9Eb16uS1R8GPumnDvlMn0eM+nnwWM0zLYeq/o WSbNy73BYnqzgw== X-ME-Sender: <xms:3yZKWdLx1dWm6qpXhybkqiSr34pZGiyvjKezHSgjv95WO65IJa-69Q> X-Sasl-enc: eCOpfvmiOq+OyNOTjbG9Mj6oxyYsNm5dVGwk7f0mCCuW 1498031838 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EB1A67E74F; Wed, 21 Jun 2017 03:57:18 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Gaetan Rivet <gaetan.rivet@6wind.com> Cc: dev@dpdk.org Date: Wed, 21 Jun 2017 09:57:18 +0200 Message-ID: <8418992.7tWpiUoDtu@xps> In-Reply-To: <78a1d2393d08ec3152f01be35d29401447ce616f.1497999952.git.gaetan.rivet@6wind.com> References: <cover.1496877060.git.gaetan.rivet@6wind.com> <cover.1497999952.git.gaetan.rivet@6wind.com> <78a1d2393d08ec3152f01be35d29401447ce616f.1497999952.git.gaetan.rivet@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 5/9] pmdinfogen: move to drivers subdirectory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 21 Jun 2017 07:57:20 -0000 21/06/2017 01:36, Gaetan Rivet: > pmdinfogen has a dependency on the PCI bus. The latter must be built > first. I think it should not be moved outside of buildtools. The build order can be fixed by installing headers before any compilation like proposed in this RFC: http://dpdk.org/patch/25463 Another (probably better) solution is to keep basic definitions and helpers in EAL: - rte_pci.h keeps only some PCI definitions and helpers like rte_pci_addr and eal_parse_pci_BDF() in EAL - bus management is done in the PCI driver For pmdinfogen, we just need struct rte_pci_id. Other tools or applications will probably need this kind of basic struct and functions available in EAL.