From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com
 [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 7A8EA5A45
 for <dev@dpdk.org>; Sun,  9 Aug 2015 11:55:37 +0200 (CEST)
Received: by wibxm9 with SMTP id xm9so114833332wib.1
 for <dev@dpdk.org>; Sun, 09 Aug 2015 02:55:37 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=MwRqIipUkj/cRLtcLaZHTC82VzJ9KMC8g8L/OwZmZh4=;
 b=k/X8OJ9rs3j6dyt2ZrwiHWUNb7UzaNfEh/CfwauXxRwslEF0lfVTXZvqaClSTbI9HO
 iSNn35cVxt3IEfZqs/leJ02/CMs9aUWZYtduAxFfRsKYxrksIYAUFk63n2YBAKciKvSS
 6wibBkkvLqbjh1C4cFASCmVnw6hO+9ZDqI4sdblih4+Ez2JDeYCZIY03zQGwpiFKPbW2
 rzt5zFzKH8PYjjc8f3VoEgijvGA3L4mEkc8hnWFTB2BemF5CvZqvJ1gnVzoM/eGH0Bpg
 HkPcCyp6rlPieeZFkrP9KtW8QCQfZLzuq8eSmsnDzB4IiWFFj77g/btklLJ4M4s3Agmj
 WjUw==
X-Gm-Message-State: ALoCoQmFyMaphZlO6Z1ZobJp4J1fSpHnRJn8zXyfJgGnyVr8DhaO2yNhNnSA0mOzWfAhBLodss2V
X-Received: by 10.180.97.129 with SMTP id ea1mr14595408wib.24.1439114137275;
 Sun, 09 Aug 2015 02:55:37 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id x6sm7928375wiy.6.2015.08.09.02.55.35
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 09 Aug 2015 02:55:36 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Date: Sun, 09 Aug 2015 11:54:22 +0200
Message-ID: <8423022.rae0ANLxGt@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1438938514-10304-1-git-send-email-pablo.de.lara.guarch@intel.com>
References: <1438938514-10304-1-git-send-email-pablo.de.lara.guarch@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix compilation issue when
	using exact-match
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Aug 2015 09:55:37 -0000

Hi Pablo,

2015-08-07 10:08, Pablo de Lara:
> L3fwd was trying to use an inexistent function "simple_ipv6_fwd_4pkts",
> instead it should be "simple_ipv6_fwd_8pkts".
> 
> Fixes: 80fcb4d4 ("examples/l3fwd: increase lookup burst size to 8")

There are 3 things wrong here.

1/ We must absolutely avoid compile-time paths:
	#if (ENABLE_MULTI_BUFFER_OPTIMIZE == 1)                                                                          
	#if (APP_LOOKUP_METHOD == APP_LOOKUP_EXACT_MATCH)
It makes test coverage too hard to track.

2/ When replacing a function, grepping it is a must have.
-simple_ipv6_fwd_4pkts(struct rte_mbuf* m[4], uint8_t portid, struct lcore_conf *qconf)
+simple_ipv6_fwd_8pkts(struct rte_mbuf *m[8], uint8_t portid, struct lcore_conf *qconf)
So this change would be straight forward:
> -						simple_ipv6_fwd_4pkts(&pkts_burst[j],
> +						simple_ipv6_fwd_8pkts(&pkts_burst[j],

3/ The above commit makes also this wrong replacement:
-                                               simple_ipv4_fwd_4pkts(&pkts_burst[j],
+                                               simple_ipv8_fwd_4pkts(&pkts_burst[j],
It is still not fixed.

Please send a v2 for this last typo. Thanks