From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 7191B91; Sun, 18 Nov 2018 22:56:44 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F09A420F6F; Sun, 18 Nov 2018 16:56:43 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 18 Nov 2018 16:56:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=k21mPOcQIfce26HCO3ah00Jl8Jzd6LUHrR0JEpAxEzI=; b=b1pbXMnhu1AU 84TihluNLeSEBTEY4bOaICYipoSezS6UMpQbpok/ivdAPZvizjQWT7sTpGzug1p4 MBM2r6NWBNHZ80c+vtN4BP1/HcN4glQxAO3injA9eIoEqJC233m7lI66xnm2Kvuv CBqeo01Q2DyD6CjTlSKeUguFIDAsg/Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=k21mPOcQIfce26HCO3ah00Jl8Jzd6LUHrR0JEpAxE zI=; b=bWWKgC6BjHPbeAX1DxpssD00fPDTSdftiIwGJ0BuH+ebSJgtAN/0JzXG0 yGd6nlMAiD4MflduMfraTT5FqmY+WLIFACJiTEWqwMB+35Yc3RmtFygMXt8uRFXo iE0cpg/Ct2F4eSVr7fXs6CANCUumTKU4CJCQUzFR/ts9OKY9f0hq4w7KIxnCEOQ9 snR2OaSVkoH3dsd5jZqZ6UqQjtKTQdhhcQKyfdNgOr0x/F4V7nXmLbtzWjqBx3ZS lQHM5CRML/knUaB3bjX0Fz/cLMIvW6r/VQ+/PLhZbfX8E/bkaicNhIjxkbqoTycT wn/d+q4LuWt9KGNqZdAFSh9sWBzEQ== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C2D0C102F0; Sun, 18 Nov 2018 16:56:42 -0500 (EST) From: Thomas Monjalon To: "Lipiec, Herakliusz" Cc: stable@dpdk.org, "Wang, Dong1" , "Ananyev, Konstantin" , "dev@dpdk.org" , "Burakov, Anatoly" Date: Sun, 18 Nov 2018 22:56:41 +0100 Message-ID: <8430826.3j7pgKI0Cq@xps> In-Reply-To: <3E2E5017C928014B90FD7864A64F0B5514F7505D@SHSMSX103.ccr.corp.intel.com> References: <20181112204650.7175-1-herakliusz.lipiec@intel.com> <2601191342CEEE43887BDE71AB977258010CE49D0D@IRSMSX106.ger.corp.intel.com> <3E2E5017C928014B90FD7864A64F0B5514F7505D@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] example/ipv4_multicast: fix app hanging when using clone X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2018 21:56:44 -0000 > > The ipv4_multicast sample application was dropping packets when using > > mbuf clone. When creating an L2 header and copying metadata from the > > source packet, the ol_flags were also copied along with all the other > > metadata. Because the cloned packet had IND_ATTACHED_MBUF flag set in > > its ol_flags, this caused the packets to never be freed when using > > rte_pktmbuf_free. > > Since copying ol_flags from the cloned packet is not necessary in the > > first place, just don't do it. > > > > Fixes: af75078fece3 ("first public release") > > CC: stable@dpdk.org > > > > Reported-by: Wang Dong > > Signed-off-by: Herakliusz Lipiec > > Acked-by: Konstantin Ananyev > Acked-by: Wang Dong Applied, thanks