From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 77C25559A for ; Wed, 7 Sep 2016 18:00:38 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id b187so123762439wme.1 for ; Wed, 07 Sep 2016 09:00:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=cQ9LWI6X6kNs2sx197H8W42rDn/OoKGXYSHpu9CbMCk=; b=muG1+XMABsXZQPR1p4pb8yJzT77/IAQZs101D1HG7rqIP0xY/9QDk9P3uhUOutzeRU CJkL+pc+YVE99SRQqEyhSDG4lwe6tu/T/BR9N5IeM6LQ+WvZi3T2aAqwqaBbXLobNEkW oR27elhmOdcpP8bmOvjYiMHChz2KsCtYHrbU84NFkv+WE/YcchkUFoIPrsVZK6HGmpVy xooRJ8JgAtc0LdcQQIfDDhzb5U1ZfE/xuCbNRpUKKdjZGKfw1E4/QaJSelO72PB3eElZ Xhn1feFhcdb6njt7RDrlrQvvzLNCaOEmdxnz149r4Ew8lds1W1t6Ay7L9QmEkIrxKYIO ahCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=cQ9LWI6X6kNs2sx197H8W42rDn/OoKGXYSHpu9CbMCk=; b=f6VgtS/WQDSx+mgOD6QR7rrWykEf5qUvakdFcpgx3KddmwKTCGliEgMw2yLsRVMP7B H6Y3itwyQZdH2ptfmWlJqSARQfTG08DY9IvtHD7GQnJWOlOdaX7Otf+cO65iW1Ztds4Q M8Nd58r8AuyRfCHdeuk9a0Mc/uRtnxeNlaWorXN5SgqRnE/zpuN3EANBicRxNBgea+p+ h6xX0Kghs1hbMlz+BNSjMVlYhb5hDDCbVjJXV5VBkivSjHR96GraZ2Km4NLKCVWk648m QOJtCBu5Asp9XZDd1y/OaPlo1/3yLeNsWEoLlVBn3IGfLtSQeLdpSAqbKU+WNKljpcLh D+DA== X-Gm-Message-State: AE9vXwMLsr1MrK5K9dOYqFOeD79boC2HHPJ+rQQsajySPu1RuWZ9lRZso1SGwidwtzEZul+A X-Received: by 10.194.5.202 with SMTP id u10mr2453679wju.149.1473264038177; Wed, 07 Sep 2016 09:00:38 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id ce6sm39579354wjc.27.2016.09.07.09.00.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Sep 2016 09:00:37 -0700 (PDT) From: Thomas Monjalon To: Yuanhan Liu Cc: dev@dpdk.org, "Xu, Qian Q" , Maxime Coquelin Date: Wed, 07 Sep 2016 18:00:36 +0200 Message-ID: <8433603.OGYCHmGCI2@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160906095548.GB23158@yliu-dev.sh.intel.com> References: <1471939839-29778-1-git-send-email-yuanhan.liu@linux.intel.com> <82F45D86ADE5454A95A89742C8D1410E3912C500@shsmsx102.ccr.corp.intel.com> <20160906095548.GB23158@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 5/6] vhost: add a flag to enable Tx zero copy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2016 16:00:38 -0000 2016-09-06 17:55, Yuanhan Liu: > On Tue, Sep 06, 2016 at 09:00:14AM +0000, Xu, Qian Q wrote: > > Just curious about the naming: vhost USER TX Zero copy. In fact, it's Vhost RX zero-copy > > For virtio, it's Virtio TX zero-copy. So, I wonder why we call it as Vhost TX ZERO-COPY, > > Any comments? > > It's just that "Tx zero copy" looks more nature to me (yes, I took the > name from the virtio point of view). > > Besides that, naming it to "vhost Rx zero copy" would be a little > weird, based on we have functions like "virtio_dev_rx" in the enqueue > path while here we just touch dequeue path. > > OTOH, I seldome say "vhost-user Tx zero copy"; I normally mention it > as "Tx zero copy", without mentioning "vhost-user". For the flag > RTE_VHOST_USER_TX_ZERO_COPY, all vhost-user flags start with "RTE_VHOST_USER_" > prefix. I agree that the naming in vhost code is quite confusing. It would be better to define a terminology and stop mixing virtio/vhost directions as well as Rx/Tx and enqueue/dequeue. Or at least, it should be documented.