From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0187DA04B5; Thu, 29 Oct 2020 09:28:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4067DBE4F; Thu, 29 Oct 2020 09:28:02 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id B186ABE4B for ; Thu, 29 Oct 2020 09:27:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603960078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zs06mmbLVXTzf+rFrQMrODHe9gubNNiAf8Y3lbT3Fwo=; b=cLloxawmOXP+ztEMaqQumXN6QuaOOqBiEn4CuRGM3hjvHnQfttqRlS4A2lZpVThQ4DD6jz dbiOqMojV4FoEcj2eb6hsbVVtF0ubl94XrDj27ghDdr0ygQB27jI1t0LBGA7u5xwMja6Tl gJZA7CFkYLsfqkBzIBH2rw2r4tAhWm4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-440-x4klcByIMI2IO3MBZOoQog-1; Thu, 29 Oct 2020 04:27:54 -0400 X-MC-Unique: x4klcByIMI2IO3MBZOoQog-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2425F835B5D; Thu, 29 Oct 2020 08:27:53 +0000 (UTC) Received: from [10.36.110.11] (unknown [10.36.110.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 564BD5B4CC; Thu, 29 Oct 2020 08:27:49 +0000 (UTC) To: Adrian Moreno , dev@dpdk.org Cc: yinan.wang@intel.com, patrick.fu@intel.com, chenbo.xia@intel.com, zhihong.wang@intel.com References: <20201026163930.94032-1-amorenoz@redhat.com> From: Maxime Coquelin Message-ID: <84399a90-2203-ab5a-f09a-483041471f4e@redhat.com> Date: Thu, 29 Oct 2020 09:27:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201026163930.94032-1-amorenoz@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 0/6] net/virtio-user: fix server mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/26/20 5:39 PM, Adrian Moreno wrote: > A number of issues have been detected that currently break virtio-user > server mode. > This series addresses such issues. > Note that virtio-user server mode is broken by design and many of the > problems that it currently has should be fixed by a bigger rework. > > -- > v2->v3: > Fix potential concurrency problem on get/set state > Handle STATUS protocol feature flag > Fix undefined behaviour if STATUS feature is not supported > Ensure packed virtqueues are reset on reconnection > > > v1->v2: > Added patch 2 and 3 addressing additional issues > Check errno to select vhost-user backend and log the detected backend > type > > Adrian Moreno (6): > net/virtio-user: fix backend selection if stat fails > net/virtio-user: don't set/get_status until FEATURES_OK > net/virtio-user: ignore result if STATUS is unsupported > net/virtio-user: lock-protect status updates > net/virtio-user: don't assume vhost status feature > net/virtio-user: set status on socket reconnect > > drivers/net/virtio/virtio_user/vhost_user.c | 14 ++--- > .../net/virtio/virtio_user/virtio_user_dev.c | 53 +++++++++++++------ > .../net/virtio/virtio_user/virtio_user_dev.h | 5 +- > drivers/net/virtio/virtio_user_ethdev.c | 40 ++++++++++---- > 4 files changed, 78 insertions(+), 34 deletions(-) > Applied to dpdk-next-virtio/main. Thanks! Maxime