From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AAE3A09E9; Mon, 14 Dec 2020 21:35:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 65224C876; Mon, 14 Dec 2020 21:35:37 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C4F6A29AC; Mon, 14 Dec 2020 21:35:34 +0100 (CET) IronPort-SDR: 02F9y1EgSYPwPAwiQ72IgKiA6Z/8MemPWTU7g8NdswHijgnzDQPz7RI38swb+uWE5elIniAVCw SxGHFxxFwAFQ== X-IronPort-AV: E=McAfee;i="6000,8403,9834"; a="193140065" X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="193140065" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 12:35:31 -0800 IronPort-SDR: xSmpMNKEgZ42FdGCmI5ebZv0JIa2TItzLi/EepjHX3X5wup9BhTwrB2XQWrwc1sn1V+2DLWUZB xulwsq3RRbCw== X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="334210800" Received: from rmenon-desk.amr.corp.intel.com (HELO [10.166.30.253]) ([10.166.30.253]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 12:35:31 -0800 To: Tal Shnaiderman , dev@dpdk.org Cc: thomas@monjalon.net, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, odia@nvidia.com, stable@dpdk.org References: <20201213141604.12560-1-talshn@nvidia.com> From: Ranjit Menon Message-ID: <843a7bc6-d14e-1b90-e632-95b1728a21ab@intel.com> Date: Mon, 14 Dec 2020 12:35:30 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201213141604.12560-1-talshn@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] pci/windows: do not fail on missing NUMA node for PCIe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/13/2020 6:16 AM, Tal Shnaiderman wrote: > On older processors, NUMA isn't bound to PCIe locality. > those cases return ERROR_NOT_FOUND in response to the > SetupDiGetDevicePropertyW call with DEVPKEY_Device_Numa_Node > attribute. > > This error fails the probe process for the PCIe device. > this commit will ignore such failure and will set the > numa_node to 0. > > Fixes: b762221ac24f ("bus/pci: support Windows with bifurcated drivers") > Cc: stable@dpdk.org > > Reported-by: Odi Assli > Signed-off-by: Tal Shnaiderman > --- > drivers/bus/pci/windows/pci.c | 9 +++++++++ > 1 file changed, 9 insertions(+) Acked-by: Ranjit Menon