From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 2038E2C60; Mon, 25 Mar 2019 09:55:45 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 9E968340069; Mon, 25 Mar 2019 08:55:43 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 25 Mar 2019 08:55:36 +0000 To: David Marchand , CC: , , , , , , References: <1553261824-1881-1-git-send-email-david.marchand@redhat.com> <1553503906-1508-1-git-send-email-david.marchand@redhat.com> <1553503906-1508-2-git-send-email-david.marchand@redhat.com> From: Andrew Rybchenko Message-ID: <84450bfa-3208-93eb-ee9d-54decfd59056@solarflare.com> Date: Mon, 25 Mar 2019 11:55:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1553503906-1508-2-git-send-email-david.marchand@redhat.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24510.003 X-TM-AS-Result: No-5.942500-8.000000-10 X-TMASE-MatchedRID: scwq2vQP8OF2LasmHuCXMSa1MaKuob8PC/ExpXrHizyzrjcceM7LC7p6 uNXZtNFnGiHcq0WQFE41fwTgey9c4l7FwpET+YHov1vPAPz22Flgp5U7towQcweLCIX046iBSrJ TO1VGhMF2+AZuxakJy89fuxSQqqSyyA1ihY42R28vj6wHfIGxyQhRCJFb9cuspEal45ZfbAiw6j rE46eRK84ffyU1s6hMXEjZllf2bhffX2sZfyOJoZ4CIKY/Hg3AtOt1ofVlaoLUHQeTVDUrItRnE QCUU+jzJYLeEO7UasiEXSfadLsl9km2AehA6zclFEtKZMUf1zDRAzHS/yLS/VXM1ygSuElpzwx3 5PqZISg+bTMyqjZSFW/SQhGHP2qXJTUUVTTLjl5OnEs0yteowEnqn7s9lXBzcc1NCoV2vxbhYV0 jrNRr1VaY0L5lhKjZXQIMGIsvKtwPShC56bfmG3YUcq5CNBS2L9rGURcq4/c= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.942500-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24510.003 X-MDID: 1553504144-D64fjtIObteH Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v5 1/4] app/testpmd: add missing newline when showing statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2019 08:55:45 -0000 On 3/25/19 11:51 AM, David Marchand wrote: > Having the standard stats and the rx burst stats on the same line gives a > really long line and is not consistent with the rest. > > Before: > iofwd engine > RX-packets: 121811360 TX-packets: 121811392 TX-dropped: 0 RX-bursts : 3806605 [100% of 32 pkts] > TX-bursts : 3806606 [100% of 32 pkts] > > csum engine > RX-packets: 5467488 TX-packets: 5467520 TX-dropped: 0 RX- bad IP checksum: 0 Rx- bad L4 checksum: 0 Rx- bad outer L4 checksum: 0 > RX-bursts : 170859 [100% of 32 pkts] > TX-bursts : 170860 [100% of 32 pkts] > > After: > iofwd engine > RX-packets: 259770560 TX-packets: 259770592 TX-dropped: 0 > RX-bursts : 8117830 [100% of 32 pkts] > TX-bursts : 8117831 [100% of 32 pkts] > > csum engine > RX-packets: 7834016 TX-packets: 7834048 TX-dropped: 0 RX- bad IP checksum: 0 Rx- bad L4 checksum: 0 Rx- bad outer L4 checksum: 0 > RX-bursts : 244813 [100% of 32 pkts] > TX-bursts : 244814 [100% of 32 pkts] > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 80591A05D3 for ; Mon, 25 Mar 2019 09:55:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2FBA23576; Mon, 25 Mar 2019 09:55:47 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 2038E2C60; Mon, 25 Mar 2019 09:55:45 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 9E968340069; Mon, 25 Mar 2019 08:55:43 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 25 Mar 2019 08:55:36 +0000 To: David Marchand , CC: , , , , , , References: <1553261824-1881-1-git-send-email-david.marchand@redhat.com> <1553503906-1508-1-git-send-email-david.marchand@redhat.com> <1553503906-1508-2-git-send-email-david.marchand@redhat.com> From: Andrew Rybchenko Message-ID: <84450bfa-3208-93eb-ee9d-54decfd59056@solarflare.com> Date: Mon, 25 Mar 2019 11:55:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1553503906-1508-2-git-send-email-david.marchand@redhat.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24510.003 X-TM-AS-Result: No-5.942500-8.000000-10 X-TMASE-MatchedRID: scwq2vQP8OF2LasmHuCXMSa1MaKuob8PC/ExpXrHizyzrjcceM7LC7p6 uNXZtNFnGiHcq0WQFE41fwTgey9c4l7FwpET+YHov1vPAPz22Flgp5U7towQcweLCIX046iBSrJ TO1VGhMF2+AZuxakJy89fuxSQqqSyyA1ihY42R28vj6wHfIGxyQhRCJFb9cuspEal45ZfbAiw6j rE46eRK84ffyU1s6hMXEjZllf2bhffX2sZfyOJoZ4CIKY/Hg3AtOt1ofVlaoLUHQeTVDUrItRnE QCUU+jzJYLeEO7UasiEXSfadLsl9km2AehA6zclFEtKZMUf1zDRAzHS/yLS/VXM1ygSuElpzwx3 5PqZISg+bTMyqjZSFW/SQhGHP2qXJTUUVTTLjl5OnEs0yteowEnqn7s9lXBzcc1NCoV2vxbhYV0 jrNRr1VaY0L5lhKjZXQIMGIsvKtwPShC56bfmG3YUcq5CNBS2L9rGURcq4/c= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.942500-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24510.003 X-MDID: 1553504144-D64fjtIObteH Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v5 1/4] app/testpmd: add missing newline when showing statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190325085533.rCckZA_SUwh-jjP4qvlHsCsuQxg6zDv07V5CXLDTJo0@z> On 3/25/19 11:51 AM, David Marchand wrote: > Having the standard stats and the rx burst stats on the same line gives a > really long line and is not consistent with the rest. > > Before: > iofwd engine > RX-packets: 121811360 TX-packets: 121811392 TX-dropped: 0 RX-bursts : 3806605 [100% of 32 pkts] > TX-bursts : 3806606 [100% of 32 pkts] > > csum engine > RX-packets: 5467488 TX-packets: 5467520 TX-dropped: 0 RX- bad IP checksum: 0 Rx- bad L4 checksum: 0 Rx- bad outer L4 checksum: 0 > RX-bursts : 170859 [100% of 32 pkts] > TX-bursts : 170860 [100% of 32 pkts] > > After: > iofwd engine > RX-packets: 259770560 TX-packets: 259770592 TX-dropped: 0 > RX-bursts : 8117830 [100% of 32 pkts] > TX-bursts : 8117831 [100% of 32 pkts] > > csum engine > RX-packets: 7834016 TX-packets: 7834048 TX-dropped: 0 RX- bad IP checksum: 0 Rx- bad L4 checksum: 0 Rx- bad outer L4 checksum: 0 > RX-bursts : 244813 [100% of 32 pkts] > TX-bursts : 244814 [100% of 32 pkts] > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko