From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AEB942CFB; Mon, 19 Jun 2023 17:46:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAEC740E0F; Mon, 19 Jun 2023 17:46:08 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2088.outbound.protection.outlook.com [40.107.102.88]) by mails.dpdk.org (Postfix) with ESMTP id 5342140DF8 for ; Mon, 19 Jun 2023 17:46:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UOObuCJytuBwCGdw2sYv6JvgYEkj9/1cMj6jcHD2o4cwB5n8WZftB03VaDUqZvURjRxsmdnzXpKyCzxAFxC7QYw5WBClKuRaudQpg8UVR+/s+A6Ot0QE0pDidGVUJhRxedNtKkY2IvWLk3wfNN7eJO7+uireRS7mIg6gpXWv0rLepO8Aqu7qwec5vbUJF48d4idRzheNEYcbA7J+t1+NkF+Q5oQmyt2oxda6ZhT53rp673nDb/Svr8kFfc1SfCm04SqzD3Vr7fjXMTO6PXYwta4xIDhYuAzQNVaZhH9h+49KYNRQbk1XonXazXCfquGu4IU7LY9oVJHlWD0J7aoRjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6uMEmdMfVlqm5rU5PnUE2LtgpglU0E0PvFsSbZ1O1JY=; b=SAaEj0ozojhaczt78NfKka8Uxtw+VL4vWff38YhNalGOpk2JTFqcFLuk9LkoyXf9cyCaJXOUBaJ3F+ndm+g7rPFScHOXF9H+045QVZogrTykMYKXBtMF9sVNiHSAR7xZxth3hnMAfiKUjfG+4Od7tLT4fA1G+qaXbtfiEFEzmFEDp79UUK926lgZRlt4rqhWn/prGPsxkQfB3WDTFpCQgLRoO9eVg0EVYGuCtL/Ws1yNX52vePDPXz0a6GveJz22DpVw9P7KXJvh7K5NzhCIkYb4CVL4yD4DJBZbBR1Dt2jTdC/o0fIgWu1gqyGvBT6t6rSNq8qyipr3CAeP6zWVxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6uMEmdMfVlqm5rU5PnUE2LtgpglU0E0PvFsSbZ1O1JY=; b=oorRUD8ac66+vFQW2mMB17fCO//3AZX8sgxtVhXEql1xD6wvMLCdouVfHdOqoxITQ6wtGvHWcBGYGcS0YohiFzmA3BIoXKcJ7SteM4UrmYIn0U8LrmBbEfKA9ePKV311aXSQeTxY+hXxe+am3xCI7pPZQiOEouH+X29eqFQBMYc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB6718.namprd12.prod.outlook.com (2603:10b6:510:1b1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.36; Mon, 19 Jun 2023 15:46:02 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6500.036; Mon, 19 Jun 2023 15:46:02 +0000 Message-ID: <8454995a-c1e4-8df6-b4d5-aedca8be335a@amd.com> Date: Mon, 19 Jun 2023 16:45:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4 00/34] net/sfc: support HW conntrack assistance Content-Language: en-US To: Ivan Malov , dev@dpdk.org Cc: Andrew Rybchenko References: <20230601195538.8265-1-ivan.malov@arknetworks.am> <20230607130245.8048-1-ivan.malov@arknetworks.am> From: Ferruh Yigit In-Reply-To: <20230607130245.8048-1-ivan.malov@arknetworks.am> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0034.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB6718:EE_ X-MS-Office365-Filtering-Correlation-Id: 942edaf3-7887-452d-5c41-08db70dc4900 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1wifJn8zOycdUhxNweK6DHyUP5wZFQHmsfxQryfBP1bFbr5HidJUilCY4Sm1cnAUbmMQyY5aZNFBUtjy2U4gjC+1mb21Q9kfv2lklRxpfXsca8Gy0m0e6Y5APL0Zl31mQ9Ai0PlY1G8QokbQ36oRb8RtkAB4E5//QW36ZWVqL9hMviVUKkIXHfjKc57uFqiLo4c3gxdQ8a8Li1OFLgS877kDdxROUaDmcrz+jWzg9sUCr3ZS9NPHlx5exiVsk+W6l+SSnMJSZxmfl2aZmO7hxwsPl1/potJh2GuzlzYvr8tFOEPxsIw2OquJi/rfts3jYyq1bvLvi2KOnSDLTMBM1fJssTZfikmr1PZto7qVVcMhGFjjLArHz7THC0tVy8HHuCZabiXE/Spd4jmbS9uwDWkdbcLNhk+OXktj6OOZ/qaN4V5vZbyYvsG7ygyFCubfCVhCkI5ljLxIKCNXsuS5mmRGbC63Cf1zDIJbE/kWZ92ZMchI/RMS0Dt6yAVp6yreTdd6mgHxPxAvi6c3pNu05NnHIeVSB2neR4zkOPRYob26tLoSHbzCBKdwz7e3HTGCImxekS8i9QbK+87pZHFz2lg32kbQ2I6wk6kn3uKmPIEM1yQqvIhaqnwODi6RKPNeADYuG9qWREfFzl4FL4gTaQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(396003)(366004)(376002)(39860400002)(451199021)(31696002)(44832011)(31686004)(83380400001)(38100700002)(86362001)(41300700001)(8936002)(8676002)(5660300002)(66556008)(66476007)(66946007)(316002)(2616005)(6506007)(53546011)(6512007)(26005)(6666004)(186003)(6486002)(478600001)(4326008)(2906002)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzVNdmV4eXRtZmFicURrV3lvV1dyWTM3RGhHY2JtYWducXFMT1VDUnpuR3Uw?= =?utf-8?B?ekwzYWNnMHNLMEwxR3VIUlB3a0pxTW5Wc1M4aXVKV2pUZy9NTkFvZFVaQU1r?= =?utf-8?B?R1l1S2ZDclpjNWVUOWMzK1p6cDlBSkZNcCtqUUg4ZGtFRUxTRVRpZE83dEh4?= =?utf-8?B?bzQ5S0NWT09pWWxXRWNNWU5tUXpMYmVraWhBN1VjbmtySHhlSm5JN2tLbEpU?= =?utf-8?B?Vzc0OHVFVXpGdWxSeVk1UmcyVVkrS0JRUVluVjA5R0I2TlR1VFEvdFdpZXA0?= =?utf-8?B?SnhGUWNMUzA0NDBRWVRZeWh6bUFRdW1BWTk5WjBTdXBZdjNYempmTEtPQVRh?= =?utf-8?B?QStWNU55bll0M0xFeXlTZDlwWnJIY3dvN04yL3NsSHRHeTlFNVRMUmkxcjI0?= =?utf-8?B?aEY1Ym02MlBjL2cwcHYyaHR0a1k0TUozTHBha0FIa09VRDZyYmp2SnlPbmFX?= =?utf-8?B?S1JWOUI5dHR4Ty95OStRdUlaTG9oNDNkV2xNSUJoTDN4UHRiMmIwM3VqQXl5?= =?utf-8?B?cGNzdFdtWXBOU1dNbFBLZDFCdkNZdDdJbzlyU3JaZXdOQ0pSMXIwVExHbVBF?= =?utf-8?B?QXFkNitOS3hlZmY5MmFKQ25XTnpVdmNCL1dsckExVUJFKzR5VlUzT2p1YnFO?= =?utf-8?B?UGdZZ2NzMTlyU1hxeVJEMEpUcWdMVVJ6bnZhTFNCQjZHb2xCVnErc3V4MWNo?= =?utf-8?B?VVRQZHpVQXpWNEltRVRqMlNWSXU4VDJlUElLaFRPRVo4Y2VoKzRybGYwL0Zp?= =?utf-8?B?ajNoQVZXd1phbGE1RVRobWcrRXFVUmpPd3BZSmpEcFVrQXcvYzZZdU9tQnp3?= =?utf-8?B?Si9pWFVxK2djWk1IOUw3SWZoc1dZU2xydXpqOUoyZmlGK0lrMldubjdqellO?= =?utf-8?B?ckQxSVMyZDVldStmZGZib1JjOFVadVVSYWZxUWQ2OHFvQkQ4Q2V4YzdQZkZD?= =?utf-8?B?blExbjVEZk0wcUF4dFBFN29EQjFjV1VXNDU4QXVpalZRMXhXN21waEd6azRu?= =?utf-8?B?NkNlQlF1T2s0RWVxaXFvWkZ4MUY2Z1BEcjIrR290dVdEcXpIc2p3Y1lCbXUr?= =?utf-8?B?TXE4U3NYdWowd2c4dWozR3NqQ2o1ZFhuTnNkMWdBR04yOUtzVWhYNTdsc2hm?= =?utf-8?B?bXlYdFkwajdiTEdwWkptRnBHZmdLVy9aWUlaSGp5YmR1Y0RXTWNKc1RwNDZy?= =?utf-8?B?cTBYZDNwVHI3Zy9FYkdLMlB6R3E3TVNLK1Y5b0VhbnNVcW51M1RjVW5GQzcr?= =?utf-8?B?TWJkb3lXcnIyVjBlRkpEZVA3NUorREhBYlVjQ0VMUUJ3YmpUUHZCdjZ0V210?= =?utf-8?B?R1ZpV0NLbTRHc2YrRmF4eUNOK3hDMUxZUmRtYVNubzgwcWxaTG9Tb0sreERa?= =?utf-8?B?SXVBeTJ5ampzN2dWNmpwZXliQXZxV0lIQnFzTFVSUThKTTFwUWVqL1I0dkdF?= =?utf-8?B?VTh2azVvM1hlMmw0STQ1WVFhcDRYd2NZVWFLRHFwWm0yZVZKVktmOWJBRVhy?= =?utf-8?B?UXROY1l4cjQrNlBUMyt0TkhqVE1NVzhqMVVPRE1hWnJXVzdyWUltMFJtdURJ?= =?utf-8?B?dVBzY0QyTGxmYVpEQS9WL3FyZk9OVlp5eE5ZR3k3OVQ1Z0dRbWtQKzJBa3RS?= =?utf-8?B?ZUYrMFZ2TlNBcXFESFo1QUZRenRFNitVd1NZakNDckFhcDZtdEZ1MHB2b1RU?= =?utf-8?B?TE41UnpEQ1NDRzZOcHVkdVN1UGVPSlRwcmZMVDNNNnJYZzdJL0Y2SWVUVUFl?= =?utf-8?B?R1UxekpaTW50bEZGUzFUZ3RmY0NQMjgxaTd6TkhGZlBGWmhJeGkrRVZqcVF6?= =?utf-8?B?bFlwK2RCWDNER05jamI4VlFmZ2p6U1FQMmlONVAxQmUyelpvcnBhNnpmUm9x?= =?utf-8?B?dy9qUWI0RURKWDNPVlpYbC9NVWNzWkpzdkhpcWpPcndjN1dEaDAvMU5NTlF5?= =?utf-8?B?Vm5OaUErekt1MUQwVFR5aDVTYW1hOTd5QUZvTFp6SXBMSUtYWXAzQUdGODIr?= =?utf-8?B?VEwvcGhjaHllNmpsajZVZXloZXR6WE5ieC8vcndiWHIwY1RSV0pNSEZjWDJp?= =?utf-8?B?MHk2MFV4ZFJvemp6aEdySFJWVUJQeUg2VncwZVNYdXU1b2kvaGZ6TzMwMG9L?= =?utf-8?Q?YKm1nYm1aqEGQZYeMU9oA5EwY?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 942edaf3-7887-452d-5c41-08db70dc4900 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 15:46:02.4485 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: klGLSctnfsDBiuCI+EwR5Sm1iIbdemuafSenpPCgKn7tpK1scydVQqtZxH9fdzI2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6718 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/7/2023 2:02 PM, Ivan Malov wrote: > On EF100 hardware, match-action engine (MAE) can be equipped > with an assistance table for connection tracking (CT). In it, > an entry key is a set of exact match fields: an EtherType, a > pair of IP addresses, a L4 protocol ID and a pair of L4 port > numbers. An entry response can provide matching packets with > a mark value and additional data to be plumbed to NAT action. > In addition, an update to mark-and-sweep counter can be done. > > This table was designed with larger capacity in mind, > so moving the above match criteria out of an action > rule (AR) specification to a CT entry increases the > likelihood of reusing AR entries and improves the > total flow engine capacity. Make use of that. > > Changes in v2: > * Found and fixed my own mistake in [15/34] > * Fixed [16/34] as per 0-day robot report > * Added missing release notes to [27/34] > * Added missing release notes to [30/34] > > Changes in v3: > * Fixed release notes in [27/34] > * Rebased on dpdk to fix CI > > Changes in v4: > * Applied review notes in [05/34], [08/34], [09/34] and [10/34]. > > Denis Pryazhennikov (11): > common/sfc_efx/base: update MCDI headers > common/sfc_efx/base: detect MCDI Table Access API support > common/sfc_efx/base: add API to list HW tables > common/sfc_efx/base: add macro to get indexed QWORD field > common/sfc_efx/base: add API to get HW table desc > common/sfc_efx/base: add API to insert data to HW table > common/sfc_efx/base: add API to delete entry from HW table > net/sfc: add MCDI wrappers for BCAM tables > net/sfc: add functions to manipulate MCDI table fields > net/sfc: attach to HW table API > net/sfc: add API to manage HW Conntrack table > > Ivan Malov (23): > net/sfc: make entry pointer optional in MAE resource helpers > net/sfc: turn flow create/destroy methods into lock wrappers > net/sfc: let driver-internal flows use VF representor action > net/sfc: extend generic flow API to allow for internal flows > net/sfc: switch driver-internal flows to use generic methods > net/sfc: move MAE flow parsing method to MAE-specific source > net/sfc: move MAE counter stream start to action set handler > net/sfc: prepare MAE outer rules for action rule indirection > net/sfc: turn MAE flow action rules into shareable resources > common/sfc_efx/base: provide an API to clone MAE match specs > common/sfc_efx/base: add API to read back MAE match criteria > common/sfc_efx/base: match on conntrack mark in action rules > common/sfc_efx/base: add API to request MAE conntrack lookup > net/sfc: make use of conntrack assistance for transfer flows Well done Ivan ;)