Re: [PATCH] vhost/crypto: fix uninitialized variable

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 5/15/25 10:10 AM, Gowrishankar Muthukrishnan wrote:
> Fix uninitialized variable as reported in coverity scan.
> 
> Coverity-issue: 457449
> Fixes: d1b484bf187 ("vhost/crypto: support asymmetric RSA")
> 
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> ---
>   lib/vhost/vhost_crypto.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/vhost/vhost_crypto.c b/lib/vhost/vhost_crypto.c
> index f78daf98d1..66ba5342e2 100644
> --- a/lib/vhost/vhost_crypto.c
> +++ b/lib/vhost/vhost_crypto.c
> @@ -1493,10 +1493,10 @@ vhost_crypto_process_one_req(struct vhost_crypto *vcrypto,
>   	struct vhost_crypto_data_req *vc_req, *vc_req_out;
>   	struct rte_cryptodev_asym_session *asym_session;
>   	struct rte_cryptodev_sym_session *sym_session;
> +	struct vhost_crypto_data_req data_req = {0};
>   	struct vhost_crypto_session *vhost_session;
>   	struct vhost_crypto_desc *desc = descs;
>   	uint32_t nb_descs = 0, max_n_descs, i;
> -	struct vhost_crypto_data_req data_req;
>   	struct virtio_crypto_op_data_req req;
>   	struct virtio_crypto_inhdr *inhdr;
>   	struct vring_desc *src_desc;

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime