From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 45EAF1DB1 for ; Mon, 7 Nov 2016 14:08:59 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id t79so176150923wmt.0 for ; Mon, 07 Nov 2016 05:08:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Bsc3+poSPi+3OyDMB0aG9I9RfOVzH17d+JRCHSW3jZE=; b=q7xsdRAQrZ2vSg6+S7mKUMRg6uuvfSCOKKdsEG7gNgVsofVWHAOs9cyVQITisJNU31 sFpDHq4vcd90PkwdJ4e1YIvFvqkwHbkhTFPi2gmwKqHucDZd3240V3rL2nY/Z4lrOlSB XKmT8lXvn/AdvEHa1gPEUh2AnuqrviFsl4kHwvZo2rDNthUy/JSE08JOOkztf/aY4uXX 0auOP7b3wsrMVm1D+WXmpHtfi/FufpEi08K7Mp2fzyvleMjE5I2A8gqniImJY86XtfzY AE8IRjQieFQxpsBC9kkmrH5EpKwB0IMCnbdIzOdWc4gCQ+9uqo5kQzbfjmzkQVf785EI 8L+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Bsc3+poSPi+3OyDMB0aG9I9RfOVzH17d+JRCHSW3jZE=; b=Vw2al4ESdq++TBARluIwuH1/i1Fl0jnrwYPLKk591bKnTbXS6KqxOkTafDOprKYXYo YiGFEinkwosroYp4SdSyNTTGhrf2nEpWVSoyf92LYjybWjs1/fMNcyqJYo5e/2qW3Tld urWPWtzY2TFoBMR+u2IHxCtFe3fQUqSTSOi4YPaQjCHd0Ywsd2SRcxircIN/ObcFzhCm Zx3lneSEoRQHUPr/ntZ9JOtuijkyoAlNaVLlfvh7KAvUYUqR+sV+AbaPmNPgKhcUQCu/ ct22oB9iiZyELeJZGIBMDh33215f5j4SPa/r+bfGGOMPsupcljwf/w28Lcxif4QnreAp h3DQ== X-Gm-Message-State: ABUngvdT/5GJSc+58uopyaKwdQVHBxLR/+SnjZkrnkgEL8SclmJDUYnwydtaPFEN9YmSorSD X-Received: by 10.194.175.42 with SMTP id bx10mr7062515wjc.47.1478524138991; Mon, 07 Nov 2016 05:08:58 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id ma5sm30953769wjb.47.2016.11.07.05.08.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Nov 2016 05:08:57 -0800 (PST) From: Thomas Monjalon To: Mauricio Vasquez B Cc: dev@dpdk.org, Ferruh Yigit , bruce.richardson@intel.com Date: Mon, 07 Nov 2016 14:08:56 +0100 Message-ID: <8471661.hSFy5i1P0L@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <162c0602-5fff-fa80-98c5-3725fcb96e69@intel.com> References: <1478030140-7127-1-git-send-email-mauricio.vasquez@polito.it> <1478094369-3943-1-git-send-email-mauricio.vasquez@polito.it> <162c0602-5fff-fa80-98c5-3725fcb96e69@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] net/ring: remove unnecessary NULL check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2016 13:08:59 -0000 2016-11-02 14:05, Ferruh Yigit: > On 11/2/2016 1:46 PM, Mauricio Vasquez B wrote: > > Coverity detected this as an issue because internals->data will never be NULL, > > then the check is not necessary. > > > > Fixes: d082c0395bf6 ("ring: fix memory leak when detaching") > > Coverity issue: 137873 > > > > Signed-off-by: Mauricio Vasquez B > > Acked-by: Ferruh Yigit Applied, thanks