From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 181C1326C for ; Mon, 22 Apr 2019 14:48:54 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 26275DCDF; Mon, 22 Apr 2019 08:48:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 22 Apr 2019 08:48:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=p0RqM4GNiGzEym1m3rcTkXcBBSu3PFfVVEQVltRkMmE=; b=WqEbhqEgrYoe L0J31kxn6JUGpe3Kdr5CPa1e4WU7whWdZuo/g3MekCEweSS2dnUIa6Zv0uQuz1fY IjAUarFyX4SZ/i1dArPi1Ji6bGo/D8y1Crx1o3Yt3AVNAmsbtIG9rESW0UBB0cvp VmGrr26ot54VQAdGgdWHytBl9YR1SrY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=p0RqM4GNiGzEym1m3rcTkXcBBSu3PFfVVEQVltRkM mE=; b=kUIdvD1uDjm4y9Czj4pV8WqBTcZfk2mN38Odf2fswn+lClrcU0zuhwAXp Y232OZJE4qFxDxFdV+KohO0vdsXJUq/dPtG4tvYkQAntTqnwNtk/Z0bar69c4bEm ItuuHS+9gByKR94BWbqkUHtc0J5P3R3WwoUfgb18PrcmXjBiQCjO9gdJ5R+HMgSo 6xZbRITtmd9BdsMIPBQbYaMU2nkvCgLSqGyER3JoIIAYQIeCF1k6KIb5ZIPRtxO1 kgI+LZP587/janfDrw4jmLUNF3rjq6ftgECwWLI6/TCpvb4LQYZRONVUWiAjSMeh ya4i0ahm0ArObx16bOMLLKViTsYJA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeeigdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epledtrddvledrudehkedrudehleenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (alyon-655-1-477-159.w90-29.abo.wanadoo.fr [90.29.158.159]) by mail.messagingengine.com (Postfix) with ESMTPA id 357A0103C8; Mon, 22 Apr 2019 08:48:49 -0400 (EDT) From: Thomas Monjalon To: "Rao, Nikhil" Cc: "jerinj@marvell.com" , "dev@dpdk.org" , Mattias =?ISO-8859-1?Q?R=F6nnblom?= , "Van Haaren, Harry" , "Gujjar, Abhinandan S" , "Carrillo, Erik G" , "pbhagavatula@marvell.com" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "Ma, Liang J" Date: Mon, 22 Apr 2019 14:48:42 +0200 Message-ID: <8482996.cdUznqbjgC@xps> In-Reply-To: <1F668163772FA946975B9466A9DFF729EDDFE270@ORSMSX122.amr.corp.intel.com> References: <20190418120538.16020-1-jerinj@marvell.com> <20190419121040.37227-1-jerinj@marvell.com> <1F668163772FA946975B9466A9DFF729EDDFE270@ORSMSX122.amr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] eventdev: promote adapter functions as stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2019 12:48:54 -0000 > > Promote the adapter functions and rte_event_port_unlinks_in_progress() > > as stable as it's been added for a while now and multiple drivers and test > > application like test-eventdev has been tested using the adapter APIs. > > > > Cc: nikhil.rao@intel.com > > Cc: erik.g.carrillo@intel.com > > Cc: abhinandan.gujjar@intel.com > > Cc: pbhagavatula@marvell.com > > Cc: hemant.agrawal@nxp.com > > Cc: nipun.gupta@nxp.com > > Cc: harry.van.haaren@intel.com > > Cc: mattias.ronnblom@ericsson.com > > Cc: liang.j.ma@intel.com > > > > Signed-off-by: Jerin Jacob > > --- > > /** > > - * @warning > > - * @b EXPERIMENTAL: this API may change without prior notice > > - * > > * Register callback to process Rx packets, this is supported for > > * SW based packet transfers. > > * @see rte_event_eth_rx_cb_fn > > @@ -501,7 +453,7 @@ int > > rte_event_eth_rx_adapter_service_id_get(uint8_t id, uint32_t *service_id); > > * - 0: Success > > * - <0: Error code on failure. > > */ > > -int __rte_experimental > > +int > > rte_event_eth_rx_adapter_cb_register(uint8_t id, > > uint16_t eth_dev_id, > > rte_event_eth_rx_adapter_cb_fn cb_fn, > > Sorry for the delay in reply, I would like to retain the rte_event_eth_rx_adapter_cb_register() function as experimental. > I will be posting a patch for this function to accept events instead of mbufs. > > Since Thomas just applied the patch, should I be posting a new patch that reverts the lines above ? Sorry I hesitated to wait more for your feedback. Guessing the right time to apply a patch is a difficult heuristic :) Yes please send a patch to revert for this function. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8ADA5A05D3 for ; Mon, 22 Apr 2019 14:48:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA0D81B460; Mon, 22 Apr 2019 14:48:55 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 181C1326C for ; Mon, 22 Apr 2019 14:48:54 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 26275DCDF; Mon, 22 Apr 2019 08:48:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 22 Apr 2019 08:48:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=p0RqM4GNiGzEym1m3rcTkXcBBSu3PFfVVEQVltRkMmE=; b=WqEbhqEgrYoe L0J31kxn6JUGpe3Kdr5CPa1e4WU7whWdZuo/g3MekCEweSS2dnUIa6Zv0uQuz1fY IjAUarFyX4SZ/i1dArPi1Ji6bGo/D8y1Crx1o3Yt3AVNAmsbtIG9rESW0UBB0cvp VmGrr26ot54VQAdGgdWHytBl9YR1SrY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=p0RqM4GNiGzEym1m3rcTkXcBBSu3PFfVVEQVltRkM mE=; b=kUIdvD1uDjm4y9Czj4pV8WqBTcZfk2mN38Odf2fswn+lClrcU0zuhwAXp Y232OZJE4qFxDxFdV+KohO0vdsXJUq/dPtG4tvYkQAntTqnwNtk/Z0bar69c4bEm ItuuHS+9gByKR94BWbqkUHtc0J5P3R3WwoUfgb18PrcmXjBiQCjO9gdJ5R+HMgSo 6xZbRITtmd9BdsMIPBQbYaMU2nkvCgLSqGyER3JoIIAYQIeCF1k6KIb5ZIPRtxO1 kgI+LZP587/janfDrw4jmLUNF3rjq6ftgECwWLI6/TCpvb4LQYZRONVUWiAjSMeh ya4i0ahm0ArObx16bOMLLKViTsYJA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeeigdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epledtrddvledrudehkedrudehleenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (alyon-655-1-477-159.w90-29.abo.wanadoo.fr [90.29.158.159]) by mail.messagingengine.com (Postfix) with ESMTPA id 357A0103C8; Mon, 22 Apr 2019 08:48:49 -0400 (EDT) From: Thomas Monjalon To: "Rao, Nikhil" Cc: "jerinj@marvell.com" , "dev@dpdk.org" , Mattias =?ISO-8859-1?Q?R=F6nnblom?= , "Van Haaren, Harry" , "Gujjar, Abhinandan S" , "Carrillo, Erik G" , "pbhagavatula@marvell.com" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "Ma, Liang J" Date: Mon, 22 Apr 2019 14:48:42 +0200 Message-ID: <8482996.cdUznqbjgC@xps> In-Reply-To: <1F668163772FA946975B9466A9DFF729EDDFE270@ORSMSX122.amr.corp.intel.com> References: <20190418120538.16020-1-jerinj@marvell.com> <20190419121040.37227-1-jerinj@marvell.com> <1F668163772FA946975B9466A9DFF729EDDFE270@ORSMSX122.amr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] eventdev: promote adapter functions as stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190422124842.0ccStEVpG-anwy4e3RTRSLtWHFNrYLeh0nVengVAryI@z> > > Promote the adapter functions and rte_event_port_unlinks_in_progress() > > as stable as it's been added for a while now and multiple drivers and test > > application like test-eventdev has been tested using the adapter APIs. > > > > Cc: nikhil.rao@intel.com > > Cc: erik.g.carrillo@intel.com > > Cc: abhinandan.gujjar@intel.com > > Cc: pbhagavatula@marvell.com > > Cc: hemant.agrawal@nxp.com > > Cc: nipun.gupta@nxp.com > > Cc: harry.van.haaren@intel.com > > Cc: mattias.ronnblom@ericsson.com > > Cc: liang.j.ma@intel.com > > > > Signed-off-by: Jerin Jacob > > --- > > /** > > - * @warning > > - * @b EXPERIMENTAL: this API may change without prior notice > > - * > > * Register callback to process Rx packets, this is supported for > > * SW based packet transfers. > > * @see rte_event_eth_rx_cb_fn > > @@ -501,7 +453,7 @@ int > > rte_event_eth_rx_adapter_service_id_get(uint8_t id, uint32_t *service_id); > > * - 0: Success > > * - <0: Error code on failure. > > */ > > -int __rte_experimental > > +int > > rte_event_eth_rx_adapter_cb_register(uint8_t id, > > uint16_t eth_dev_id, > > rte_event_eth_rx_adapter_cb_fn cb_fn, > > Sorry for the delay in reply, I would like to retain the rte_event_eth_rx_adapter_cb_register() function as experimental. > I will be posting a patch for this function to accept events instead of mbufs. > > Since Thomas just applied the patch, should I be posting a new patch that reverts the lines above ? Sorry I hesitated to wait more for your feedback. Guessing the right time to apply a patch is a difficult heuristic :) Yes please send a patch to revert for this function.