From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 0C20C2B9B for ; Mon, 3 Apr 2017 16:45:49 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 03 Apr 2017 07:45:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,270,1486454400"; d="scan'208";a="841266663" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by FMSMGA003.fm.intel.com with ESMTP; 03 Apr 2017 07:45:47 -0700 To: Bruce Richardson , helin.zhang@intel.com, jingjing.wu@intel.com References: <20170403143944.17719-1-bruce.richardson@intel.com> <20170403143944.17719-3-bruce.richardson@intel.com> Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, jianbo.liu@linaro.org From: Ferruh Yigit Message-ID: <84c55d48-513b-f9c2-c9e2-8e2cc920f989@intel.com> Date: Mon, 3 Apr 2017 15:45:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170403143944.17719-3-bruce.richardson@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] net/i40e: remove option to disable offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Apr 2017 14:45:50 -0000 On 4/3/2017 3:39 PM, Bruce Richardson wrote: > Having packets received without any offload flags given in the mbuf is not > very useful, and performance tests with testpmd indicates little to no > benefit is got with the current code by turning off the flags. This makes > the build-time option pointless, so we can remove it. > > Signed-off-by: Bruce Richardson > --- > config/common_base | 1 - > doc/guides/nics/i40e.rst | 5 ----- > drivers/net/i40e/i40e_rxtx_vec_common.h | 8 -------- > drivers/net/i40e/i40e_rxtx_vec_neon.c | 11 ----------- > drivers/net/i40e/i40e_rxtx_vec_sse.c | 11 ----------- Should this patch also update powerpc vector PMD (i40e_rxtx_vec_altivec.c) ? Thanks, ferruh