From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org, Aman Singh <aman.deep.singh@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: [PATCH v2 1/2] app/testpmd: harmonize case in help strings
Date: Fri, 23 May 2025 11:36:04 +0100 [thread overview]
Message-ID: <84ed4f7e118e8003cc00826f605555212ec07781.1747996555.git.anatoly.burakov@intel.com> (raw)
In-Reply-To: <9d6e0ff75abe0185c5a03aecba3269668860a1f7.1747227723.git.anatoly.burakov@intel.com>
Most testpmd help strings are lower case. Amend those that aren't.
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
Notes:
v1 -> v2:
- Make TM uniformly uppercase instead of lowercase
app/test-pmd/cmdline.c | 4 ++--
app/test-pmd/cmdline_tm.c | 46 +++++++++++++++++++--------------------
2 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index b6152c07e6..712d307ae0 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -8112,7 +8112,7 @@ static cmdline_parse_token_string_t cmd_operate_set_counter_name =
static cmdline_parse_inst_t cmd_operate_set_counter = {
.f = cmd_operate_set_counter_parsed,
.data = NULL,
- .help_str = "port (port_id) enable|disable <counter_name>",
+ .help_str = "port <port_id> enable|disable <counter_name>",
.tokens = {
(void *)&cmd_operate_set_counter_port,
(void *)&cmd_operate_set_counter_port_id,
@@ -9068,7 +9068,7 @@ static cmdline_parse_token_string_t cmd_dump_dump =
static cmdline_parse_inst_t cmd_dump = {
.f = cmd_dump_parsed, /* function to call */
.data = NULL, /* 2nd arg of func */
- .help_str = "Dump status",
+ .help_str = "dump status",
.tokens = { /* token list, NULL terminated */
(void *)&cmd_dump_dump,
NULL,
diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c
index 7ade91549c..2b165b62c6 100644
--- a/app/test-pmd/cmdline_tm.c
+++ b/app/test-pmd/cmdline_tm.c
@@ -327,7 +327,7 @@ static void cmd_show_port_tm_cap_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_show_port_tm_cap = {
.f = cmd_show_port_tm_cap_parsed,
.data = NULL,
- .help_str = "Show Port TM Capabilities",
+ .help_str = "show port TM capabilities",
.tokens = {
(void *)&cmd_show_port_tm_cap_show,
(void *)&cmd_show_port_tm_cap_port,
@@ -475,7 +475,7 @@ static void cmd_show_port_tm_level_cap_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_show_port_tm_level_cap = {
.f = cmd_show_port_tm_level_cap_parsed,
.data = NULL,
- .help_str = "Show port TM hierarchical level capabilities",
+ .help_str = "show port TM hierarchical level capabilities",
.tokens = {
(void *)&cmd_show_port_tm_level_cap_show,
(void *)&cmd_show_port_tm_level_cap_port,
@@ -598,7 +598,7 @@ static void cmd_show_port_tm_node_cap_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_show_port_tm_node_cap = {
.f = cmd_show_port_tm_node_cap_parsed,
.data = NULL,
- .help_str = "Show Port TM Hierarchy node capabilities",
+ .help_str = "show port TM hierarchy node capabilities",
.tokens = {
(void *)&cmd_show_port_tm_node_cap_show,
(void *)&cmd_show_port_tm_node_cap_port,
@@ -716,7 +716,7 @@ static void cmd_show_port_tm_node_stats_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_show_port_tm_node_stats = {
.f = cmd_show_port_tm_node_stats_parsed,
.data = NULL,
- .help_str = "Show port tm node stats",
+ .help_str = "show port TM node stats",
.tokens = {
(void *)&cmd_show_port_tm_node_stats_show,
(void *)&cmd_show_port_tm_node_stats_port,
@@ -795,7 +795,7 @@ static void cmd_show_port_tm_node_type_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_show_port_tm_node_type = {
.f = cmd_show_port_tm_node_type_parsed,
.data = NULL,
- .help_str = "Show port tm node type",
+ .help_str = "show port TM node type",
.tokens = {
(void *)&cmd_show_port_tm_node_type_show,
(void *)&cmd_show_port_tm_node_type_port,
@@ -942,7 +942,7 @@ static void cmd_add_port_tm_node_shaper_profile_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_add_port_tm_node_shaper_profile = {
.f = cmd_add_port_tm_node_shaper_profile_parsed,
.data = NULL,
- .help_str = "Add port tm node private shaper profile",
+ .help_str = "add port TM node private shaper profile",
.tokens = {
(void *)&cmd_add_port_tm_node_shaper_profile_add,
(void *)&cmd_add_port_tm_node_shaper_profile_port,
@@ -1029,7 +1029,7 @@ static void cmd_del_port_tm_node_shaper_profile_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_del_port_tm_node_shaper_profile = {
.f = cmd_del_port_tm_node_shaper_profile_parsed,
.data = NULL,
- .help_str = "Delete port tm node private shaper profile",
+ .help_str = "delete port TM node private shaper profile",
.tokens = {
(void *)&cmd_del_port_tm_node_shaper_profile_del,
(void *)&cmd_del_port_tm_node_shaper_profile_port,
@@ -1130,7 +1130,7 @@ static void cmd_add_port_tm_node_shared_shaper_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_add_port_tm_node_shared_shaper = {
.f = cmd_add_port_tm_node_shared_shaper_parsed,
.data = NULL,
- .help_str = "add/update port tm node shared shaper",
+ .help_str = "add/update port TM node shared shaper",
.tokens = {
(void *)&cmd_add_port_tm_node_shared_shaper_cmd_type,
(void *)&cmd_add_port_tm_node_shared_shaper_port,
@@ -1210,7 +1210,7 @@ static void cmd_del_port_tm_node_shared_shaper_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_del_port_tm_node_shared_shaper = {
.f = cmd_del_port_tm_node_shared_shaper_parsed,
.data = NULL,
- .help_str = "delete port tm node shared shaper",
+ .help_str = "delete port TM node shared shaper",
.tokens = {
(void *)&cmd_del_port_tm_node_shared_shaper_del,
(void *)&cmd_del_port_tm_node_shared_shaper_port,
@@ -1390,7 +1390,7 @@ static void cmd_add_port_tm_node_wred_profile_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_add_port_tm_node_wred_profile = {
.f = cmd_add_port_tm_node_wred_profile_parsed,
.data = NULL,
- .help_str = "Add port tm node wred profile",
+ .help_str = "add port TM node wred profile",
.tokens = {
(void *)&cmd_add_port_tm_node_wred_profile_add,
(void *)&cmd_add_port_tm_node_wred_profile_port,
@@ -1483,7 +1483,7 @@ static void cmd_del_port_tm_node_wred_profile_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_del_port_tm_node_wred_profile = {
.f = cmd_del_port_tm_node_wred_profile_parsed,
.data = NULL,
- .help_str = "Delete port tm node wred profile",
+ .help_str = "delete port TM node wred profile",
.tokens = {
(void *)&cmd_del_port_tm_node_wred_profile_del,
(void *)&cmd_del_port_tm_node_wred_profile_port,
@@ -1577,7 +1577,7 @@ static void cmd_set_port_tm_node_shaper_profile_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_set_port_tm_node_shaper_profile = {
.f = cmd_set_port_tm_node_shaper_profile_parsed,
.data = NULL,
- .help_str = "Set port tm node shaper profile",
+ .help_str = "set port TM node shaper profile",
.tokens = {
(void *)&cmd_set_port_tm_node_shaper_profile_set,
(void *)&cmd_set_port_tm_node_shaper_profile_port,
@@ -1744,7 +1744,7 @@ static void cmd_add_port_tm_nonleaf_node_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_add_port_tm_nonleaf_node = {
.f = cmd_add_port_tm_nonleaf_node_parsed,
.data = NULL,
- .help_str = "Add port tm nonleaf node",
+ .help_str = "add port TM nonleaf node",
.tokens = {
(void *)&cmd_add_port_tm_nonleaf_node_add,
(void *)&cmd_add_port_tm_nonleaf_node_port,
@@ -1911,7 +1911,7 @@ static void cmd_add_port_tm_nonleaf_node_pmode_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_add_port_tm_nonleaf_node_pmode = {
.f = cmd_add_port_tm_nonleaf_node_pmode_parsed,
.data = NULL,
- .help_str = "Add port tm nonleaf node pktmode",
+ .help_str = "add port TM nonleaf node pktmode",
.tokens = {
(void *)&cmd_add_port_tm_nonleaf_node_pmode_add,
(void *)&cmd_add_port_tm_nonleaf_node_pmode_port,
@@ -2089,7 +2089,7 @@ static void cmd_add_port_tm_leaf_node_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_add_port_tm_leaf_node = {
.f = cmd_add_port_tm_leaf_node_parsed,
.data = NULL,
- .help_str = "Add port tm leaf node",
+ .help_str = "add port TM leaf node",
.tokens = {
(void *)&cmd_add_port_tm_leaf_node_add,
(void *)&cmd_add_port_tm_leaf_node_port,
@@ -2301,7 +2301,7 @@ static void cmd_del_port_tm_node_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_del_port_tm_node = {
.f = cmd_del_port_tm_node_parsed,
.data = NULL,
- .help_str = "Delete port tm node",
+ .help_str = "delete port TM node",
.tokens = {
(void *)&cmd_del_port_tm_node_del,
(void *)&cmd_del_port_tm_node_port,
@@ -2394,7 +2394,7 @@ static void cmd_set_port_tm_node_parent_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_set_port_tm_node_parent = {
.f = cmd_set_port_tm_node_parent_parsed,
.data = NULL,
- .help_str = "Set port tm node parent",
+ .help_str = "set port TM node parent",
.tokens = {
(void *)&cmd_set_port_tm_node_parent_set,
(void *)&cmd_set_port_tm_node_parent_port,
@@ -2465,7 +2465,7 @@ static void cmd_suspend_port_tm_node_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_suspend_port_tm_node = {
.f = cmd_suspend_port_tm_node_parsed,
.data = NULL,
- .help_str = "Suspend port tm node",
+ .help_str = "suspend port TM node",
.tokens = {
(void *)&cmd_suspend_port_tm_node_suspend,
(void *)&cmd_suspend_port_tm_node_port,
@@ -2530,7 +2530,7 @@ static void cmd_resume_port_tm_node_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_resume_port_tm_node = {
.f = cmd_resume_port_tm_node_parsed,
.data = NULL,
- .help_str = "Resume port tm node",
+ .help_str = "resume port TM node",
.tokens = {
(void *)&cmd_resume_port_tm_node_resume,
(void *)&cmd_resume_port_tm_node_port,
@@ -2602,7 +2602,7 @@ static void cmd_port_tm_hierarchy_commit_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_port_tm_hierarchy_commit = {
.f = cmd_port_tm_hierarchy_commit_parsed,
.data = NULL,
- .help_str = "Commit port tm hierarchy",
+ .help_str = "commit port TM hierarchy",
.tokens = {
(void *)&cmd_port_tm_hierarchy_commit_port,
(void *)&cmd_port_tm_hierarchy_commit_tm,
@@ -2685,7 +2685,7 @@ static void cmd_port_tm_mark_ip_ecn_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_port_tm_mark_ip_ecn = {
.f = cmd_port_tm_mark_ip_ecn_parsed,
.data = NULL,
- .help_str = "set port tm mark ip_ecn <port> <green> <yellow> <red>",
+ .help_str = "set port TM mark ip_ecn <port> <green> <yellow> <red>",
.tokens = {
(void *)&cmd_port_tm_mark_ip_ecn_set,
(void *)&cmd_port_tm_mark_ip_ecn_port,
@@ -2772,7 +2772,7 @@ static void cmd_port_tm_mark_ip_dscp_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_port_tm_mark_ip_dscp = {
.f = cmd_port_tm_mark_ip_dscp_parsed,
.data = NULL,
- .help_str = "set port tm mark ip_dscp <port> <green> <yellow> <red>",
+ .help_str = "set port TM mark ip_dscp <port> <green> <yellow> <red>",
.tokens = {
(void *)&cmd_port_tm_mark_ip_dscp_set,
(void *)&cmd_port_tm_mark_ip_dscp_port,
@@ -2859,7 +2859,7 @@ static void cmd_port_tm_mark_vlan_dei_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_port_tm_mark_vlan_dei = {
.f = cmd_port_tm_mark_vlan_dei_parsed,
.data = NULL,
- .help_str = "set port tm mark vlan_dei <port> <green> <yellow> <red>",
+ .help_str = "set port TM mark vlan_dei <port> <green> <yellow> <red>",
.tokens = {
(void *)&cmd_port_tm_mark_vlan_dei_set,
(void *)&cmd_port_tm_mark_vlan_dei_port,
--
2.47.1
next prev parent reply other threads:[~2025-05-23 10:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 13:02 [PATCH v1 " Anatoly Burakov
2025-05-14 13:02 ` [PATCH v1 2/2] app/testpmd: sort commands by help string Anatoly Burakov
2025-05-14 13:29 ` Bruce Richardson
2025-05-21 22:24 ` Stephen Hemminger
2025-05-23 10:19 ` Burakov, Anatoly
2025-05-23 10:09 ` Anatoly Burakov
2025-05-14 13:26 ` [PATCH v1 1/2] app/testpmd: harmonize case in help strings Bruce Richardson
2025-05-15 11:07 ` Burakov, Anatoly
2025-05-23 10:09 ` Anatoly Burakov
2025-05-23 10:36 ` Anatoly Burakov [this message]
2025-05-23 10:36 ` [PATCH v2 2/2] app/testpmd: sort commands by help string Anatoly Burakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84ed4f7e118e8003cc00826f605555212ec07781.1747996555.git.anatoly.burakov@intel.com \
--to=anatoly.burakov@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).