From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id BDB3B7CBC for ; Thu, 27 Sep 2018 11:37:16 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 00C5F85A01; Thu, 27 Sep 2018 09:37:16 +0000 (UTC) Received: from [10.36.112.65] (ovpn-112-65.ams2.redhat.com [10.36.112.65]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 09A33BF9A6; Thu, 27 Sep 2018 09:37:11 +0000 (UTC) To: Alejandro Lucero Cc: dev , tiwei.bie@intel.com, zhihong.wang@intel.com, jfreimann@redhat.com, dgilbert@redhat.com References: <20180926072705.22641-1-maxime.coquelin@redhat.com> <20180926072705.22641-7-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <850b23e8-678a-e81e-9d20-830ae142b6ff@redhat.com> Date: Thu, 27 Sep 2018 11:37:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 27 Sep 2018 09:37:16 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 06/12] vhost: register new regions with userfaultfd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2018 09:37:17 -0000 On 09/26/2018 05:31 PM, Alejandro Lucero wrote: > > > On Wed, Sep 26, 2018 at 8:28 AM Maxime Coquelin > > wrote: > > Signed-off-by: Dr. David Alan Gilbert > > Signed-off-by: Maxime Coquelin > > --- >  lib/librte_vhost/vhost_user.c | 22 ++++++++++++++++++++++ >  1 file changed, 22 insertions(+) > > diff --git a/lib/librte_vhost/vhost_user.c > b/lib/librte_vhost/vhost_user.c > index d9ef5bca8..cbbfbdf00 100644 > --- a/lib/librte_vhost/vhost_user.c > +++ b/lib/librte_vhost/vhost_user.c > @@ -928,6 +928,28 @@ vhost_user_set_mem_table(struct virtio_net > **pdev, struct VhostUserMsg *pmsg) >                         mmap_size, >                         alignment, >                         mmap_offset); > + > +               if (dev->postcopy_listening) { > +                       struct uffdio_register reg_struct; > + > +                       reg_struct.range.start = > (uint64_t)(uintptr_t)mmap_addr; > +                       reg_struct.range.len = mmap_size; > +                       reg_struct.mode = UFFDIO_REGISTER_MODE_MISSING; > + > +                       if (ioctl(dev->postcopy_ufd, UFFDIO_REGISTER, > +                                               ®_struct)) { > +                               RTE_LOG(ERR, VHOST_CONFIG, > +                                               "Failed to register > ufd for region %d: (ufd = %d) %s\n", > +                                               i, dev->postcopy_ufd, > +                                               strerror(errno)); > +                               continue; > > > is it not a registration error a serious problem for supporting > migration properly? Yes it is, I missed to fix that. Thanks for reporting it. Maxime > +                       } > +                       RTE_LOG(INFO, VHOST_CONFIG, > +                                       "\t userfaultfd registered > for range : %llx - %llx\n", > +                                       reg_struct.range.start, > +                                       reg_struct.range.start + > +                                       reg_struct.range.len - 1); > +               } >         } > >         for (i = 0; i < dev->nr_vring; i++) { > -- > 2.17.1 >