From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 2B3ECDED for ; Tue, 1 May 2018 14:53:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 May 2018 05:53:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,351,1520924400"; d="scan'208";a="35966561" Received: from dwdohert-mobl.ger.corp.intel.com (HELO [163.33.228.121]) ([163.33.228.121]) by fmsmga007.fm.intel.com with ESMTP; 01 May 2018 05:53:54 -0700 To: "Ananyev, Konstantin" , "dev@dpdk.org" References: <20180430153258.1101-1-declan.doherty@intel.com> <20180430153258.1101-3-declan.doherty@intel.com> <2601191342CEEE43887BDE71AB977258AEDC0C74@irsmsx105.ger.corp.intel.com> From: "Doherty, Declan" Message-ID: <851426e4-0dbf-29cf-1417-5c1987baf824@intel.com> Date: Tue, 1 May 2018 13:53:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <2601191342CEEE43887BDE71AB977258AEDC0C74@irsmsx105.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 3/3] net/ixgbe: add null pointer check for pf_ethdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 12:53:56 -0000 On 01/05/2018 10:47 AM, Ananyev, Konstantin wrote: > > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Declan Doherty >> Sent: Monday, April 30, 2018 4:33 PM >> To: dev@dpdk.org >> Cc: Doherty, Declan >> Subject: [dpdk-dev] [PATCH 3/3] net/ixgbe: add null pointer check for pf_ethdev >> >> Add NULL parameter check for rte_eth_dev_allocated() API call to >> eth_ixgbe_pci_probe(). >> >> Coverity Issue: 277216 >> Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports") >> >> Signed-off-by: Declan Doherty >> --- >> drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c >> index 283dd7e49..75f927c06 100644 >> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >> @@ -1747,6 +1747,9 @@ eth_ixgbe_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, >> struct rte_eth_dev *pf_ethdev = rte_eth_dev_allocated( >> pci_dev->device.name); >> >> + if (pf_ethdev == NULL) >> + return -ENODEV; >> + >> for (i = 0; i < eth_da.nb_representor_ports; i++) { >> struct ixgbe_vf_info *vfinfo; >> struct ixgbe_vf_representor representor; >> -- > > Looks good - can I just ask to move pf_ethdev definition to the top of the function? > To comply with dpdk coding style. > Konstantin > Will do. >> 2.14.3 >